Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Jul 2023 20:21:58 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        peter.ujfalusi@gmail.com, jarkko.nikula@bitmer.com,
        dmitry.torokhov@gmail.com, linux-omap@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/3] ASoC: tlv320aic3x: use BCLK instead of MCLK if not
 in master mode
Message-ID: <15d3fc6e-d294-4968-bc7d-66307efc92db@sirena.org.uk>
References: <20230705190324.355282-1-andreas@kemnade.info>
 <20230705190324.355282-3-andreas@kemnade.info>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yoex5Ky+2rrSrz/8"
Content-Disposition: inline
In-Reply-To: <20230705190324.355282-3-andreas@kemnade.info>
Precedence: bulk


--yoex5Ky+2rrSrz/8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 05, 2023 at 09:03:23PM +0200, Andreas Kemnade wrote:

> +	/* probably no mclk if not master, so rely on bitclk */
> +	if (!aic3x->master)
> +		clk_id = 2;
> +

This is fairly clearly a massive hack, we're just silently ignoring the
clock we were asked to configure and choosing another one which is
likely at a different rate to that we were expecting and sadly the
driver didn't provide an automatic mode due to how old it is.  We also
appear to try to use the configured clock rate during PLL setup which
still happens in hw_params() even with this change which is a bit of a
concern here.  Are you sure hw_params ends up doing the right thing, and
that there are no other systems that get broken by this (perhaps ones
sending a lower BCLK for example)?

It would be nicer to set the clock via the DT bindings, ideally with the
clock bindings...

--yoex5Ky+2rrSrz/8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSlwtUACgkQJNaLcl1U
h9Bt5ggAggsV+iF6iC39kukkwtxxKCtM675w6JEhW+9ET7xYGX4FrhRZTvq/mQ64
MhVd1VHY0bsPA/+vS7GtU470TRnBKYhORwVBIFFQHABfoM99rsT027jDG3gxH1gQ
Br26OAWMLgKALJ84g7HkXegZLmdtyPjcmceHoiVH8eJPuXkZJKvJ3aJIXoAtUVFF
Wfj8y/b2NoisYIRIkE8frezt4Rxtje7GJt0N2IwOcg0rcLZoNq3H7x8sgI6n+uL0
7v3ynYxxwPjFEuJ/n8w41GTidvaCZhurxk++g1DywgOcSiKcrr+ciKLYGDQfcZ/X
DMFBjIkkpCxggopwmDRMcpec92yj2g==
=sQ1/
-----END PGP SIGNATURE-----

--yoex5Ky+2rrSrz/8--