Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752581AbXJWLot (ORCPT ); Tue, 23 Oct 2007 07:44:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751758AbXJWLom (ORCPT ); Tue, 23 Oct 2007 07:44:42 -0400 Received: from brick.kernel.dk ([87.55.233.238]:10478 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750AbXJWLom (ORCPT ); Tue, 23 Oct 2007 07:44:42 -0400 Date: Tue, 23 Oct 2007 13:43:14 +0200 From: Jens Axboe To: FUJITA Tomonori Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, tomof@acm.org Subject: Re: IDE crash... Message-ID: <20071023114314.GL5059@kernel.dk> References: <20071023195255S.fujita.tomonori@lab.ntt.co.jp> <20071023105710.GJ5059@kernel.dk> <20071023105810.GK5059@kernel.dk> <20071023201048R.fujita.tomonori@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071023201048R.fujita.tomonori@lab.ntt.co.jp> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2612 Lines: 66 On Tue, Oct 23 2007, FUJITA Tomonori wrote: > On Tue, 23 Oct 2007 12:58:11 +0200 > Jens Axboe wrote: > > > On Tue, Oct 23 2007, Jens Axboe wrote: > > > On Tue, Oct 23 2007, FUJITA Tomonori wrote: > > > > On Tue, 23 Oct 2007 00:43:21 -0700 (PDT) > > > > David Miller wrote: > > > > > > > > > From: Jens Axboe > > > > > Date: Tue, 23 Oct 2007 09:23:59 +0200 > > > > > > > > > > > On Tue, Oct 23 2007, David Miller wrote: > > > > > > > From: Jens Axboe > > > > > > > Date: Tue, 23 Oct 2007 09:09:33 +0200 > > > > > > > > > > > > > > > Eh this wont work, it's the wrong entry... Here's a temporary > > > > > > > > work-around. > > > > > > > > > > > > > > > > diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c > > > > > > > > index c89f0d3..108202b 100644 > > > > > > > > --- a/drivers/ide/ide-io.c > > > > > > > > +++ b/drivers/ide/ide-io.c > > > > > > > > @@ -822,6 +822,7 @@ void ide_map_sg(ide_drive_t *drive, struct request *rq) > > > > > > > > return; > > > > > > > > > > > > > > > > if (rq->cmd_type != REQ_TYPE_ATA_TASKFILE) { > > > > > > > > + sg_init_table(hwif->sg_table, hwif->sg_max_nents); > > > > > > > > hwif->sg_nents = blk_rq_map_sg(drive->queue, rq, sg); > > > > > > > > } else { > > > > > > > > sg_init_one(sg, rq->buffer, rq->nr_sectors * SECTOR_SIZE); > > > > > > > > > > > > > > That's the exact patch I'm about to boot test :-) > > > > > > > > > > > > That should work - once you verify that, would you mind testing this one > > > > > > as well? Thanks! > > > > > > > > > > This one works here too, thanks. > > > > > > > > BTW, we avoid calling sg_init_table() for every I/O request due to Jens' > > > > trick. And Jens will remove the code to clear sg_dma_len/addr in > > > > blk_rq_map_sg(). So sparc64 iommu needs to do that for itself? > > > > > > > > http://marc.info/?l=linux-scsi&m=119261920425120&w=2 > > > > > > It does - Dave, do you agree with the patch? I think it should be added, > > > so that sparc64 isn't the odd-arch-out in this respect. I've tentatively > > > applied the patch, Davem? > > > > BTW, you sure that should not include to check whether sg_next() returns > > non-NULL? > > Yeah, the following part checks that: > > + if (dma_sg != sg) { Ah good, thanks for confirming. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/