Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b6e056d7-5b35-bcfa-4661-ebeb8cffd1c4@oracle.com>
Date:   Wed, 5 Jul 2023 13:16:25 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2 3/4] mm/memory: convert do_shared_fault() to folios
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org
References: <20230705194335.273790-1-sidhartha.kumar@oracle.com>
 <20230705194335.273790-3-sidhartha.kumar@oracle.com>
 <ZKXO0/2sC3/dvLO7@casper.infradead.org>
From:   Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <ZKXO0/2sC3/dvLO7@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnBtYUdMWkVlNE9NQ1NYR3duL2lCYUhGVW05VHQrdDNxNjY1cmhKNUNjdGJt?=
 =?utf-8?B?VlQxM2ZQZGk4Z3NWeDZKVDVNTCtMdDRDT05yUXRJdW83WVd4ampSc2NBWHFi?=
 =?utf-8?B?RWRoTDRvYkJXVWc0MERsa1Iwcy83UTFuWlQzL0JLaEtFSXZxMzRvTDZ1S1Ry?=
 =?utf-8?B?ejlxbDFCa29veU11VVJJNVlGbGtVTFB1aWVrQlpVRFY1Q3o4SjNKeWc0ZEdR?=
 =?utf-8?B?YXVVa1d4Zzc1VzBsQnlHQWZMTnVYY2NjQUhPWWpkVFRoczA3UmxUTTVGTUYw?=
 =?utf-8?B?SlZCRXE0OVdRTmFGek5pL3Z1djJNUDJVdUJNZDJUWWxKVG1HaytPZHJRQjNl?=
 =?utf-8?B?QnV5cVFwWitqWTB4emx2djlZUTJXNXZqZzJhU3JzcGlZYy9iblJZVWxEd21U?=
 =?utf-8?B?L0dEVFlIaXlwaWR3WTVnNWxOZzluNDlWM3FGWnBpb1dwQVVkWkdEbk1aYXp5?=
 =?utf-8?B?cHFTZlJoL0hFb2c4L0VKVU9VVW9SNWtUaEdUYjhaL1Q0VXk1OCtsd05ucXow?=
 =?utf-8?B?d2JJb3V6eVhQUFlsWTJKeC81allTWnd4QkUzY2pzQ0p0RVlTdEFiTFpCUjRT?=
 =?utf-8?B?aWthTkFNUUFneVJsUnE0c1dGQ1pzRzlPUHRKWDNONkgvY3lpZ2w0cW9OQWVr?=
 =?utf-8?B?VmNKZDJqOXhQNHhNeURaOERDUCtOM3ZoZm9hanpoRVJmUzdpR2hZVWhjVjd3?=
 =?utf-8?B?aVBSdjVQNStsOE5lOFhOSVRaaXBLR3piVk9WbjdtWEdxVVhtVnNXdHRKLzdr?=
 =?utf-8?B?WnRRMDQ3TlZrQTZEU1BGcWd2bWxzWHVpc2FvSUp6L05qcHZWREUrN1N4Qloy?=
 =?utf-8?B?WnhId0dPM08xU0xGdXEvNnc4ZzRxQ3FTUWY1ZjdSekMyWnI1ZVptWXJkeTlt?=
 =?utf-8?B?WnFPblJpbFVza1hKRTI2UVhNNS9CMXovZUt5SE94Mk1HNllYbW51aU05cWJE?=
 =?utf-8?B?dTNFNHNYd05yVTBoL3Zza0tzU2xoVXpIRXBKeExESHdZZk9YMWk0OHJDdm9Q?=
 =?utf-8?B?RGNKQzlkNnZ4cDNSWS83NEV1ZFo3NG5rdVRtVUlzcVNKLzJsdXBzQnJIeVVY?=
 =?utf-8?B?eUVOR20zZmphNUdkSmR4SnowTTRWUW9aL3VOTWhOZUw2V2VpQWJiajU1Vi85?=
 =?utf-8?B?Sm42ZTVqY2ZVMnlSZnJvbkNBdGc3K1U0QWc0OG04T1Q3czlKNVpuTTAxYUhG?=
 =?utf-8?B?VVNZZEV2S1BZQ2Zvdk15RWpwaENubVQycjNRT0xNTDJNNnB3SGlka1M2Zld3?=
 =?utf-8?B?L210akI2RFpnMUxHSnp2c2Z3R3FWdGRzNmthV0x4RkdQMUVmYlJTZ01wYUM3?=
 =?utf-8?B?dXA3aFBQRnhYcXJ6TXJsU28vMTdXQVlTVHhCOVhudWxGZ3pjZ1JOMG9VbTEv?=
 =?utf-8?B?YkNOeHhaVGs4YisvOVg4ZmoxbXhEeVh1QS96RkZzam5KWXFzbVd2aWEzbTJ6?=
 =?utf-8?B?N0RXTWdnK2dKWjZzVyt6ZmdkakNPVlowSGg2QmZlNmg2MENDVUN2Zjl2c2wz?=
 =?utf-8?B?NWIyS0tweWJicmZRakJpWkk3U1M4TkxSeEVZd2xIRmxSQkNLUGdlMEJkOWFC?=
 =?utf-8?B?STlwaTNsZ3dLbUs0cHlGMnQ0YlkrK1BvK2FlSHdoQktwZXpRY0gzTmVZQ1Yr?=
 =?utf-8?B?dUtuNGMyV1YwWVozUVVpUXRqWDFod0poTmxEaXdVaVd2U0dHVWpUeHBKTlMr?=
 =?utf-8?B?eWRUblBHR1ZTWGEwZHVYSTErK3ZXUWgxNzlXMHF2OGdPbFB3M2k3ZVlGNUM5?=
 =?utf-8?B?ZzBtYkVSV0xJTTR2VTd2bTVIK3BZMVN4MWViQzliUkhBeGg2dVhkQ0JyRFpr?=
 =?utf-8?B?L1prUXlFeWhKOGZxaDRaMHQ5Y3B0VmsyYU9YdXJ4UXEyMWxjajVvdXVWLzJ6?=
 =?utf-8?B?TktsRWR3WFliUFF6b0NaaDkxWldndEtWa0RhVnhpcFJpUzJQbDBZbFpMb0ZU?=
 =?utf-8?B?Q0JEa0pOV2dDbFVWZDlWV3d5UFV5bXZIWGtlNjhpR0s0Nkdrem83OXFDTGV0?=
 =?utf-8?B?eTdKNkRLZVhsYVRJMEpXUGVNMXZTZDBYRi9mVTExZDdvZXQwellwRWdYUEpo?=
 =?utf-8?B?aEtkWm1TNzArWlFudVhMYmV0M0x3eWdwdUltTkVPUm5pbXRSV3RHckJBMXVk?=
 =?utf-8?B?b0o5QSs2Vzg4cW9LbE9QaWFhVGg4NmVuQjFONDN1TldWa25qaWVZSDJjYnpz?=
 =?utf-8?Q?zjr5JXq1z9+RMi36pyQzzwc=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: tZXY72+9VVI2YpkTOdT+xRfV9Tm7kvwG/RfmJzPG9Rz/dtUEo71QOLhwwpVg83DRjNf6Rc6uaJTcafLWfANuI6bTv/0GFIgLMnrXXLcZ3u7575QR2ULxz7MTNzwTaSVfXWFSkCk4c0JdGSwBgwfip9EO9xmK2ehHVzTMoG5hPa8CrahuoMCSFdvJTmQbjEKH1coiIe2guZnC5jPEDF1LjGJcXg+KihHdAIyGnHIQ+Dv48DSTMtsoznh0AnKL7G2HMPzjEJfiVA5QaR7gpLjg3KAO/EQpuagqER57pfNZru0kCwG3aQGmgKh7YfjOgOYHhZqBGnenizjWEGaSVAwKV6MPcCg74pQPbdTqqVyjhrq4EHp0s0CSUHsl1UeWbZfNU0UpNRaMxt55NynekYXrelI8w24etQRcWf1q+MptxbzXF0ThWnAC99S1swu9RWoLjbTuNEoaEHUYJnHra7bpQdDGexr+/kBzbPBv15dbBSRWm75RQ/4DfpSB+0lDPBcry7CnBPiD7AgK+GbzQhG/JM3eeyXvFxR6YsuQrltboGGb9DlmBVeyFgL0yREHLZ4DoIls3sE7TFcmP2YLIqSFDom70iHWkaXrov9kGchyTLEnkwplwPtcdHfCTemva+iPmvW8wFGLcZzlDVCJFua5KC8K9GN8fdTZZqmJI2GkD9bAGE3zxBGxW7+yppJDRZxlhdwimAFAAFOaArj+kZD1t4AmD+3Gya9WRkDUzqrwwNB7CGaM3UOIjTVe4NqETHhgn93Kh5e6RrFHuE1MDTsoNpyDJ4KrwjQCzM7FmUUcb05YxBkoA8rdIba+jurF4DCqJdhT1Wv7c/uTnPEWkhD3yiNPrDiX2LDcO/in4rm3i8vEcD4BQJ3qI08uB5DP8r28
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1dd0aa4-e38e-4675-b034-08db7d94b738
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 20:16:28.7366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HgZQoZ2RN+CoY/gwPUTIZrkeNS3wbJ8tDgG/deva8RybBWyqag3UKRF5mom35ZNIqSe7NLw09NU1TirwKb/a5GntG/ekjQ2R3EGXn6Jiosc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7716
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-05_11,2023-07-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 mlxlogscore=980 adultscore=0 spamscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2307050185
X-Proofpoint-ORIG-GUID: 2JzXUCU-CTiUa5MLlTUU8nTSFx_aKu55
X-Proofpoint-GUID: 2JzXUCU-CTiUa5MLlTUU8nTSFx_aKu55
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/5/23 1:13 PM, Matthew Wilcox wrote:
> On Wed, Jul 05, 2023 at 12:43:34PM -0700, Sidhartha Kumar wrote:
>>   	/*
>>   	 * Check if the backing address space wants to know that the page is
>>   	 * about to become writable
>>   	 */
>>   	if (vma->vm_ops->page_mkwrite) {
>> -		unlock_page(vmf->page);
>> +		folio_unlock(folio);
>>   		tmp = do_page_mkwrite(vmf);
>>   		if (unlikely(!tmp ||
>>   				(tmp & (VM_FAULT_ERROR | VM_FAULT_NOPAGE)))) {
>> -			put_page(vmf->page);
>> +			folio_put(folio);
> 
> This is _probably_ OK.  However, do_page_mkwrite() calls
> vm_ops->page_mkwrite(), and I think it's theoretically possible for the
> driver to replace vmf->page with a different one.  The chance of them
> actually doing that is pretty low (particularly if they return error or
> nopage!), but I'm going to flag it just in case it comes up.
> 
> Also, should we pass a folio to do_page_mkwrite() instead of having it
> extract the folio from vmf->page?

I can take a look at doing this in a follow-up patch.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Did you mean for this to be reviewed-by?

Thanks,
Sidhartha Kumar