Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp29664301rwd; Wed, 5 Jul 2023 15:42:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlGy13/u5dSKydgGPDml32lN+v9Paka7CmFmFu9L6lzsb1Tf6MjZTjVaVgoE9hUtnSnCqxTC X-Received: by 2002:a05:6a20:3d01:b0:125:9d2e:ae1a with SMTP id y1-20020a056a203d0100b001259d2eae1amr4944875pzi.9.1688596951981; Wed, 05 Jul 2023 15:42:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688596951; cv=none; d=google.com; s=arc-20160816; b=KbEgMxqprrMS74x72bThgLLfd/goGUxnoIP647o2GwslgVX00jbvDuMLgGL5Osr+74 haRQjT3k7I8FlSOhP9TrTB+BIT2XL6pC7yMbuQfzlZVWlWAHIvuzmUldFl7fbQRGpT3M BevKjJxaXoghP3aiwpzWwg7OnWRzesmTwcbaZUaOM3KooziWCbkJDsEgxCITa5b7/mAV QRQzFRql2RDSv6Pp9aW9RQmrwkZolRHLOHIt/yTIt6j36BECj0xcw0fVdCKFtvFEFs9X Leu2e6PuHe2QcfQsraN8eAprnHxyBe29dgbbiUnM4pVz/jKVrTg3ebi8ktThEk3vUw2Z 5v4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qZ16jItopm6o7sYr9V0tR8SeeWXbsSfDFJEvTZCoj10=; fh=NTxmCFhJjzl3bwIZxecZxPl68CK4DxWj0756hwLfGOc=; b=nLf1UB6dA5yfwZIjYzoOF60MtQJCyFJAFcq0AmhZHncxlsyKAAnlIp2zzm+JPgUTa2 dAHveCeCOxt9Ph16LkrL5nRI11fc5bCtvyJ6mNdFi32YmsROQ85FLEOS8CnmgXYmSyp+ m2zTxnHd743hm5jgELkH/JmbglFZ50FMOTqKQCmyfz3FwGdiA/GBfwEUGiTmM9SD5jXD 5ai10yT+hD0MizSB6HTQztwTXtoFGN4zNXrWgXfO3kRc4zK7oGM4yo/S0NWHpOpQvXL+ vJZmxcLt3rATN8JU9Ivd2Ays9K8JkZTXLYQON0xWoXqyrbyxYhRBTD2ROROgmC/KJ8Nm rHWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=T9j3sbqI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f16-20020a63e310000000b0055acff2a6b3si142105pgh.265.2023.07.05.15.42.19; Wed, 05 Jul 2023 15:42:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=T9j3sbqI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231490AbjGEWIK (ORCPT + 99 others); Wed, 5 Jul 2023 18:08:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230327AbjGEWIJ (ORCPT ); Wed, 5 Jul 2023 18:08:09 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 699AA1706 for ; Wed, 5 Jul 2023 15:08:08 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-55ba5bb0bf3so14689a12.1 for ; Wed, 05 Jul 2023 15:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1688594887; x=1691186887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qZ16jItopm6o7sYr9V0tR8SeeWXbsSfDFJEvTZCoj10=; b=T9j3sbqIKeKDTyQKADleubUbF4ZRljtjzGsgJfU5TTaDgrpCKVnhjyfgFQZ35s/5eF JiOSI+TEbSPvfBGtI4RwtQ/rs0FI05uK/dzT7Z1c1AYQ4dgFSRsA0QIywmPryAoPf/70 tRpuu5IgxYjvYeFBmZxlGiFFJ8a/fq5OM/xHY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688594887; x=1691186887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qZ16jItopm6o7sYr9V0tR8SeeWXbsSfDFJEvTZCoj10=; b=MwrGyzcEkT7DrtLZxAHhyrKtYfWerCC2Bh681w2uqbPPOPmWSdx3bgvIoOlsURiCzJ qIL8dUKDWOGtKB/iok9BD/Gvj9gAoMB19DVpiM0Q/+NtyuoRhzFcb0jKjCQC6hS+gPUy 8YE9Q4bGsjDt1tkAQ91qmqBe+Y2ceqYSjkSBO/719lwJ0SeonfjjUXOkGOMfcTPxF6rL /RViJnr5sFR1htDyMY3dvj9F0qnefLzAaXEOLopfcgSHJevmlSLNDKdBdNb5k44CnlH7 yjFX/Flv1TX0HkgRniTpgpsvNIrqN5EN9je+Z0I9w0ik45a6YFBewIRW3s1bLiYWYFtS 8Gog== X-Gm-Message-State: ABy/qLZxhH5OLxOy+ms2aN5lA/Bv7GokQuEtlBJWLulEeLV/2Y4A+AQO q0RciUEUN2f0UHE/Q0z/1Yojnw== X-Received: by 2002:a05:6a20:918e:b0:106:9266:4448 with SMTP id v14-20020a056a20918e00b0010692664448mr557248pzd.16.1688594887520; Wed, 05 Jul 2023 15:08:07 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id j13-20020a62b60d000000b00682ad3613eesm26503pff.51.2023.07.05.15.08.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 15:08:06 -0700 (PDT) From: Kees Cook To: Jann Horn Cc: Kees Cook , Nathan Chancellor , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ubsan: Clarify Kconfig text for CONFIG_UBSAN_TRAP Date: Wed, 5 Jul 2023 15:07:34 -0700 Message-Id: <168859485210.800831.2317943820956176004.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230705215128.486054-1-jannh@google.com> References: <20230705215128.486054-1-jannh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 05 Jul 2023 23:51:27 +0200, Jann Horn wrote: > Make it clearer in the one-line description and the verbose description > text that CONFIG_UBSAN_TRAP as currently implemented involves a tradeoff of > much less helpful oops messages in exchange for a smaller kernel image. > (With the additional effect of turning UBSAN warnings into crashes, which > may or may not be desired.) > > > [...] Applied with some tweaks to wording, thanks! [1/1] ubsan: Clarify Kconfig text for CONFIG_UBSAN_TRAP https://git.kernel.org/kees/c/a2dbac607873 -- Kees Cook