Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp29843962rwd; Wed, 5 Jul 2023 19:09:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlHbQIiNC6kcrTThSWdoV0AQO6doljELavpviv2ntmf58AJm6e3iiRetMlSfOvwog9UiUJIP X-Received: by 2002:a05:6a00:2347:b0:653:de9a:d933 with SMTP id j7-20020a056a00234700b00653de9ad933mr444668pfj.17.1688609346537; Wed, 05 Jul 2023 19:09:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688609346; cv=none; d=google.com; s=arc-20160816; b=wi/1djF8tJXD4fQ/iWIOktQVOWgt0vwtQ9qIgw0QGfBnCDUVC1Mb5elDhBKVpJf8dB w970JMo2QPNV1WaU9lRbNiN+Fh6KSyrN+oSHgMgD0vbExRFLy5SscNe6VZEWsT5KR2Fe 8d+CaxqMv74ffIBkwJz11Vyba2+j8wTEcadKldaDcoyXKViPmEk+VpWb7qd93pAS4oDM DJ2Id/zzj01fsdAXUfmRMlWTm1bVdjXWyRX+LejLCZUu25oB2Ez/Dham7IlSX2PomXgJ 25iDk8wQVoTzm1s8GcbfmmMP/OLxov/8dnV2UqESSVN53V3cf5lr4W0Ha+w3M36CgPx2 PEzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from; bh=F6qxUOCxHt/GN2sKdss0q47V/ZDNtltvTsaT9tzWcdE=; fh=0g/l6on9jWY32XIQitqViF+z0A6zHcpNuga9c4A7haM=; b=CFCPUvb6sQjPu1lBDH0a8+FnAMFmhueIWnHPz7Rtfk6runF0rHVxqj9sU6UT3oMpXV 5Ay8LE5LkbfPl6kYXk/pWc2hmp3rFbFX0zUhDEGDjk7B/1n9S1TIRDOsfhqD/J43hVWt enULBFtMIBezkxkWWrttm+jvbZ3rGzkAnZLCU7vS1Lt8I7PhynzRpgxcdVKKI6t7d8ql zghTdAUbFYzHBbbH9ZVKjGJwyuq9jqjOEL6op9+A4OVRO1We2uamGfh10g+HZwvApAo6 UlgcxShaASrJVEvTk9P0v5GSsQM1W7DpS+9TiL76pWMRRCloHZtwx5VPSDujI9/NMB/X WT5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ch11-20020a056a00288b00b00653b5ab16c3si407732pfb.265.2023.07.05.19.08.53; Wed, 05 Jul 2023 19:09:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233024AbjGFCAi (ORCPT + 99 others); Wed, 5 Jul 2023 22:00:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232692AbjGFCAh (ORCPT ); Wed, 5 Jul 2023 22:00:37 -0400 X-Greylist: delayed 378 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 05 Jul 2023 19:00:31 PDT Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B99981BDF; Wed, 5 Jul 2023 19:00:31 -0700 (PDT) Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id D02902055F9C; Thu, 6 Jul 2023 10:54:11 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 3661sAmO013519 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 6 Jul 2023 10:54:11 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 3661sAor045796 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 6 Jul 2023 10:54:10 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.17.2/8.17.2/Submit) id 3661s99N045795; Thu, 6 Jul 2023 10:54:09 +0900 From: OGAWA Hirofumi To: Jeff Layton Cc: Christian Brauner , Al Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 44/92] fat: convert to ctime accessor functions In-Reply-To: <20230705190309.579783-42-jlayton@kernel.org> (Jeff Layton's message of "Wed, 5 Jul 2023 15:01:09 -0400") References: <20230705185755.579053-1-jlayton@kernel.org> <20230705190309.579783-1-jlayton@kernel.org> <20230705190309.579783-42-jlayton@kernel.org> Date: Thu, 06 Jul 2023 10:54:09 +0900 Message-ID: <87zg49yfcu.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeff Layton writes: > @@ -1407,8 +1407,9 @@ static int fat_read_root(struct inode *inode) > MSDOS_I(inode)->mmu_private = inode->i_size; > > fat_save_attrs(inode, ATTR_DIR); > - inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode->i_ctime.tv_sec = 0; > - inode->i_mtime.tv_nsec = inode->i_atime.tv_nsec = inode->i_ctime.tv_nsec = 0; > + inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode_set_ctime(inode, > + 0, 0).tv_sec; > + inode->i_mtime.tv_nsec = inode->i_atime.tv_nsec = 0; Maybe, this should simply be inode->i_mtime = inode->i_atime = inode_set_ctime(inode, 0, 0); ? Thanks. -- OGAWA Hirofumi