Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp29858798rwd; Wed, 5 Jul 2023 19:29:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlHqvjl53MrxJXnsO4M8hBFcwp7LO5mo5gb8pJUaTQRNGIrw9tXhrL4bw3KhA/KQjakpa1ph X-Received: by 2002:a17:902:c410:b0:1b8:ad90:7af8 with SMTP id k16-20020a170902c41000b001b8ad907af8mr6413298plk.17.1688610576395; Wed, 05 Jul 2023 19:29:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688610576; cv=none; d=google.com; s=arc-20160816; b=gWCXyxV1XLTGuMiy8SFXr78DL045ZYstQpWD0Ph2Rg93XEWwvcDx8vNHjRF2HEdZjh aLJTtIKeiN13xQaF1R0N2idng7JjutHZFVhrI+qDjT7jETtFILy5kiOhv5dOytFv13gr DczzSkEM/X++MSiyLrJJX6y7BoB7eBkOcn50hRpvCsxek5/4ZqFgOH3o27VsJMLXZXVa QE3JenIwdrtgSVq36a136C6veS8cq3qAaji3fCqy6j3dypgP0VsKXU0/HnLL8Sz6SMya 6V40KAkD0sQ5wKdND8UL8ELTquSRaEUlWp+rzUObqK+2ZEAD5zRZ44tE5+z2HoidKz8G QpYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=CFfysYVYuZ8C/tQ+RWieBG1OO6+PStshoa4u8CpRiCk=; fh=iP59cxpRkAgmBQBuEqAqtbcGdA8cmubEYt6TranedM0=; b=F8xVtqvi2x65CVlFe4MyImlcv2C3UxXhIhhA0bW6NUtqAKGNu9vIkDLFSQLbH4jk6o wG0SfrosRFZ2HGxurTGIz/NNoJK584VRKOTump7Q6WnXUo0doPuhZ58zJ0rqaHLASet3 koK9QR4UQs8zOYs8dT4CoyHPHRTAR5zMhMEaOsd9i0JeiOKs98yNsYc8ygsnXPy33d0s 0BvgIK+OKMOJhvyV1NkSGKllpX1RVzNrObP5WcT9RTH09WF7bLb9Nhp6s8cOffHFQ6Tv bAezklWA8JxkatZONByHClydmmjxgWiflTY8TmxUMEdMMva8XojZDO2fVs1t/R+AIDKE N15g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z16-20020a170902d55000b001a97e24eb34si341471plf.201.2023.07.05.19.29.24; Wed, 05 Jul 2023 19:29:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233160AbjGFCMR (ORCPT + 99 others); Wed, 5 Jul 2023 22:12:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233148AbjGFCMQ (ORCPT ); Wed, 5 Jul 2023 22:12:16 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C53171BE1; Wed, 5 Jul 2023 19:12:00 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QxKh32c42z67HtH; Thu, 6 Jul 2023 10:08:35 +0800 (CST) Received: from localhost (10.34.206.101) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 6 Jul 2023 03:11:56 +0100 Date: Thu, 6 Jul 2023 10:11:52 +0800 From: Jonathan Cameron To: Paul Cercueil CC: Wolfram Sang , , , Ray Jui , Scott Branden , Broadcom internal kernel review list , Subject: Re: [PATCH 03/23] i2c: iproc: Remove #ifdef guards for PM related functions Message-ID: <20230706101152.0000029b@Huawei.com> In-Reply-To: <20230705204314.89800-4-paul@crapouillou.net> References: <20230705204314.89800-1-paul@crapouillou.net> <20230705204314.89800-4-paul@crapouillou.net> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.34.206.101] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Jul 2023 22:42:54 +0200 Paul Cercueil wrote: > Use the new PM macros for the suspend and resume functions to be > automatically dropped by the compiler when CONFIG_PM or > CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards. > > This has the advantage of always compiling these functions in, > independently of any Kconfig option. Thanks to that, bugs and other > regressions are subsequently easier to catch. > > Signed-off-by: Paul Cercueil Reviewed-by: Jonathan Cameron