Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp29904632rwd; Wed, 5 Jul 2023 20:28:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlFrNjfyqkoNeGkeE8qrT2TrM9tczahJQrF7p+jbaqkhH96fvEs12J3XdECvulffZX8eKeYT X-Received: by 2002:a54:4882:0:b0:3a0:492b:f07b with SMTP id r2-20020a544882000000b003a0492bf07bmr423160oic.26.1688614095522; Wed, 05 Jul 2023 20:28:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688614095; cv=none; d=google.com; s=arc-20160816; b=zAewwDgHnd0/H/zUhzx8suYvrFAIFPZ7cLajreMsTlm8oJS557+jH8bTKaL7OyzUdL J1H6WdY5H4M4BimUxm8DIqUuz21yM8wWz60NypfWGfr4OAZoiLG+I2Rys+8yTpDtZY8l 6gHJVoCSIi5gmwN3pfoH1UjZNezKcMVZLfuvyN46+O+R3D2HSexA6y7wruJt3nBg5tQ4 3dQ7Z1X1Q8ddg082+2s1UC3tdRaoXR70xA5rPPISca2yv4dFoEBPeUNNSJfef9lmqTF9 cOKzfqb+GW+4z3nPXklz7Dk6LC/U/1h6Nw5jgdp9f2bRBz4MWxe56rMuGnErwDU6I37M nnTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:authenticated-by; bh=j9bWV7X4V0nZ6agpRpy2dB+pSA+W4pVvWdqgcJakicI=; fh=jheBtQhSdASak3hgaAmHjq7RoqYZxgHpSsnl0A+Ld0I=; b=QW5ObVgMnDUQZJpQuCDHkaUz53jO8hoyonx6yswbicjgQMoqKIWmfbpuhpbeh0gaHC VsIfSHm7iBh2XqlxOE+DOGIW8XmqrVYQl3uXmMkiHbwRUsWnpjwowet4Rod0teJyIc43 1ZOI/+zZ2fH+SHWYzepeuUWrQovhiDZuXiaghBIFrVMZrU5B+kTXu4/FSG4JjR1yeRT2 sstvHSYrz7gFqHv73wGyRbBUT0WGICfF9mysUzr2OizNyfKrBWCs7IKdqPVnhpZObwSZ VwQJ8UwHJUu7pZLrVZZbG1RaL/Q6G6mjWUewOjeY0qjNRG8fbUEjMX4i+VyagHmR1Wf4 NUQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fi12-20020a056a00398c00b00660b5630927si585831pfb.133.2023.07.05.20.28.02; Wed, 05 Jul 2023 20:28:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233041AbjGFCuZ convert rfc822-to-8bit (ORCPT + 99 others); Wed, 5 Jul 2023 22:50:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233363AbjGFCuX (ORCPT ); Wed, 5 Jul 2023 22:50:23 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7F43B1BC7; Wed, 5 Jul 2023 19:50:20 -0700 (PDT) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 3662o7MI1016388, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 3662o7MI1016388 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=FAIL); Thu, 6 Jul 2023 10:50:07 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Thu, 6 Jul 2023 10:50:10 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Thu, 6 Jul 2023 10:50:10 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::e138:e7f1:4709:ff4d]) by RTEXMBS04.realtek.com.tw ([fe80::e138:e7f1:4709:ff4d%5]) with mapi id 15.01.2375.007; Thu, 6 Jul 2023 10:50:10 +0800 From: Ping-Ke Shih To: Zhang Shurong CC: "kvalo@kernel.org" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v4] wifi: rtw89: debug: fix error code in rtw89_debug_priv_send_h2c_set() Thread-Topic: [PATCH v4] wifi: rtw89: debug: fix error code in rtw89_debug_priv_send_h2c_set() Thread-Index: AQHZr7PivS7TyITqwU+gLYMnIIw9Ta+sCaeg Date: Thu, 6 Jul 2023 02:50:10 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-TW Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.69.188] x-kse-serverinfo: RTEXMBS04.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Zhang Shurong > Sent: Thursday, July 6, 2023 10:45 AM > To: Ping-Ke Shih > Cc: kvalo@kernel.org; linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; Zhang Shurong > > Subject: [PATCH v4] wifi: rtw89: debug: fix error code in rtw89_debug_priv_send_h2c_set() > > If there is a failure during rtw89_fw_h2c_raw() rtw89_debug_priv_send_h2c > should return negative error code instead of a positive value count. > Fix this bug by returning correct error code. > > Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver") > Signed-off-by: Zhang Shurong Acked-by: Ping-Ke Shih [...]