Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     John Stultz <jstultz@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@kernel.org>, Shuah Khan <shuah@kernel.org>,
        linux-kernel@vger.kernel.org (open list:TIMEKEEPING, CLOCKSOURCE CORE,
        NTP, ALARMTIMER),
        linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] tools: timers: fix freq average calculation
Date:   Thu,  6 Jul 2023 11:22:57 +0800
Message-Id: <20230706032257.1662-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+c33Wy5dlXaWooo77HIjZXyqSkHzGTqjTtl/esI0wxBSVtCVhcX9eK67BWi1?=
 =?us-ascii?Q?d15j7Sr6yWHCzYzLoPpu6y9E40xOYA/JqMm3XMInMTG/RqKi75PY9zxXAJjC?=
 =?us-ascii?Q?7Txb3s7C8hGJQJFpxvUgOkMUZgYhb2HofJEk6UTIbwXZrMDpteJqUbQ/1ied?=
 =?us-ascii?Q?XdzsKNLsVtNlUjA6OmKNd3VUWRMDN+MNYeDhOYVOxvOtHtNtKIeS1DndHGop?=
 =?us-ascii?Q?LfPS0DZVmQduwP2rXMxUIGHeFNK30VmAgi8jvHbm5QfmYFV4d/AL7pXGbFiA?=
 =?us-ascii?Q?eGlXTvSUucRSJ+GS+v6o1Wx5DDOJv+yTPVVE3RtUFrgMTLJLJYPJTw7bYttU?=
 =?us-ascii?Q?svf0UerEexIlrpLl7Bh14EfT33cKCGy/V9N3y4VEhT2eXP0DDw0eMbZS8Il2?=
 =?us-ascii?Q?ZapjBif6h1e6yTZs08ymqSHE9f//U/frJq0yRJv6KWqhb13cLFTkzSOhd3Dl?=
 =?us-ascii?Q?0WlUa+A9IiBK1mBhddPRBlu1k8d444Z8ta5N4T5iXmMWYa7+IB/euu8H0uOV?=
 =?us-ascii?Q?HrZ4QaPkdTW9N3GHHucqLN6qAJ8QMV46JU7KmPqgKwoD4vXttgatQFeM+FIQ?=
 =?us-ascii?Q?mSieC1L8jax2cGryq9/MeD9qcvsXLw64Sjl+uvVz4ZqD4kk80pD7DKtTWAHo?=
 =?us-ascii?Q?wr69z4Sdu7qKe29/VCuBpH1ihWZ/c8KvukPGHn/MTrwYfaLqjL04F3cOsS1p?=
 =?us-ascii?Q?lQLdng25Wcwq4voFBkR5NvnC2Ev+BA/DyeRyeqI/0oE5hK7adTQGhXgkpha6?=
 =?us-ascii?Q?7kAlDm9TwvM0z5Zy5a1Fi0qEwMEStRCoBYMpwhrIy0AN2HxWnqCzkVUiqXgP?=
 =?us-ascii?Q?RCJcMxG4v/MJtpJ/gGPje/DnZHfnYCDzXxuYuK0v5TwO9vpSzHTC2k9WBW19?=
 =?us-ascii?Q?HPcuqDy+cuwwyJ2LyIXk9aCY7t+pAISOxLwEuRKe9CxeyzLIFSpQHxGdhHJD?=
 =?us-ascii?Q?QwhJMRYR1oXPy2BbCHB2KleVPbHrsB5L/fT2DMkjfpqXJLS9RTfJz0ZJTlk+?=
 =?us-ascii?Q?fzykEb/YW37Jd0HwmXjUUs59JL9J+IHQGntV3W38k3u6FFcPBrU2agn9GVh7?=
 =?us-ascii?Q?95PPiKy71pE3TvJumiL7LoiKLCT1OhR6YwFKeXWXHMJ5/BrAQ1gCMH+zD9Qb?=
 =?us-ascii?Q?0TyOdkT+kNEppcKdGS0fDgVQG0QEzxjT0EdOhMZ/ew+uun3vuFwSiNCmL1Ve?=
 =?us-ascii?Q?NXA7gZ+f/7ldqP9yNzou3afiCFoP8Uviadi5GM+Q7mO8MxP5h/vg2Jvuv0X9?=
 =?us-ascii?Q?iB4FxIcaF1jOJmELTycUDdYHhXVWVT4Dwrx+2pU5B+5kJ7mYyMJH6tVcNMzk?=
 =?us-ascii?Q?WUkzRkSXasdFej9yLb0KIjir823e4asyCHY94Zmd/AIyZsTezGEKNGWjHr9w?=
 =?us-ascii?Q?0xGVMdYfJM3oMAYN2TmmsobuiEPnfS9a553WpiiNNM8y+zQB64CJ1XKlXF8N?=
 =?us-ascii?Q?LRSgYgNpSXf9H6QlD8tiaIVxUEF9e+uFG5QoB0lrULwbSHfuCqlTFQHwHca3?=
 =?us-ascii?Q?zmUyksvR63PdxBO65Zfz6TKxfTQJCgTGgoEJxeH1CbgBSutVz+Vv609SDNDT?=
 =?us-ascii?Q?mKZ8gxQ64G03EiNLc0vfJEZZVySDslHtv2aVHXu7?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0254a2b-32fa-4f8b-ab20-08db7dd05270
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2023 03:23:09.5113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1Micx05XX1kn3VBFt5Zm5+pKQ/wiG0JZfgpOrrQXW4QOgEvP2ZtEOQa4oVuzFqVO6CWgqUdGpFdB185MqFgmjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4483
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Delete a duplicate assignment from this function implementation.
The note means ppm is average of the two actual freq samples.
But ppm have a duplicate assignment.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 tools/testing/selftests/timers/raw_skew.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/testing/selftests/timers/raw_skew.c b/tools/testing/selftests/timers/raw_skew.c
index 5beceeed0..6eba203f9 100644
--- a/tools/testing/selftests/timers/raw_skew.c
+++ b/tools/testing/selftests/timers/raw_skew.c
@@ -129,8 +129,7 @@ int main(int argc, char **argv)
 	printf("%lld.%i(est)", eppm/1000, abs((int)(eppm%1000)));
 
 	/* Avg the two actual freq samples adjtimex gave us */
-	ppm = (tx1.freq + tx2.freq) * 1000 / 2;
-	ppm = (long long)tx1.freq * 1000;
+	ppm = (long long)(tx1.freq + tx2.freq) * 1000 / 2;
 	ppm = shift_right(ppm, 16);
 	printf(" %lld.%i(act)", ppm/1000, abs((int)(ppm%1000)));
 
-- 
2.39.0