Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alexander Stein <alexander.stein@ew.tq-group.com>
To:     suzuki.poulose@arm.com, coresight@lists.linaro.org,
        imx@lists.linux.dev, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Marek Vasut <marex@denx.de>, Peng Fan <peng.fan@nxp.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Adam Ford <aford173@gmail.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: remove arm, primecell-periphid at etm nodes
Date:   Thu, 06 Jul 2023 07:06:58 +0200
Message-ID: <9405224.NyiUUSuA9g@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20230705205954.4159781-1-Frank.Li@nxp.com>
References: <20230705205954.4159781-1-Frank.Li@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Hi Frank,

Am Mittwoch, 5. Juli 2023, 22:59:53 CEST schrieb Frank Li:
> The reg size of etm nodes is incorrectly set to 64k instead of 4k. This
> leads to a crash when calling amba_read_periphid().  After corrected reg
> size, amba_read_periphid() retrieve the correct periphid.
> arm,primecell-periphid were removed from the etm nodes.

So this means the reference manual is wrong here? It clearly states the siz=
e=20
is 64kiB. Reference Manual i.MX8MP Rev 1. 06/2021
On a side note: Is imx8mq affected by this as well? The DAP memory table li=
sts=20
similar sizes in the RM .

Best regards,
Alexander

> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
> cc406bb338fe..e0ca82ff6f15 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -306,8 +306,7 @@ soc: soc@0 {
>=20
>  		etm0: etm@28440000 {
>  			compatible =3D "arm,coresight-etm4x",=20
"arm,primecell";
> -			reg =3D <0x28440000 0x10000>;
> -			arm,primecell-periphid =3D <0xbb95d>;
> +			reg =3D <0x28440000 0x1000>;
>  			cpu =3D <&A53_0>;
>  			clocks =3D <&clk IMX8MP_CLK_MAIN_AXI>;
>  			clock-names =3D "apb_pclk";
> @@ -323,8 +322,7 @@ etm0_out_port: endpoint {
>=20
>  		etm1: etm@28540000 {
>  			compatible =3D "arm,coresight-etm4x",=20
"arm,primecell";
> -			reg =3D <0x28540000 0x10000>;
> -			arm,primecell-periphid =3D <0xbb95d>;
> +			reg =3D <0x28540000 0x1000>;
>  			cpu =3D <&A53_1>;
>  			clocks =3D <&clk IMX8MP_CLK_MAIN_AXI>;
>  			clock-names =3D "apb_pclk";
> @@ -340,8 +338,7 @@ etm1_out_port: endpoint {
>=20
>  		etm2: etm@28640000 {
>  			compatible =3D "arm,coresight-etm4x",=20
"arm,primecell";
> -			reg =3D <0x28640000 0x10000>;
> -			arm,primecell-periphid =3D <0xbb95d>;
> +			reg =3D <0x28640000 0x1000>;
>  			cpu =3D <&A53_2>;
>  			clocks =3D <&clk IMX8MP_CLK_MAIN_AXI>;
>  			clock-names =3D "apb_pclk";
> @@ -357,8 +354,7 @@ etm2_out_port: endpoint {
>=20
>  		etm3: etm@28740000 {
>  			compatible =3D "arm,coresight-etm4x",=20
"arm,primecell";
> -			reg =3D <0x28740000 0x10000>;
> -			arm,primecell-periphid =3D <0xbb95d>;
> +			reg =3D <0x28740000 0x1000>;
>  			cpu =3D <&A53_3>;
>  			clocks =3D <&clk IMX8MP_CLK_MAIN_AXI>;
>  			clock-names =3D "apb_pclk";


=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/