Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1688585597.git.anupnewsmail@gmail.com> <df4773a4ebb43a6c855bad5a2bbc338bc2669ca7.1688585597.git.anupnewsmail@gmail.com>
In-Reply-To: <df4773a4ebb43a6c855bad5a2bbc338bc2669ca7.1688585597.git.anupnewsmail@gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 5 Jul 2023 22:42:47 -0700
Message-ID: <CAM9d7chNwcCD6J-twSTTxm6uLoNbMT8ZYKHcDiZxXjcfEVfDfw@mail.gmail.com>
Subject: Re: [PATCH v2 2/7] scripts: python: Introduce thread sample
 processing to create thread
To:     Anup Sharma <anupnewsmail@gmail.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, Jul 5, 2023 at 12:44 PM Anup Sharma <anupnewsmail@gmail.com> wrote:
>
> The _addThreadSample function is responsible for adding a sample to a specific
> thread. It first checks if the thread exists in the thread_map dictionary.
> If not, it creates a new thread using the _createtread function and assigns
> it to the thread_map. Finally, it calls the 'addSample' method of the thread,
> passing the thread name, stack, and timestamp.
>
> Signed-off-by: Anup Sharma <anupnewsmail@gmail.com>
> ---
>  .../perf/scripts/python/firefox-gecko-converter.py  | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/tools/perf/scripts/python/firefox-gecko-converter.py b/tools/perf/scripts/python/firefox-gecko-converter.py
> index ce663840d212..95b061a97cbc 100644
> --- a/tools/perf/scripts/python/firefox-gecko-converter.py
> +++ b/tools/perf/scripts/python/firefox-gecko-converter.py
> @@ -18,7 +18,20 @@ sys.path.append(os.environ['PERF_EXEC_PATH'] + \
>  from perf_trace_context import *
>  from Core import *
>
> +thread_map = {}
> +start_time = None
> +
>  def process_event(param_dict):
> +       global start_time
> +       global thread_map
> +
> +       def _addThreadSample(pid, tid, threadName, time_stamp, stack):
> +               thread = thread_map.get(tid)
> +               if not thread:
> +                       thread = _createtread(threadName, pid, tid)

Shouldn't it be '_createThread'?

> +                       thread_map[tid] = thread
> +               thread['addSample'](threadName, stack, time_stamp)

Why is it like this?  What do you intend with the thread['addSample']
method?  Can it be simpler like a direct function call?

And more importantly, you'd better make each patch work properly.
AFAICS it won't do the job because both _createtread() and
thread['addSample'] are not implemented yet.

You can either move those definitions to this commit or have the
commit implementing them before this one.

Thanks,
Namhyung


> +
>         time_stamp = (param_dict['sample']['time'] // 1000) / 1000
>         pid = param_dict['sample']['pid']
>         tid = param_dict['sample']['tid']
> --
> 2.34.1
>