Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Lu Hongfei <luhongfei@vivo.com>, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
Subject: [PATCH] drivers: bus: arm: Fix resource leaks in for_each_available_child_of_node loop
Date:   Thu,  6 Jul 2023 15:06:35 +0800
Message-Id: <20230706070637.35972-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?G92gHlr/Sab1l+FFdfhrMIK75qG6wap/yZ5q5tt6fZ68bF5a/iY48vd3DmvT?=
 =?us-ascii?Q?p2RWJlADTTifmOlk3hPZpTocGI9Sl4IBXrYJy8IBf1wsdDbGLImReOGVlOJz?=
 =?us-ascii?Q?ph15eNXfYc8CDj+v/co+lL0JD3cXJDnYJWM01nZu4uemeIRxoIvOjQvpugTT?=
 =?us-ascii?Q?Q5TGMhGfsCDl+fnRguUcbusM/AQheRd3rkpqfYQRVkECosvKo9vl6V3Tm5Q7?=
 =?us-ascii?Q?8hzvKBbQs8014fuW5u0zNobZqxS3kvmgFQ/wZ3IUQt0perho0SXCAVB0G1/p?=
 =?us-ascii?Q?Jggx95gYs4FOtRHooSPTRfdhGNgwX0hXROOoB+jjCYWK7utHnR/Rm1m52Yp0?=
 =?us-ascii?Q?Kb3qeNdB4LRTiSP4qUquTFSJkrhyZCexGtEAajmfW2hWIAyMZ6njwwYfH/XQ?=
 =?us-ascii?Q?vcY0a7XFeigDv+oEr6FPbziKu1DgKLMKfnrZqfyZl2dWB7RcQi695AveDJOo?=
 =?us-ascii?Q?vouJLfqQFn5RnksjoOPSzRnszahm/QsgybaA7zVdtaixyuTdhiFX7IgEYpud?=
 =?us-ascii?Q?9/5t7sIedngDst5yBIC9jkyd92miW7UYde/rW7AHzNNAJo2tCVe/ZrdvLUNM?=
 =?us-ascii?Q?AVApqBgVjwmhwPmNAwSVT9CUYsbxXuraq7pvB6NmUMKgstTg0A/H72GN2ey7?=
 =?us-ascii?Q?vAve449BNttPD9zU0fT/5mviuQ1K+zekbm0RI0Qckgn5hCPm3fzM/6Q5SclY?=
 =?us-ascii?Q?WFqsEqcvFp2w2c2zoZR2TC+20TSRyDLA5eFdLVRrC14TihTJ6+EGoj4+9PcB?=
 =?us-ascii?Q?PgpOK8HlivLeTPWKdXFPWX9O/HCxjoQTgoLnib6AI7L74JAO1tbWeaew2wRV?=
 =?us-ascii?Q?ClwHJIaihwd5XvA4IMo08n49TNxXZMLsBQN065S7dkZKDhGe+lFSCLU9ubwe?=
 =?us-ascii?Q?11SjMhM/WgK1Rtkax/UWToqYSX9wQcX3qnyNHVCIDf2FhQTgqWRo/6Z0YTJh?=
 =?us-ascii?Q?GO5ngxYENto6yNv90/Ibn/CKBUvMPq8uBkJBV4mUUVEwXHOMgfFNIEacJBHy?=
 =?us-ascii?Q?s68ezi9sJnIGZXkTGyVNedR+pe3JsiZAE8zni4ufOkf+zNVVHwrF7OjGDGvg?=
 =?us-ascii?Q?849OZ1fDhAPou4X9V+VACH4YO0cD6VYYuWJtYHxPjcj1PN3sISAI0sX4Gfyk?=
 =?us-ascii?Q?gKCq+02Kj9qUOrznYBprJftCmOoc+glu2VhPRGm5e+auVg1Nq3WWh/gtuPhQ?=
 =?us-ascii?Q?f/vTaJ8uyj+Bc++hKyraSWkSRfP2j0oMd9p9jB73jptJ+d2c/o6N57dkP8zB?=
 =?us-ascii?Q?4ps/QrCfO38/66IgRVG10MxGu1GkHM5RwA9YG0lPIwj8eqxIgSxlCwa7qET5?=
 =?us-ascii?Q?qfYwgJ/SriRxgdtMGsB1XAmmSFuKNBsjkRMzLu6R6XA1Z/a3+JX/yQVojeS2?=
 =?us-ascii?Q?e3sAritYetv+bhMC7ay9ysGY3dug2iroGwwoz5BDL4xH8GdMY4GPrVFdQTDa?=
 =?us-ascii?Q?8Y4G753JwjLtll/lwetxrzxb7gd35qaP0rFN3YlkpaOVFe9thqobo9rJaNFT?=
 =?us-ascii?Q?uQE8FkcvHB7MJQDam2JW7y/wGZFk1UcasApM0HLIe2wtzeM9p8PjZL0KsN8+?=
 =?us-ascii?Q?JQUuCgxtNLZGJEY1MlSwU1zVnqdfemcXzFDOVBQy?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26342251-5deb-4519-f8bb-08db7def9074
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2023 07:06:47.9701
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y0dCw5FZ4mIxEYTsW/1SgcDwrHDmyWca/x1Q5erI0NUj08npjBvlKaS+XTOAyP5U6v7DUTwEqrVGF9y3aHczGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR06MB6314
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ensure child node references are decremented properly in
the error path.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/bus/arm-cci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index b8184a903583..1f84a5528073 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np)
 
 		i = nb_ace + nb_ace_lite;
 
-		if (i >= nb_cci_ports)
+		if (i >= nb_cci_ports) {
+			of_node_put(cp);
 			break;
+		}
 
 		if (of_property_read_string(cp, "interface-type",
 					&match_str)) {
-- 
2.39.0