Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <babbab54-f8b3-24a4-56b6-95d8a0db6307@linux.dev>
Date:   Thu, 6 Jul 2023 15:46:23 +0800
MIME-Version: 1.0
Subject: Re: [PATCH v1] infiniband: irdma: Remove a duplicate assignment in
 irdma_query_ah()
To:     Minjie Du <duminjie@vivo.com>,
        Mustafa Ismail <mustafa.ismail@intel.com>,
        Shiraz Saleem <shiraz.saleem@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>,
        "open list:INTEL ETHERNET PROTOCOL DRIVER FOR RDMA" 
        <linux-rdma@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Cc:     opensource.kernel@vivo.com
References: <20230706022704.1260-1-duminjie@vivo.com>
From:   Zhu Yanjun <yanjun.zhu@linux.dev>
In-Reply-To: <20230706022704.1260-1-duminjie@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2023/7/6 10:27, Minjie Du 写道:
> Delete a duplicate statement from this function implementation.
> 

Please add "Fixes ".

Zhu Yanjun

> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>   drivers/infiniband/hw/irdma/verbs.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
> index 9c4fe4fa9..a8326a95d 100644
> --- a/drivers/infiniband/hw/irdma/verbs.c
> +++ b/drivers/infiniband/hw/irdma/verbs.c
> @@ -4424,7 +4424,6 @@ static int irdma_query_ah(struct ib_ah *ibah, struct rdma_ah_attr *ah_attr)
>   		ah_attr->grh.traffic_class = ah->sc_ah.ah_info.tc_tos;
>   		ah_attr->grh.hop_limit = ah->sc_ah.ah_info.hop_ttl;
>   		ah_attr->grh.sgid_index = ah->sgid_index;
> -		ah_attr->grh.sgid_index = ah->sgid_index;
>   		memcpy(&ah_attr->grh.dgid, &ah->dgid,
>   		       sizeof(ah_attr->grh.dgid));
>   	}