Date: Tue, 23 Oct 2007 16:47:10 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andi Kleen <andi@firstfloor.org>, Al Viro <viro@ftp.linux.org.uk>,
       WANG Cong <xiyou.wangcong@gmail.com>, Sam Ravnborg <sam@ravnborg.org>,
       Nix <nix@esperi.org.uk>, Jeff Dike <jdike@addtoit.com>,
       Paolo Giarrusso <p.giarrusso@gmail.com>,
       user-mode-linux-devel@lists.sourceforge.net,
       linux-kernel@vger.kernel.org, Rob Landley <rob@landley.net>
Subject: Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
Message-ID: <20071023144710.GA13785@elte.hu>
References: <20071022124551.GA7438@elte.hu> <471D2ECC.6090209@goop.org> <20071022231927.GA30814@elte.hu> <471D389E.40609@goop.org> <20071023084546.GA17007@elte.hu> <p73wste7zy5.fsf@bingen.suse.de> <20071023131009.GA32298@elte.hu> <p73sl427wvu.fsf@bingen.suse.de> <20071023142006.GA9961@elte.hu> <471E05C0.4010005@goop.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <471E05C0.4010005@goop.org>
User-Agent: Mutt/1.5.14 (2007-02-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1842
Lines: 47


* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Ingo Molnar wrote:
> > * Andi Kleen <andi@firstfloor.org> wrote:
> >
> >   
> >>>> You should rename it then to "asmcall" or something.
> >>>>         
> >>> if then that should be a separate renaming patch.
> >>>       
> >> Well you're asking for the ugly hacks for out of tree code.  [...]
> >>     
> >
> > nice word-bending there. I'm asking for pre-existing annotations to 
> > survive. It hurts you _nothing_ and it was a world of pain for us to 
> > recover those lost annotations. Anyway, if Jeremy does not object to the 
> > patch
> 
> I don't have any objections to the idea of the patch, but I'm still 
> concerned about the practical aspects of it.  Maintaining these kinds 
> of annotations is hard/fragile/etc when the compiler doesn't warn when 
> you get it wrong, and only a very specific use-case will reveal the 
> problem (and do so in a fairly obscure way).

it wont be any different from the situation before - we had no such 
warnings there either. Anyway, this shouldnt really bother you as at the 
moment it's only used for -rt. The issue is to keep something we had 
before (but which was stupidly/carelessly removed). If it breaks we'll 
fix it up.

> > we'll push it in and then rename fastcall to asmcall. Much ado about 
> > nothing.
> 
> Hm, "asmcall" is confusingly close to "asmlinkage" - and they have 
> exactly the same intent (can be called from asm), but with exactly the 
> opposite effect.  How about something which actually says what we 
> mean. How about just "regparm"?

yeah, regparm is fine.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/