Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   wei.fang@nxp.com
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net,
        hawk@kernel.org, john.fastabend@gmail.com, shenwei.wang@nxp.com,
        xiaoning.wang@nxp.com, netdev@vger.kernel.org
Cc:     linux-imx@nxp.com, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org
Subject: [PATCH V2 net 4/4] net: fec: use netdev_err_once() instead of netdev_err()
Date:   Thu,  6 Jul 2023 16:10:12 +0800
Message-Id: <20230706081012.2278063-5-wei.fang@nxp.com>
In-Reply-To: <20230706081012.2278063-1-wei.fang@nxp.com>
References: <20230706081012.2278063-1-wei.fang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IcuYFogPkWaeYi2+UU0sUQ6PJ0nCoidFEIPd31XQeiG22w0grRhLaDlZM/lA?=
 =?us-ascii?Q?pXSt73siLxWaag8paO6H+j8GU5L/RsPbgsyLsq59oR8tx1aVp0oar09QHrAN?=
 =?us-ascii?Q?MjiiDTPyr03aHq1t8Laoa54E+FZBHwdpoWPOPVjtEZJggnv+2h7pfAjnXdpH?=
 =?us-ascii?Q?MNQWhHQj4meV7Owm7AFbFMOdUlnlK/JIV7CMlPw7yeL+1+ZMyySH6+JB9E3x?=
 =?us-ascii?Q?ati7WsJ/UE+aUSZ88QvLB94+ga7KKm/Ph7YEO54fu+0gTe5eypjS+yYRo9bf?=
 =?us-ascii?Q?Ql/VlkcLxJDmUj6hakw/ONiYoiIs73tALt92VD2A5Q/G6S0CB9qh2ftHguXD?=
 =?us-ascii?Q?sp4/HM7X4HA54R7Be8yHUaaW41FH5csLGG7LIFI3j5Vn3bT7AXTfWqhsjVIN?=
 =?us-ascii?Q?RTxLXWA8RsufCG8iRKW35Vg0L7oBph4zKQMJNU6b//d5ruRHQ3RS0ovtZWkl?=
 =?us-ascii?Q?/gGiSbbPpjwTVc8WYLsPIt7IzdhWZ+vXkEDTZgSRjnbEWR2Bgy4yYOmrRIZX?=
 =?us-ascii?Q?D2KnRItUTiGBaiHT4VABBIQ8mkm6RPeeCsxHatG4jeIuuY401uopCIEjWjWp?=
 =?us-ascii?Q?v6q5HKBs9rhUxe8WLmgZMCNJ6PlkwHUsjkZMa75339iNETHXfsUIs1Uz/Yug?=
 =?us-ascii?Q?s/7ohtr+wZZdv07S7s8rsnJf3iHZSZEKD/NC5l3sPZ0lIBfBrVrjjuYRF49u?=
 =?us-ascii?Q?j5xmP3pJ1uBPmVHzLXH9caRaJLmgKq8grUL4l7eox2XfAl45dueoPeA5lkJ7?=
 =?us-ascii?Q?sKeS9Jmd8GY6ILSu2xV+zudTLAmvQ9PEgSvMp252zVjQpP4YdfoeKhcwvFzu?=
 =?us-ascii?Q?Sad8zBaA/HujdD7Kf+yOUA3g9L9S6OzprybdrqwtjwSmmxOCj57aPG8QcaxK?=
 =?us-ascii?Q?aL0eOB3dw9VTBkPQcJg0o+B1L5sdmXGuaCakiqiF/edCWUykk6SvbMdTR6jG?=
 =?us-ascii?Q?W42PrixSjZPPeQ6+dlA9jRS052Oml1bpJ3QaEaP5FEyMV14bGoinWHfVK1MV?=
 =?us-ascii?Q?Y+xh8cpmNdlHwASyGSuiVnm5de1aSHBEkd786LCsW7iK6BayhhLCwH3Rr4jb?=
 =?us-ascii?Q?xkqnl/qFLvUayCSPfMmrMZzXWYYkdqa1/Iy7jg7ZQiy4sCd5RzTPmG+U2XD0?=
 =?us-ascii?Q?SP5bOn6KQvNObvN+dPaN0Nv3m0yUR36XsWr82W52Pf6fyDcM6NTY/ttb3lkP?=
 =?us-ascii?Q?mnnudrFWJzxYv4ICQD4pEN6tcRQFvKoT4oS1Z9Rr4Q/LqZYJJ78LHvVWx8JC?=
 =?us-ascii?Q?5OzMeXGmOWfxNOmKkEunpUskJQBkofEWpHaKP8oCUoNUK6s3qq7247cfmfEu?=
 =?us-ascii?Q?iCJvVxou4xMu06m8Md/hIfMahOE+4hQzsigC0bpdkszoZ4+TNBaR1KKeBpvH?=
 =?us-ascii?Q?JbtGRlohxYScIg2uZ2iIPzFHQe3Zd1rwuBg5y+dBQEQ8XXWZ54LJxW+dmrSR?=
 =?us-ascii?Q?A6X1jsHN0+SjLVPatX06z44CP5cSUxev6T7PRjNVNMk9B7ZgMG403+T2Q+e7?=
 =?us-ascii?Q?+CSK5uEPl9INyIO8sg1ids3bc7oghaxgi2OcygZtpAhW+wm/aAXDZOpV2bxq?=
 =?us-ascii?Q?7NzzA/zYgUlBZdxDomEmgyY8wYgO59IlwX1ICzRo?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47a163be-09a6-466b-cc15-08db7df964cb
X-MS-Exchange-CrossTenant-AuthSource: AM5PR04MB3139.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2023 08:17:09.6154
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: onmyxbH86IqXyG3cPqAsP7Kb+tqY/lRz0/oTvQbtEEQdHgO94H/jOgqS6QD/qr6DY03KVzKpZdKwGTHZk4TMBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9132
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wei Fang <wei.fang@nxp.com>

In the case of heavy XDP traffic to be transmitted, the console
will print the error log continuously if there are lack of enough
BDs to accommodate the frames. The log looks like below.

[  160.013112] fec 30be0000.ethernet eth0: NOT enough BD for SG!
[  160.023116] fec 30be0000.ethernet eth0: NOT enough BD for SG!
[  160.028926] fec 30be0000.ethernet eth0: NOT enough BD for SG!
[  160.038946] fec 30be0000.ethernet eth0: NOT enough BD for SG!
[  160.044758] fec 30be0000.ethernet eth0: NOT enough BD for SG!

Not only will this log be replicated and redundant, it will also
degrade XDP performance. So we use netdev_err_once() instead of
netdev_err() now.

Fixes: 6d6b39f180b8 ("net: fec: add initial XDP support")
Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
V2 change:
This is a new patch which is separated from the patch 3.
---
 drivers/net/ethernet/freescale/fec_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index c59576ab8c7a..ec9e4bdb0c06 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3836,7 +3836,7 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
 
 	entries_free = fec_enet_get_free_txdesc_num(txq);
 	if (entries_free < MAX_SKB_FRAGS + 1) {
-		netdev_err(fep->netdev, "NOT enough BD for SG!\n");
+		netdev_err_once(fep->netdev, "NOT enough BD for SG!\n");
 		return -EBUSY;
 	}
 
-- 
2.25.1