Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp30170001rwd; Thu, 6 Jul 2023 01:47:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlFLW3AVo74DDKEE2Dx0yMqEjXZxgXRJGDXjNF4s7sPLDtVHH52zWUm6JV4cRonxpghrgpFH X-Received: by 2002:a17:90a:f412:b0:262:e629:f545 with SMTP id ch18-20020a17090af41200b00262e629f545mr875884pjb.1.1688633276820; Thu, 06 Jul 2023 01:47:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688633276; cv=none; d=google.com; s=arc-20160816; b=UWzTWSJesz2JhdbaelTaxOA+57sFgtiqsjqv5k9WlpqeMGAy4iSfc3DirQV1GJO2hw HYvIqBRY1eMdtrLaE/feCM7rD3AkzkZ44MnhMiwapEIye54GLpTJuax1Xb7pSTCBJirz z8CinDCFXd00ax2m8MTUTWLPnF+BObwF+qYXW1v/GdMIvoIsgpIqa1nJlne7RANXOAoL EyM8P0spDpskRl9YreYkATUjfDwZLXrDvk0RP/kOOJWDwQSpG4eRd2n6fEksytpFcg5m VTRrOF+v2AGr4+OSg7reXOdN1U8XhcA5pTYiLXgJO+I/NotaOtJ2SZdAlIWat/w/cmYL 4i6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=uR4y3omuMdeq94aQV10LDw49xhVeOOuaecbCLxNYkRA=; fh=FFBsz2QnHRKie5ZFbptp9/K2hcgUWRDxK1Y0IN27B3Q=; b=fmw7LIghSbQoeUxtsch8yMdWJ5zDDoqys0JBaS1AIVZMD+Tl0OtPBToRcyevLMq24F e4L2sVy8xCl5qyIzPC119HNhnun+Zh3WAYlc2/19zAjGjzuioMzK9PrX3+HIkOmLt+xv vXVuowaml3lxZoYRxIdp4ppKGdNj27Z7+/WWofzvwBSjj1qU0Z2z+X1HhIyevF7lbJSu 1zyG47nSlJfWY1jdhBTIjCLwxAoyYt5eAyWZxHidxDqW9CcUhlI72fn7hvBE3DiRGRCl DPUUlv+uN2bTdjTztno4vFz7Ze/ofbEO/R4UfKtQR+YeY9zYdnEXGGGrJI5yE+cVg5pY CKyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=US4pwvKy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mq17-20020a17090b381100b00260f28b14e4si3903053pjb.4.2023.07.06.01.47.42; Thu, 06 Jul 2023 01:47:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=US4pwvKy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233161AbjGFIEp (ORCPT + 99 others); Thu, 6 Jul 2023 04:04:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbjGFIEj (ORCPT ); Thu, 6 Jul 2023 04:04:39 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C8191725 for ; Thu, 6 Jul 2023 01:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688630632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uR4y3omuMdeq94aQV10LDw49xhVeOOuaecbCLxNYkRA=; b=US4pwvKy6x9Q8zLbDRv1Op2x1P7ADI4jNJXRPu5pvDHoYFUdyMji6tfzw1GsH32byPSCIy 3Qe1H8u43Na3yLhZLPedzi6RNsqzX/vWdRTCq/LyqxOIeVouokyhcNdjW93FevTfEQsV0/ IQPk2LBf34o8qTilMJWvLTP/ksNFafw= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-261-x3zz2MIpPZ6PNXOEjEa4mw-1; Thu, 06 Jul 2023 04:03:51 -0400 X-MC-Unique: x3zz2MIpPZ6PNXOEjEa4mw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2b6cf671d94so3855781fa.1 for ; Thu, 06 Jul 2023 01:03:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688630630; x=1691222630; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uR4y3omuMdeq94aQV10LDw49xhVeOOuaecbCLxNYkRA=; b=TTwOoUfuPJ4ufIexaoCR9NwSp7tE5dAZdwRepapZaWv30EfLfNaPN+JN+eusNTvbrY MDmK4Kk230hjuo5R5lJs9KYj52AIDXFQjQp0HjgSYQaO5DAqvNl6j/q0DSu4E/YXORwV kMvZ1xxz5eSiGUl2Vb9oAkpsMmNNLHFb03OfS47Av7+ir+1n7WRyWfEiPZVCWAwAXA4o UF58sbeWTYzzVamASVluJYAUeEW9uL0dsE1ErCt4D/cYKy3BBfPtsDRviFIXmOtJDm4p vv0WAhdRkk8zW0NcPcgomxl0TDfImo6U57NAnDH21AEopWxW384e8zPZKhJBz1cXIssi alWg== X-Gm-Message-State: ABy/qLYzVgvXR0DBCl2rVantdHJpQAX3IMyhAZ+UGIIjSIbySFvkTBYe jzyHosk/fr1j6MWfqf1y1uGHMNlRbB9cCI7XUfpbiiT07mCyKtpWRq6D6gOcYgqdOKrMnfJBpCp beZrc4j6w1qAjsQnRJW0Q2TLuLUHaYsfYZF8Yjr7R X-Received: by 2002:a2e:9591:0:b0:2b4:7380:230 with SMTP id w17-20020a2e9591000000b002b473800230mr759826ljh.13.1688630629802; Thu, 06 Jul 2023 01:03:49 -0700 (PDT) X-Received: by 2002:a2e:9591:0:b0:2b4:7380:230 with SMTP id w17-20020a2e9591000000b002b473800230mr759810ljh.13.1688630629454; Thu, 06 Jul 2023 01:03:49 -0700 (PDT) MIME-Version: 1.0 References: <20230703142218.362549-1-eperezma@redhat.com> <20230703105022-mutt-send-email-mst@kernel.org> <20230704063646-mutt-send-email-mst@kernel.org> <20230704114159-mutt-send-email-mst@kernel.org> <20230705043940-mutt-send-email-mst@kernel.org> In-Reply-To: From: Jason Wang Date: Thu, 6 Jul 2023 16:03:37 +0800 Message-ID: Subject: Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it To: Eugenio Perez Martin Cc: "Michael S. Tsirkin" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Shannon Nelson , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 6, 2023 at 3:55=E2=80=AFPM Jason Wang wro= te: > > On Thu, Jul 6, 2023 at 3:06=E2=80=AFPM Eugenio Perez Martin wrote: > > > > On Thu, Jul 6, 2023 at 3:55=E2=80=AFAM Jason Wang = wrote: > > > > > > On Wed, Jul 5, 2023 at 4:41=E2=80=AFPM Michael S. Tsirkin wrote: > > > > > > > > On Wed, Jul 05, 2023 at 03:49:58PM +0800, Jason Wang wrote: > > > > > On Tue, Jul 4, 2023 at 11:45=E2=80=AFPM Michael S. Tsirkin wrote: > > > > > > > > > > > > On Tue, Jul 04, 2023 at 01:36:11PM +0200, Eugenio Perez Martin = wrote: > > > > > > > On Tue, Jul 4, 2023 at 12:38=E2=80=AFPM Michael S. Tsirkin wrote: > > > > > > > > > > > > > > > > On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Mar= tin wrote: > > > > > > > > > On Mon, Jul 3, 2023 at 4:52=E2=80=AFPM Michael S. Tsirkin= wrote: > > > > > > > > > > > > > > > > > > > > On Mon, Jul 03, 2023 at 04:22:18PM +0200, Eugenio P=C3= =A9rez wrote: > > > > > > > > > > > With the current code it is accepted as long as userl= and send it. > > > > > > > > > > > > > > > > > > > > > > Although userland should not set a feature flag that = has not been > > > > > > > > > > > offered to it with VHOST_GET_BACKEND_FEATURES, the cu= rrent code will not > > > > > > > > > > > complain for it. > > > > > > > > > > > > > > > > > > > > > > Since there is no specific reason for any parent to r= eject that backend > > > > > > > > > > > feature bit when it has been proposed, let's control = it at vdpa frontend > > > > > > > > > > > level. Future patches may move this control to the pa= rent driver. > > > > > > > > > > > > > > > > > > > > > > Fixes: 967800d2d52e ("vdpa: accept VHOST_BACKEND_F_EN= ABLE_AFTER_DRIVER_OK backend feature") > > > > > > > > > > > Signed-off-by: Eugenio P=C3=A9rez > > > > > > > > > > > > > > > > > > > > Please do send v3. And again, I don't want to send "aft= er driver ok" hack > > > > > > > > > > upstream at all, I merged it in next just to give it so= me testing. > > > > > > > > > > We want RING_ACCESS_AFTER_KICK or some such. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Current devices do not support that semantic. > > > > > > > > > > > > > > > > Which devices specifically access the ring after DRIVER_OK = but before > > > > > > > > a kick? > > > > > > > > > > > > > > > > > > > > > > Previous versions of the QEMU LM series did a spurious kick t= o start > > > > > > > traffic at the LM destination [1]. When it was proposed, that= spurious > > > > > > > kick was removed from the series because to check for descrip= tors > > > > > > > after driver_ok, even without a kick, was considered work of = the > > > > > > > parent driver. > > > > > > > > > > > > > > I'm ok to go back to this spurious kick, but I'm not sure if = the hw > > > > > > > will read the ring before the kick actually. I can ask. > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > [1] https://lists.nongnu.org/archive/html/qemu-devel/2023-01/= msg02775.html > > > > > > > > > > > > Let's find out. We need to check for ENABLE_AFTER_DRIVER_OK too= , no? > > > > > > > > > > My understanding is [1] assuming ACCESS_AFTER_KICK. This seems > > > > > sub-optimal than assuming ENABLE_AFTER_DRIVER_OK. > > > > > > > > > > But this reminds me one thing, as the thread is going too long, I > > > > > wonder if we simply assume ENABLE_AFTER_DRIVER_OK if RING_RESET i= s > > > > > supported? > > > > > > > > > > Thanks > > > > > > > > I don't see what does one have to do with another ... > > > > > > > > I think with RING_RESET we had another solution, enable rings > > > > mapping them to a zero page, then reset and re-enable later. > > > > > > As discussed before, this seems to have some problems: > > > > > > 1) The behaviour is not clarified in the document > > > 2) zero is a valid IOVA > > > > > > > I think we're not on the same page here. > > > > As I understood, rings mapped to a zero page means essentially an > > avail ring whose avail_idx is always 0, offered to the device instead > > of the guest's ring. Once all CVQ commands are processed, we use > > RING_RESET to switch to the right ring, being guest's or SVQ vring. > > I get this. This seems more complicated in the destination: shadow vq + A= SID? So it's something like: 1) set all vq ASID to shadow virtqueue 2) do not add any bufs to data qp (stick 0 as avail index) 3) start to restore states via cvq 4) ring_rest for dataqp 5) set_vq_state for dataqp 6) re-initialize dataqp address etc 7) set data QP ASID to guest 8) set queue_enable ? Thanks > > Thanks > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > My plan was to convert > > > > > > > > > it in vp_vdpa if needed, and reuse the current vdpa ops. = Sorry if I > > > > > > > > > was not explicit enough. > > > > > > > > > > > > > > > > > > The only solution I can see to that is to trap & emulate = in the vdpa > > > > > > > > > (parent?) driver, as talked in virtio-comment. But that c= omplicates > > > > > > > > > the architecture: > > > > > > > > > * Offer VHOST_BACKEND_F_RING_ACCESS_AFTER_KICK > > > > > > > > > * Store vq enable state separately, at > > > > > > > > > vdpa->config->set_vq_ready(true), but not transmit that e= nable to hw > > > > > > > > > * Store the doorbell state separately, but do not configu= re it to the > > > > > > > > > device directly. > > > > > > > > > > > > > > > > > > But how to recover if the device cannot configure them at= kick time, > > > > > > > > > for example? > > > > > > > > > > > > > > > > > > Maybe we can just fail if the parent driver does not supp= ort enabling > > > > > > > > > the vq after DRIVER_OK? That way no new feature flag is n= eeded. > > > > > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > > Sent with Fixes: tag pointing to git.kernel.org/pub/s= cm/linux/kernel/git/mst > > > > > > > > > > > commit. Please let me know if I should send a v3 of [= 1] instead. > > > > > > > > > > > > > > > > > > > > > > [1] https://lore.kernel.org/lkml/20230609121244-mutt-= send-email-mst@kernel.org/T/ > > > > > > > > > > > --- > > > > > > > > > > > drivers/vhost/vdpa.c | 7 +++++-- > > > > > > > > > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdp= a.c > > > > > > > > > > > index e1abf29fed5b..a7e554352351 100644 > > > > > > > > > > > --- a/drivers/vhost/vdpa.c > > > > > > > > > > > +++ b/drivers/vhost/vdpa.c > > > > > > > > > > > @@ -681,18 +681,21 @@ static long vhost_vdpa_unlocked= _ioctl(struct file *filep, > > > > > > > > > > > { > > > > > > > > > > > struct vhost_vdpa *v =3D filep->private_data; > > > > > > > > > > > struct vhost_dev *d =3D &v->vdev; > > > > > > > > > > > + const struct vdpa_config_ops *ops =3D v->vdpa->= config; > > > > > > > > > > > void __user *argp =3D (void __user *)arg; > > > > > > > > > > > u64 __user *featurep =3D argp; > > > > > > > > > > > - u64 features; > > > > > > > > > > > + u64 features, parent_features =3D 0; > > > > > > > > > > > long r =3D 0; > > > > > > > > > > > > > > > > > > > > > > if (cmd =3D=3D VHOST_SET_BACKEND_FEATURES) { > > > > > > > > > > > if (copy_from_user(&features, featurep,= sizeof(features))) > > > > > > > > > > > return -EFAULT; > > > > > > > > > > > + if (ops->get_backend_features) > > > > > > > > > > > + parent_features =3D ops->get_ba= ckend_features(v->vdpa); > > > > > > > > > > > if (features & ~(VHOST_VDPA_BACKEND_FEA= TURES | > > > > > > > > > > > BIT_ULL(VHOST_BACKEND_= F_SUSPEND) | > > > > > > > > > > > BIT_ULL(VHOST_BACKEND_= F_RESUME) | > > > > > > > > > > > - BIT_ULL(VHOST_BACKEND_= F_ENABLE_AFTER_DRIVER_OK))) > > > > > > > > > > > + parent_features)) > > > > > > > > > > > return -EOPNOTSUPP; > > > > > > > > > > > if ((features & BIT_ULL(VHOST_BACKEND_F= _SUSPEND)) && > > > > > > > > > > > !vhost_vdpa_can_suspend(v)) > > > > > > > > > > > -- > > > > > > > > > > > 2.39.3 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >