Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8c1e84ab-e5e0-a3c8-517f-ced3dc516d3e@amlogic.com>
Date:   Thu, 6 Jul 2023 16:44:45 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 2/2] arm64: dts: add board AN400
To:     neil.armstrong@linaro.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
        devicetree@vger.kernel.org
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
References: <20230704031636.3215838-1-xianwei.zhao@amlogic.com>
 <20230704031636.3215838-3-xianwei.zhao@amlogic.com>
 <112727a2-29c5-1402-deb7-f35119b4338e@linaro.org>
Content-Language: en-US
From:   Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <112727a2-29c5-1402-deb7-f35119b4338e@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVVZcjhLSUFPaC8zYWFvNU9jdzNFNWMvbTFSYytucENxdUUwQldkb1ZJbUlR?=
 =?utf-8?B?U0x4OGRJY1ZtR0VOMTM1RmhMa2JoUXZoU3M3Y1lXOENHS0RqMUJYNVNzK0Z2?=
 =?utf-8?B?NmsxMm4zTHVzVDJPeDc4b1FuOUZid3VEalhMY1J1bW0zK0Njb1NoNFFZZC9m?=
 =?utf-8?B?aHdwbmpmS3RGQ3dsNzhocHBpZCtrZThnTkVsQnNmcVV2VmpVbXF0RER5c21y?=
 =?utf-8?B?V2dGM1FUQWY3RUc4VVBxNktzajJVRk5idWtlMExSNzBGQzQweEpoOXhicEt2?=
 =?utf-8?B?MVQwKzBHYXRSZy90OWtUWWdKbnBKc2czbGlRdFp1YUl0cEluTkpJL1NYUHpO?=
 =?utf-8?B?RnpUN3gycVUwQVR2bERTTkNtSXdDaWF6NTk3empkRWwwVGxwN1R4RHRYQkRM?=
 =?utf-8?B?dVFodG52aHRsNElNZ0NHZ0dCTC94T2RkSkYrSitCYW5TODU3bnlKZlB4Szlv?=
 =?utf-8?B?RHBJWk83dTRYMjM5UXRkOVVyVXp2VCs0UnJmV3IycnZ5bXRlWEs4OVBNd0xT?=
 =?utf-8?B?cnpZRm5oNDB0QWFCaEo1WnRqZ3RtZ3poN0d6VWxnVU5PTVFzbmd0UFRrSzVI?=
 =?utf-8?B?L0diVUhoYTR4VlZueklZWmlTUGRyR2hsT0s0SloyRlZCQTF0VUhVRVZFTmJt?=
 =?utf-8?B?YW5iUXprYkIyTEpCM3duZlVDR0JkcHpiamhGd0N4dnRkWWFib3U2aVRPUE1a?=
 =?utf-8?B?U3NCcS9MREUxdDBMUnh5TTVlejNLazhtVmRSNzdBdUw3UDJiVVVLSlg3dzIx?=
 =?utf-8?B?UXJaOHdzT0dVUTlrcVh0Vll6cTM0aGN1eDZ2d08veU5aZW1NaHc2WjhNQ0Vi?=
 =?utf-8?B?NnFwOVNxL1Y2WldReGJMbDZjeklUTHVsUlZFNStKUys2SjQ1MXozSWoxaS8r?=
 =?utf-8?B?VWx1aXdrVlh0SStVYjRGUVFHTjdnRURBUnpmSmFjUWowKzZvYnBnL0FzaDI5?=
 =?utf-8?B?VkJZZi84SDJsNVNwRVZCUGVWMHU5NDgxSUVTSnpTQjVHUnZGUW9BMVUrVTk4?=
 =?utf-8?B?ZVFIbC9wYnpTbjdGTDE3ayt1SHlFemF2eVRiL0IyWUt1L1VGeDdQeDU1LzJx?=
 =?utf-8?B?b2pkOUZOWnJXRnNPNzFWTjc1V1QrM3ZOSURlMHJwek5qdlZuY0xyY0tyb2Nk?=
 =?utf-8?B?UEF2SDNyby9nOFlHWlEvYW0xNG8rVG9FdVZyWTY4cCtXLzU5WVlJSHY5b2ZU?=
 =?utf-8?B?ZWdid1VYSTNIcDNRUjFvR0txN1ZGQlUyR1hNcTNGYTBMdko2SEVOR1F4cUx1?=
 =?utf-8?B?STltbVBlYXJ1NGZPUkJmdkowbDlQQThJNnRWNllFOVhraXdSbUZTZjE0K2I2?=
 =?utf-8?B?UTRBcFNScE5ORHhXZDFRSkdxbk1PQTVyN0IwallpaDNEK2hZNUkzVXFBNldk?=
 =?utf-8?B?ODBzUlZEY050VEZQNE9uTTVNK0tyWnU5WGZ4Rmx6Z0F4MmMyWENtTHg3bmt0?=
 =?utf-8?B?UE5iNFBzRVFhVVIxclZjNDBWY01NYkR2MnRDay94VldUV3JJRllSUm1Xenll?=
 =?utf-8?B?czFyTlBFOXJjT0d2TEQ1TVh2ak1ZUmRwczJOaFhaUStBd1MvUkUycVJXUjFJ?=
 =?utf-8?B?UVl5M2oyYTRENFZHQ0RxNFpLa0VRVGRoQktnUmFJYUxzdFc5MTczTHJsNlh3?=
 =?utf-8?B?UHh5Q1AxcUhmZ29NaWI0NllnTlRQaHNPY0tGbndjMDN6OW5oYXkrUWhrMHpV?=
 =?utf-8?B?bDZhd1l2UDMyTzlJelA3cFBVcWVnNi9VSjQyZkw5bW1jVkdmbVYzby92a1RI?=
 =?utf-8?B?MFpRaTl4MjdraUdtR3Jhb2IzWFUyVDZVR2lPa3Qyai80VW9iTGJldU5MVllG?=
 =?utf-8?B?ek1nald5dkZyZGlGMjRaOG9OMm9xOWVObE00VGZ1SFZlc0FPK1FLandWcjBn?=
 =?utf-8?B?cGFRUlR1NzU4K2hBaWhoOWQwTXBSZlkzYnYyOE9vSXdkNm9EQ1NkUzlmV25s?=
 =?utf-8?B?YW1VSWpncElhTDRHMmZlUnBXOWxrMGYxSktzN1ZqWERoTHBJdXpybFRsWUxz?=
 =?utf-8?B?WEFGaXIwbEsxQXBEZzdheW9zRDlUSEhTZ3U3SHZ6Z05INjlUVm5vSW1YTm9j?=
 =?utf-8?B?WmFiSVhBWTJnZTVhU2h0TEFWblRHSHViVVptQldaWEFlcThlTzRaS1ErZlFZ?=
 =?utf-8?B?QUJaQnY5dUhBd2dLUmRNY01WT3dlTURvVVRmWEUxM015ZkxpWXZxQ09ma0tY?=
 =?utf-8?B?WWc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3df0d48a-8454-43c2-df13-08db7dfd44a1
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2023 08:44:53.6340
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2ppt/cWJwkz0Ng5qdX70EFRc1xq82lAyKI2gGTUyHq8bLJhQT5npxVGyfxI94WOifeuoqiTIjcLIoLGrp0zx4bLqHy672tdDDtFI2ffwy38=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0302MB5362
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Neil,
      Thanks.

On 2023/7/4 16:09, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
> 
> Hi,
> 
> On 04/07/2023 05:16, Xianwei Zhao wrote:
>> Add devicetree support for Amlogic AN400  board based T7 SoC.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>>   arch/arm64/boot/dts/amlogic/Makefile          |  1 +
>>   .../dts/amlogic/amlogic-t7-a311d2-an400.dts   | 39 +++++++++++++++++++
>>   2 files changed, 40 insertions(+)
>>   create mode 100644 
>> arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile 
>> b/arch/arm64/boot/dts/amlogic/Makefile
>> index 91fa425116ea..8b6f57a94863 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -1,5 +1,6 @@
>>   # SPDX-License-Identifier: GPL-2.0
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409.dtb
>> +dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-an400.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-khadas-vim4.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += meson-a1-ad401.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j100.dtb
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts 
>> b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
>> new file mode 100644
>> index 000000000000..d755e1ee108a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
>> @@ -0,0 +1,39 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2023 Amlogic, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "amlogic-t7.dtsi"
>> +
>> +/ {
>> +     model = "Amlogic A311D2 AN400 Development Board";
>> +     compatible = "amlogic,an400", "amlogic,a311d2", "amlogic,t7";
>> +     interrupt-parent = <&gic>;
>> +     #address-cells = <2>;
>> +     #size-cells = <2>;
>> +
>> +     aliases {
>> +             serial0 = &uart_a;
>> +     };
>> +
>> +     memory@0 {
>> +             device_type = "memory";
>> +             linux,usable-memory = <0x00000000 0x00000000 0x00000000 
>> 0xE0000000
>> +                                     0x00000001 0x00000000 0x00000000 
>> 0x20000000>;
> 
> Please use "reg =" instead of linux,usable-memory, which is not a 
> documented property
> 
> Please use `make CHECK_DTBS=yes amlogic/amlogic-t7-a311d2-an400.dtb` 
> before posting DT patches,
> and make sure there's no errors except already in-review bindings like 
> here the UART compatible.
> 
> The result here is:
> arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: /: memory@0: 
> 'anyOf' conditional failed, one must be fixed:
>          'reg' is a required property
>          'ranges' is a required property
>          From schema: 
> /usr/local/lib/python3.10/dist-packages/dtschema/schemas/root-node.yaml
> arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: /: memory@0: 
> 'linux,usable-memory' does not match any of the regexes: 'pinctrl-[0-9]+'
>          From schema: 
> /usr/local/lib/python3.10/dist-packages/dtschema/schemas/memory.yaml
> arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: /: memory@0: 
> 'reg' is a required property
>          From schema: 
> /usr/local/lib/python3.10/dist-packages/dtschema/schemas/memory.yaml
> 
> Please fix this one.
>
Will do
> arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: serial@78000: 
> compatible: 'oneOf' conditional failed, one must be fixed:
>          ['amlogic,t7-uart', 'amlogic,meson-s4-uart'] is too short
>          ['amlogic,t7-uart', 'amlogic,meson-s4-uart'] is too long
>          'amlogic,t7-uart' is not one of ['amlogic,meson6-uart', 
> 'amlogic,meson8-uart', 'amlogic,meson8b-uart', 'amlogic,meson-gx-uart', 
> 'amlogic,meson-s4-uart']
>          'amlogic,meson-g12a-uart' was expected
>          'amlogic,meson-ao-uart' was expected
>          'amlogic,meson-gx-uart' was expected
>          From schema: 
> Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: serial@78000: 
> Unevaluated properties are not allowed ('compatible' was unexpected)
>          From schema: 
> Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dtb: 
> /soc/bus@fe000000/serial@78000: failed to match any schema with 
> compatible: ['amlogic,t7-uart', 'amlogic,meson-s4-uart']
> 
> This one is OK, the UART bindings is reviewed and should be picked up 
> for v6.6
> 
> Neil
> 
>> +     };
>> +
>> +     xtal: xtal-clk {
>> +             compatible = "fixed-clock";
>> +             clock-frequency = <24000000>;
>> +             clock-output-names = "xtal";
>> +             #clock-cells = <0>;
>> +     };
>> +};
>> +
>> +&uart_a {
>> +     clocks = <&xtal>, <&xtal>, <&xtal>;
>> +     clock-names = "xtal", "pclk", "baud";
>> +     status = "okay";
>> +};
>