Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752641AbXJWPKj (ORCPT ); Tue, 23 Oct 2007 11:10:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751848AbXJWPKc (ORCPT ); Tue, 23 Oct 2007 11:10:32 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:46467 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751827AbXJWPKb (ORCPT ); Tue, 23 Oct 2007 11:10:31 -0400 Date: Tue, 23 Oct 2007 17:11:00 +0200 From: Adrian Bunk To: Ingo Molnar Cc: Jeremy Fitzhardinge , Andi Kleen , Al Viro , WANG Cong , Sam Ravnborg , Nix , Jeff Dike , Paolo Giarrusso , user-mode-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Rob Landley Subject: Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final. Message-ID: <20071023151059.GU30533@stusta.de> References: <471D2ECC.6090209@goop.org> <20071022231927.GA30814@elte.hu> <471D389E.40609@goop.org> <20071023084546.GA17007@elte.hu> <20071023131009.GA32298@elte.hu> <20071023142006.GA9961@elte.hu> <471E05C0.4010005@goop.org> <20071023144710.GA13785@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20071023144710.GA13785@elte.hu> User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1990 Lines: 53 On Tue, Oct 23, 2007 at 04:47:10PM +0200, Ingo Molnar wrote: > > * Jeremy Fitzhardinge wrote: > > > Ingo Molnar wrote: > > > * Andi Kleen wrote: > > > > > > > > >>>> You should rename it then to "asmcall" or something. > > >>>> > > >>> if then that should be a separate renaming patch. > > >>> > > >> Well you're asking for the ugly hacks for out of tree code. [...] > > >> > > > > > > nice word-bending there. I'm asking for pre-existing annotations to > > > survive. It hurts you _nothing_ and it was a world of pain for us to > > > recover those lost annotations. Anyway, if Jeremy does not object to the > > > patch > > > > I don't have any objections to the idea of the patch, but I'm still > > concerned about the practical aspects of it. Maintaining these kinds > > of annotations is hard/fragile/etc when the compiler doesn't warn when > > you get it wrong, and only a very specific use-case will reveal the > > problem (and do so in a fairly obscure way). > > it wont be any different from the situation before - we had no such > warnings there either. Anyway, this shouldnt really bother you as at the > moment it's only used for -rt. The issue is to keep something we had > before (but which was stupidly/carelessly removed). If it breaks we'll > fix it up. >... Until recently (read: before 2.6.20) fastcall had a semantics on i386 that resulted in compile errors if you got it wrong. > Ingo cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/