Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp30232765rwd; Thu, 6 Jul 2023 02:55:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlFEGltebOY2Z2I2jvLegQmQyXZq/Fbw40yXJHOLjJOPig9pSFmkO4NB07qLVEcPNyEpJR7p X-Received: by 2002:a05:6870:a2c7:b0:1b0:151c:9b19 with SMTP id w7-20020a056870a2c700b001b0151c9b19mr1728437oak.18.1688637353654; Thu, 06 Jul 2023 02:55:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688637353; cv=none; d=google.com; s=arc-20160816; b=qcGsntemWEMK3oO0cMu+B0/h6UYs6JN+6MfZg4642TZ10wJig/z/M7VQKtOFcsOS7J p/e/WRYKu47anHXLreLQ9FnFCDnBYgpWqzsxWxSzihssSmm0SA0bMPjxiwBU1AHA8GeE i/sWEQ8jC8ck3BHAURawq7+jEStgQPE9h/hq+zvznYeZ96kbVtJLvmd+zOkpK84H89Yz h6chunDNr+HmR3p+xYUC5hOMSBpmAHjxYHRumrD7+zWoZdrJy7EbGcz3OuSv2e+RZS/r +s7hEs3L0IJNB+Pu8/aam2rG2d+Fa3+Ue+IcBmwSMuZ9QQH/2G9XMm4EnnuQupHo8Mio 1EnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=j4dnnxZ1wSmFozKRBQ7ttfuc4yJgvWqhe2F7b5ZZXtc=; fh=mqigw4XO6os++txBZm5D4QERu26ygVgJWKQ9BZ9aySE=; b=ZLdgzgImblmLm6drFmriFKmyYowvEgW9LrDBNTHdZYXiLyasJITME5AIyZlgeBafJ3 K14AfqRUhJEnovqE6TQD5bn3UBgS6dOyeH36yuykpFAqC071q3fLjvEDCj5eit6CZmyR dEIUrTq6PcvprYv6l1ecRORd/qfQNSjiFBddS1r3imqQfEOcO54h+P5JCQR9qb4RoB2C dBQDINpULUIB6UrnGOECxKGCvIKOtHnts2Ma2Gioo920L3Gblc681BD/6kFOOYCazu+1 45y6Q7CQmVVoBxXMS5wxvyCsTMNme366Ari3jQLnB7yTOQ0QsJV9XT/wzSVqMt8dJ6lS mcXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="GuzFCH/V"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pi16-20020a17090b1e5000b00263f6368c25si1356325pjb.146.2023.07.06.02.55.41; Thu, 06 Jul 2023 02:55:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="GuzFCH/V"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232066AbjGFJkE (ORCPT + 99 others); Thu, 6 Jul 2023 05:40:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbjGFJkB (ORCPT ); Thu, 6 Jul 2023 05:40:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5749B10C for ; Thu, 6 Jul 2023 02:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688636353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j4dnnxZ1wSmFozKRBQ7ttfuc4yJgvWqhe2F7b5ZZXtc=; b=GuzFCH/VIzhpPOTyzq1KeOWf/Cdx+m/BBgNogDLToYxOZjahRT8qTTVA/y9/rEmLjjlqix iaBTGCdPtsUUB5OpJCf6jvIAbR7y90o/XCuXxlxNMFIEbuAo9Npy+0BAd5fdcFBU0yVP2m u6i69TKzP96If6aV6ux2durk6Jrq1+k= Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-1aKgXVR7OhWuq-SDEXssHw-1; Thu, 06 Jul 2023 05:39:12 -0400 X-MC-Unique: 1aKgXVR7OhWuq-SDEXssHw-1 Received: by mail-yb1-f197.google.com with SMTP id 3f1490d57ef6-c5e3d2c339aso486291276.3 for ; Thu, 06 Jul 2023 02:39:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688636352; x=1691228352; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j4dnnxZ1wSmFozKRBQ7ttfuc4yJgvWqhe2F7b5ZZXtc=; b=F+GRvHUseqHsryl7Tce8CI5axHV6itqEXLYcDxyS07bThZ+ZEYQZ+OS7ZgS6O/Mf32 pfZe94h5An+zV7khyFAuJZ1o64+symVXAyC6RRDI5u4sMCNqKJELUmAO7vLE/W7+o7D0 hFN20XDRyY92lAaYACIvgPt2PO7y8gmz+eElp5EsOpQQEFpoT99XfgabeGP3xdp3i31p /riYL8y1TqlBITL8j7uT4I39qY2CG7cnKsXsaGk2a2E0/7wzBq9jios1zMNepvN//+Oo JrRNBnRA2t7Tcrb5scuvqQHNvhELVt7iELUf1WYTwFcZQ+3XbdCvfxYesFeEp9UbtSE2 afVw== X-Gm-Message-State: ABy/qLb2qtIlqf9oM5J2w/MnYbfEcFewZQFqhCF0K+XDh/oMh/SS1GQM hX+q3GPcv6f48Nplnb7RCcHUaT8aIUVUgt5LCwj+JjdwkojscZko1C7VaFmMt7UhcBYjZNHuqZH 5BeHZDROm8fzTJnO1NP8CiypnkrqELmlmWPH6zJvSwyCovNmz X-Received: by 2002:a25:188a:0:b0:c12:29ac:1d36 with SMTP id 132-20020a25188a000000b00c1229ac1d36mr1239714yby.7.1688636351761; Thu, 06 Jul 2023 02:39:11 -0700 (PDT) X-Received: by 2002:a25:188a:0:b0:c12:29ac:1d36 with SMTP id 132-20020a25188a000000b00c1229ac1d36mr1239701yby.7.1688636351465; Thu, 06 Jul 2023 02:39:11 -0700 (PDT) MIME-Version: 1.0 References: <20230703142218.362549-1-eperezma@redhat.com> <20230703105022-mutt-send-email-mst@kernel.org> <20230704063646-mutt-send-email-mst@kernel.org> <20230704114159-mutt-send-email-mst@kernel.org> <20230705043940-mutt-send-email-mst@kernel.org> In-Reply-To: From: Eugenio Perez Martin Date: Thu, 6 Jul 2023 11:38:35 +0200 Message-ID: Subject: Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it To: Jason Wang Cc: "Michael S. Tsirkin" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Shannon Nelson , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 6, 2023 at 10:03=E2=80=AFAM Jason Wang wr= ote: > > On Thu, Jul 6, 2023 at 3:55=E2=80=AFPM Jason Wang w= rote: > > > > On Thu, Jul 6, 2023 at 3:06=E2=80=AFPM Eugenio Perez Martin wrote: > > > > > > On Thu, Jul 6, 2023 at 3:55=E2=80=AFAM Jason Wang wrote: > > > > > > > > On Wed, Jul 5, 2023 at 4:41=E2=80=AFPM Michael S. Tsirkin wrote: > > > > > > > > > > On Wed, Jul 05, 2023 at 03:49:58PM +0800, Jason Wang wrote: > > > > > > On Tue, Jul 4, 2023 at 11:45=E2=80=AFPM Michael S. Tsirkin wrote: > > > > > > > > > > > > > > On Tue, Jul 04, 2023 at 01:36:11PM +0200, Eugenio Perez Marti= n wrote: > > > > > > > > On Tue, Jul 4, 2023 at 12:38=E2=80=AFPM Michael S. Tsirkin = wrote: > > > > > > > > > > > > > > > > > > On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez M= artin wrote: > > > > > > > > > > On Mon, Jul 3, 2023 at 4:52=E2=80=AFPM Michael S. Tsirk= in wrote: > > > > > > > > > > > > > > > > > > > > > > On Mon, Jul 03, 2023 at 04:22:18PM +0200, Eugenio P= =C3=A9rez wrote: > > > > > > > > > > > > With the current code it is accepted as long as use= rland send it. > > > > > > > > > > > > > > > > > > > > > > > > Although userland should not set a feature flag tha= t has not been > > > > > > > > > > > > offered to it with VHOST_GET_BACKEND_FEATURES, the = current code will not > > > > > > > > > > > > complain for it. > > > > > > > > > > > > > > > > > > > > > > > > Since there is no specific reason for any parent to= reject that backend > > > > > > > > > > > > feature bit when it has been proposed, let's contro= l it at vdpa frontend > > > > > > > > > > > > level. Future patches may move this control to the = parent driver. > > > > > > > > > > > > > > > > > > > > > > > > Fixes: 967800d2d52e ("vdpa: accept VHOST_BACKEND_F_= ENABLE_AFTER_DRIVER_OK backend feature") > > > > > > > > > > > > Signed-off-by: Eugenio P=C3=A9rez > > > > > > > > > > > > > > > > > > > > > > Please do send v3. And again, I don't want to send "a= fter driver ok" hack > > > > > > > > > > > upstream at all, I merged it in next just to give it = some testing. > > > > > > > > > > > We want RING_ACCESS_AFTER_KICK or some such. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Current devices do not support that semantic. > > > > > > > > > > > > > > > > > > Which devices specifically access the ring after DRIVER_O= K but before > > > > > > > > > a kick? > > > > > > > > > > > > > > > > > > > > > > > > > Previous versions of the QEMU LM series did a spurious kick= to start > > > > > > > > traffic at the LM destination [1]. When it was proposed, th= at spurious > > > > > > > > kick was removed from the series because to check for descr= iptors > > > > > > > > after driver_ok, even without a kick, was considered work o= f the > > > > > > > > parent driver. > > > > > > > > > > > > > > > > I'm ok to go back to this spurious kick, but I'm not sure i= f the hw > > > > > > > > will read the ring before the kick actually. I can ask. > > > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > > [1] https://lists.nongnu.org/archive/html/qemu-devel/2023-0= 1/msg02775.html > > > > > > > > > > > > > > Let's find out. We need to check for ENABLE_AFTER_DRIVER_OK t= oo, no? > > > > > > > > > > > > My understanding is [1] assuming ACCESS_AFTER_KICK. This seems > > > > > > sub-optimal than assuming ENABLE_AFTER_DRIVER_OK. > > > > > > > > > > > > But this reminds me one thing, as the thread is going too long,= I > > > > > > wonder if we simply assume ENABLE_AFTER_DRIVER_OK if RING_RESET= is > > > > > > supported? > > > > > > > > > > > > Thanks > > > > > > > > > > I don't see what does one have to do with another ... > > > > > > > > > > I think with RING_RESET we had another solution, enable rings > > > > > mapping them to a zero page, then reset and re-enable later. > > > > > > > > As discussed before, this seems to have some problems: > > > > > > > > 1) The behaviour is not clarified in the document > > > > 2) zero is a valid IOVA > > > > > > > > > > I think we're not on the same page here. > > > > > > As I understood, rings mapped to a zero page means essentially an > > > avail ring whose avail_idx is always 0, offered to the device instead > > > of the guest's ring. Once all CVQ commands are processed, we use > > > RING_RESET to switch to the right ring, being guest's or SVQ vring. > > > > I get this. This seems more complicated in the destination: shadow vq += ASID? > > So it's something like: > > 1) set all vq ASID to shadow virtqueue > 2) do not add any bufs to data qp (stick 0 as avail index) > 3) start to restore states via cvq > 4) ring_rest for dataqp > 5) set_vq_state for dataqp > 6) re-initialize dataqp address etc > 7) set data QP ASID to guest > 8) set queue_enable > > ? > I think the change of ASID is not needed, as the guest cannot access the device in that timeframe anyway. Moreover, it may require HW support. So steps 1 and 7 are not needed. Apart from that, the process is right. > Thanks > > > > > Thanks > > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > My plan was to convert > > > > > > > > > > it in vp_vdpa if needed, and reuse the current vdpa ops= . Sorry if I > > > > > > > > > > was not explicit enough. > > > > > > > > > > > > > > > > > > > > The only solution I can see to that is to trap & emulat= e in the vdpa > > > > > > > > > > (parent?) driver, as talked in virtio-comment. But that= complicates > > > > > > > > > > the architecture: > > > > > > > > > > * Offer VHOST_BACKEND_F_RING_ACCESS_AFTER_KICK > > > > > > > > > > * Store vq enable state separately, at > > > > > > > > > > vdpa->config->set_vq_ready(true), but not transmit that= enable to hw > > > > > > > > > > * Store the doorbell state separately, but do not confi= gure it to the > > > > > > > > > > device directly. > > > > > > > > > > > > > > > > > > > > But how to recover if the device cannot configure them = at kick time, > > > > > > > > > > for example? > > > > > > > > > > > > > > > > > > > > Maybe we can just fail if the parent driver does not su= pport enabling > > > > > > > > > > the vq after DRIVER_OK? That way no new feature flag is= needed. > > > > > > > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > > > Sent with Fixes: tag pointing to git.kernel.org/pub= /scm/linux/kernel/git/mst > > > > > > > > > > > > commit. Please let me know if I should send a v3 of= [1] instead. > > > > > > > > > > > > > > > > > > > > > > > > [1] https://lore.kernel.org/lkml/20230609121244-mut= t-send-email-mst@kernel.org/T/ > > > > > > > > > > > > --- > > > > > > > > > > > > drivers/vhost/vdpa.c | 7 +++++-- > > > > > > > > > > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/v= dpa.c > > > > > > > > > > > > index e1abf29fed5b..a7e554352351 100644 > > > > > > > > > > > > --- a/drivers/vhost/vdpa.c > > > > > > > > > > > > +++ b/drivers/vhost/vdpa.c > > > > > > > > > > > > @@ -681,18 +681,21 @@ static long vhost_vdpa_unlock= ed_ioctl(struct file *filep, > > > > > > > > > > > > { > > > > > > > > > > > > struct vhost_vdpa *v =3D filep->private_data; > > > > > > > > > > > > struct vhost_dev *d =3D &v->vdev; > > > > > > > > > > > > + const struct vdpa_config_ops *ops =3D v->vdpa= ->config; > > > > > > > > > > > > void __user *argp =3D (void __user *)arg; > > > > > > > > > > > > u64 __user *featurep =3D argp; > > > > > > > > > > > > - u64 features; > > > > > > > > > > > > + u64 features, parent_features =3D 0; > > > > > > > > > > > > long r =3D 0; > > > > > > > > > > > > > > > > > > > > > > > > if (cmd =3D=3D VHOST_SET_BACKEND_FEATURES) { > > > > > > > > > > > > if (copy_from_user(&features, feature= p, sizeof(features))) > > > > > > > > > > > > return -EFAULT; > > > > > > > > > > > > + if (ops->get_backend_features) > > > > > > > > > > > > + parent_features =3D ops->get_= backend_features(v->vdpa); > > > > > > > > > > > > if (features & ~(VHOST_VDPA_BACKEND_F= EATURES | > > > > > > > > > > > > BIT_ULL(VHOST_BACKEN= D_F_SUSPEND) | > > > > > > > > > > > > BIT_ULL(VHOST_BACKEN= D_F_RESUME) | > > > > > > > > > > > > - BIT_ULL(VHOST_BACKEN= D_F_ENABLE_AFTER_DRIVER_OK))) > > > > > > > > > > > > + parent_features)) > > > > > > > > > > > > return -EOPNOTSUPP; > > > > > > > > > > > > if ((features & BIT_ULL(VHOST_BACKEND= _F_SUSPEND)) && > > > > > > > > > > > > !vhost_vdpa_can_suspend(v)) > > > > > > > > > > > > -- > > > > > > > > > > > > 2.39.3 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >