Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <00a04f70-b0d2-2ac8-d03d-93f48c036fed@quicinc.com>
Date:   Thu, 6 Jul 2023 16:33:56 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 1/3] dt-bindings: power: rpmpd: Remove the SoC specific
 entries
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>
CC:     <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
References: <1688635218-23779-1-git-send-email-quic_rohiagar@quicinc.com>
 <1688635218-23779-2-git-send-email-quic_rohiagar@quicinc.com>
 <318ab229-f29f-e6aa-16b8-79fa09013794@linaro.org>
 <b994f92c-331b-ca64-01ec-ec285fb2a76e@quicinc.com>
 <529beea3-3f36-3837-35c4-1efa25d8f1f2@linaro.org>
From:   Rohit Agarwal <quic_rohiagar@quicinc.com>
In-Reply-To: <529beea3-3f36-3837-35c4-1efa25d8f1f2@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/6/2023 4:27 PM, Krzysztof Kozlowski wrote:
> On 06/07/2023 12:53, Rohit Agarwal wrote:
>> On 7/6/2023 4:15 PM, Krzysztof Kozlowski wrote:
>>> On 06/07/2023 11:20, Rohit Agarwal wrote:
>>>> Remove the SoC specific entries and add a generic set of defines
>>>> that can be used by all the SoCs. This will remove the duplicate
>>>> entries among SoCs.
>>>> The arrangement of the defines is done according to the frequency
>>>> used in SoC specific entries in the driver to avoid wastage of
>>>> memory.
>>>>
>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> Please compile kernel with this commit and tell us what is wrong... Even
>>> if bindings were not an ABI, but they are, this would not work.
>> Do you mean that individually this commit would fail compilation?
>> Yes, we would need all the patches together for compilation to be
>> successful.
> Yeah, it is not bisectable.
>
> Another problem is ABI impact, but I think Konrad covered it.

Yes, Thanks

>
> Best regards,
> Krzysztof
>