Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <51090bca-0fe2-7cb5-e5a6-7ce9d41bf506@kernel.org>
Date:   Thu, 6 Jul 2023 13:04:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2 1/2] regulator: dt-bindings: rtq2208: Add Richtek
 RTQ2208 SubPMIC
Content-Language: en-US
To:     Alina Yu <alina_yu@richtek.com>
Cc:     broonie@kernel.org, linux-kernel@vger.kernel.org,
        cy_huang@richtek.com
References: <cover.1688569987.git.alina_yu@richtek.com>
 <341af3996c430549243365bb8204d33a15a482be.1688569987.git.alina_yu@richtek.com>
 <d3308334-aa91-f265-2469-8a6fbc727798@kernel.org>
 <20230706103040.GA32138@linuxcarl2.richtek.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
In-Reply-To: <20230706103040.GA32138@linuxcarl2.richtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06/07/2023 12:30, Alina Yu wrote:
>>> +
>>> +      regulator-state-(mem):
>>
>> That's not a pattern.
>>
> 
> Should I revise that like this ?
> 
> patternProperties:
>   "^regulator-state-mem$":

It's still not a pattern, but a regular property, so keep it in properties.

I don't even understand what you want to say with this. You put it
outside of any regulator. I don't think this was tested at all. :(

> 
> 
>>> +        type: object
>>> +        additionalProperties: true
>>
>> Why?
> 
> Does "additionalProperties: true" mean I need to define my own property ?

No.

> If yes, I misunderstood additionalProperties as properties like "regulator-on-in-suspend" or "regulator-mode".

Please open recent regulator bindings and use them as example.

> 
>>
>>> +        properties:
>>> +          regulator-on-in-suspend: false
>>> +          regulator-mode: false
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - regulators
>>> +
>>> +unevaluatedProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    #include <dt-bindings/interrupt-controller/irq.h>
>>> +    i2c {
>>> +      #address-cells = <1>;
>>> +      #size-cells = <0>;
>>> +
>>> +      rtq2208@10 {
>>
>> Node names should be generic. See also explanation and list of examples
>> in DT specification:
>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>>
> 
> I'll modify the node name to 
> 
> regulator@10


If this is PMIC, then "pmic" as name.

Best regards,
Krzysztof