Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4f8c9bed3fb3ad9cfb64e008eb6a6e96b020200e.camel@kernel.org>
Subject: Re: [PATCH v2 44/92] fat: convert to ctime accessor functions
From:   Jeff Layton <jlayton@kernel.org>
To:     OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc:     Christian Brauner <brauner@kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 06 Jul 2023 07:25:48 -0400
In-Reply-To: <87zg49yfcu.fsf@mail.parknet.co.jp>
References: <20230705185755.579053-1-jlayton@kernel.org>
         <20230705190309.579783-1-jlayton@kernel.org>
         <20230705190309.579783-42-jlayton@kernel.org>
         <87zg49yfcu.fsf@mail.parknet.co.jp>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-07-06 at 10:54 +0900, OGAWA Hirofumi wrote:
> Jeff Layton <jlayton@kernel.org> writes:
>=20
> > @@ -1407,8 +1407,9 @@ static int fat_read_root(struct inode *inode)
> >  	MSDOS_I(inode)->mmu_private =3D inode->i_size;
> > =20
> >  	fat_save_attrs(inode, ATTR_DIR);
> > -	inode->i_mtime.tv_sec =3D inode->i_atime.tv_sec =3D inode->i_ctime.tv=
_sec =3D 0;
> > -	inode->i_mtime.tv_nsec =3D inode->i_atime.tv_nsec =3D inode->i_ctime.=
tv_nsec =3D 0;
> > +	inode->i_mtime.tv_sec =3D inode->i_atime.tv_sec =3D inode_set_ctime(i=
node,
> > +									0, 0).tv_sec;
> > +	inode->i_mtime.tv_nsec =3D inode->i_atime.tv_nsec =3D 0;
>=20
> Maybe, this should simply be
>=20
> 	inode->i_mtime =3D inode->i_atime =3D inode_set_ctime(inode, 0, 0);
>=20

Yes, that would be clearer. Chalk that one up to the automated
coccinelle conversion. I've fixed it in my ctime-next branch.

Thanks!
--=20
Jeff Layton <jlayton@kernel.org>