Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cc4224aa-1304-dd16-7036-4f069958d371@intel.com>
Date:   Thu, 6 Jul 2023 13:51:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH V2 net 0/4] net: fec: fix some issues of ndo_xdp_xmit()
Content-Language: en-US
To:     <wei.fang@nxp.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <ast@kernel.org>, <daniel@iogearbox.net>,
        <hawk@kernel.org>, <john.fastabend@gmail.com>,
        <shenwei.wang@nxp.com>, <xiaoning.wang@nxp.com>,
        <netdev@vger.kernel.org>, <linux-imx@nxp.com>,
        <linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>
References: <20230706081012.2278063-1-wei.fang@nxp.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230706081012.2278063-1-wei.fang@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0l3SHVEc0VQZjFFYWxwV2lmL2FyY1VPZmdVRXlodVhNMFQ3SzhvZDhzbFV5?=
 =?utf-8?B?TTJjSERIdlpEaDBrNTJuK2ZBWkNqTklha3NBUlFoV1h1ZURRT3BiSVpxeEts?=
 =?utf-8?B?TEg5WVhUNzlXRldVcUdFYTZFQ2VYSUtRWnRYK0lET0l2WTNEa3lvdU9wMFVh?=
 =?utf-8?B?bXRuc0l0TmNMakcwaWljV29vblNCdmhkWG9CTFlwS3FOUnNreXFIOUpzN2tW?=
 =?utf-8?B?QTA1bE9BQmtHOW9EREVka0gwaERraDBmbW9CcUhtN1UvTWJzemJPckFnV1Na?=
 =?utf-8?B?c2xRUFMxQ3pJdWZWOUxVcWk5Y1J4djNjNFZoOG5wcXptVGxXSmFwVE9iNXJO?=
 =?utf-8?B?T1ZHS0dDeVg5QTczd3FJcllXY2VVQS9IVE5ZVUVtNmluSllaNXZHQmpFYWE1?=
 =?utf-8?B?bXd0Z0Z5QVV2RlJOYlNuaE1RU0ZCaEdrUDRxKzZFWTMvY1lBVEpXc3R3M3Vs?=
 =?utf-8?B?OExRdkQycUt5bURZRjRMN0ZxN2lFanVKN3FhU1FOWVp1OXRwelpEeEhLVEd2?=
 =?utf-8?B?MVptRWNyN0dhajJ2SzFCRnczbFVuaEV4cTFiZDZtVTFnbU5WakYvSjNlbnRW?=
 =?utf-8?B?REM5RTdFUGd6dTZVczhGSjJ0c3RWTmhLNmtOVy9ESWl3aU1OVjZoY3Y2S2gx?=
 =?utf-8?B?cmpHaXIzdkFDVXZpL3hSd0dLZDAwaitKZXk4SFM0US9JRzlIeEpwVGpiUUJV?=
 =?utf-8?B?WVBJZkhoNzI0Sm9qbjkvZTY1V0J3OW1oMkpycjY0ajBpVCtEQzdkeHA0ZHQv?=
 =?utf-8?B?V0Zzb1BqTFp2UndaeWw3bXV5QU9scE54WXIxMWFYOHRpT1dlbFBNQ0x4M2U3?=
 =?utf-8?B?MXpSTmFIVzVGbTRFVzFxWW9sTlhvRjd3ai9PVzlRT053ZE9sbGR3UGRxWjBy?=
 =?utf-8?B?UjgxLytpcGNyVmZNN0ZBVk8yclhqLzI3eXNvRWVnN0hTVGFCV2QzcnhtU3Iz?=
 =?utf-8?B?K2RhZHFGNjNUNFdLaTc0K0V0ZzVBeXBITTB3dlRtdmczRjlSV1FlTUZ4bWtt?=
 =?utf-8?B?K09PamJjRkc3cGRkUmFWL2NUQUN5RlF0UERzakhhTFAyY0VlcWREVzNiVlEx?=
 =?utf-8?B?V0dFcVVYOXBaTFJVdWZGU0tXdTNrWjVMc0syQUY2UUpLVUpDQnY5WE1RNUhz?=
 =?utf-8?B?L3dxNVVHbllWNTBiZ2tpMytXTU9PWnBwODFadE1lK1hZYlQ5SXFyeHBwRTF0?=
 =?utf-8?B?d1FsREcrQ1U5VVpDMXYrOXlneDByMVNuWDhNRm03R2d3V2hCNVRuclk3MWZQ?=
 =?utf-8?B?WXMxN2gvZm1Bdmx0WHZpcXFCN1NZMXNRUUZxekpEUHNubVdIWEtJdmFDMTJQ?=
 =?utf-8?B?MWlVbWtOcUFIanhmb3pPYkQxeEJDaC9NT1lsUlZRazAvL1dLOE43SDNGeGVW?=
 =?utf-8?B?b25MNzlrZHFhU2kzL2tnTzVzQTVFRlFTdmM3Qkh0TFAxVk5JaEtCZjVCNXNz?=
 =?utf-8?B?RlppMmxIOVl3UGVyVDVPV1Z0dnNTaHhhKzJSSlRJNFpMNk5OemN2RjgvOEdG?=
 =?utf-8?B?NU9iNU1iWmdmQXJreFFkbzBXZ0NENFVUS1Z1UmI1c1dxakJTcjBhSlJMYm5z?=
 =?utf-8?B?ODN5RlNucGlmR3FudWlEd1FRWmhBZ1FjSjM0RTlJOFhxem1ZSGNyOXFNNWxp?=
 =?utf-8?B?QS9TOFVlVzFiZ3ByZm8rTU4rT3I3K0VKMEZRSVQrbEdVN0pVMUlpM0ZnSGVH?=
 =?utf-8?B?bDhCVklmdUVoQWE4OGZDOTNNMTRxaW4zMTVJaWRCanRYd3ZYamRZaTd3TG4v?=
 =?utf-8?B?ejNvS1p6ODFVQVc0ZzgzUXBJNG9Ucmo3S3A0bHEzRCt3em5BNGlzVDhVY2V0?=
 =?utf-8?B?R3VDanp4Um1OTFdYbWxFWWF3WDBZanh4alFocTZGTzhndjFJT3ZVTit5Zkwv?=
 =?utf-8?B?UjZCenlubnlZczVEMUpWWkRkR0hXQWNkYW95VWlUWjRrc256ajI4MFFFaXVY?=
 =?utf-8?B?MGhFOTVOUkZYU2dSUnMvSkdhVTVGTks4VS9hNUViQUs5SU41TFp3ZHZQMzdv?=
 =?utf-8?B?NkJ4YUx3M1VHbjFWcnRxbU5pSW1Bc3ZnQ1FYUXhFWGNwN2xMQ2ZWa0VtRDc5?=
 =?utf-8?B?cGYvKzlKdVdKbWlIZWJkenBBelRKNGJhOVYvTkFMM0dvT01ZVmlnYlVKbVl0?=
 =?utf-8?B?ZjBraG9saUJ1cGkwUHIwUXEvdUFGczI2ZjBLbFNuLzAwTnN5SVViWGxUWHU2?=
 =?utf-8?B?Nmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bbad4dd-e215-4435-d427-08db7e1786b2
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2023 11:52:51.4381
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wyqlip2BCR3kA7LRMWLoaHvh40Ae0oR0B3fhpSxuBBTSvMLGdvtcOyITMDlGTkdds0s3iWYywznD92wufKnxSpzC1UM5uM65uSxakMyDiQA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8101
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wei Fang <wei.fang@nxp.com>
Date: Thu,  6 Jul 2023 16:10:08 +0800

> From: Wei Fang <wei.fang@nxp.com>

Please sync your Git commit author settings wrt Git email settings, so
that there wouldn't be "From:" for your own commits.

> 
> We encountered some issues when testing the ndo_xdp_xmit() interface
> of the fec driver on i.MX8MP and i.MX93 platforms. These issues are
> easy to reproduce, and the specific reproduction steps are as follows.
> 
> step1: The ethernet port of a board (board A) is connected to the EQOS
> port of i.MX8MP/i.MX93, and the FEC port of i.MX8MP/i.MX93 is connected
> to another ethernet port, such as a switch port.
> 
> step2: Board A uses the pktgen_sample03_burst_single_flow.sh to generate
> and send packets to i.MX8MP/i.MX93. The command is shown below.
> ./pktgen_sample03_burst_single_flow.sh -i eth0 -d 192.168.6.8 -m \
> 56:bf:0d:68:b0:9e -s 1500
> 
> step3: i.MX8MP/i.MX93 use the xdp_redirect bfp program to redirect the
> XDP frames from EQOS port to FEC port. The command is shown below.
> ./xdp_redirect eth1 eth0
> 
> After a few moments, the warning or error logs will be printed in the
> console, for more details, please refer to the commit message of each
> patch.
> 
> Wei Fang (4):
>   net: fec: dynamically set the NETDEV_XDP_ACT_NDO_XMIT feature of XDP
>   net: fec: recycle pages for transmitted XDP frames
>   net: fec: increase the size of tx ring and update tx_wake_threshold
>   net: fec: use netdev_err_once() instead of netdev_err()
> 
>  drivers/net/ethernet/freescale/fec.h      |  17 ++-
>  drivers/net/ethernet/freescale/fec_main.c | 166 +++++++++++++++-------
>  2 files changed, 127 insertions(+), 56 deletions(-)
Thanks,
Olek