Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7df8d76c-e177-b06c-20e4-e6aacbea6471@intel.com>
Date:   Thu, 6 Jul 2023 13:59:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH V2 net 2/4] net: fec: recycle pages for transmitted XDP
 frames
Content-Language: en-US
To:     <wei.fang@nxp.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <ast@kernel.org>, <daniel@iogearbox.net>,
        <hawk@kernel.org>, <john.fastabend@gmail.com>,
        <shenwei.wang@nxp.com>, <xiaoning.wang@nxp.com>,
        <netdev@vger.kernel.org>, <linux-imx@nxp.com>,
        <linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>
References: <20230706081012.2278063-1-wei.fang@nxp.com>
 <20230706081012.2278063-3-wei.fang@nxp.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230706081012.2278063-3-wei.fang@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzlhTk5xeldQQWJnaEhQWEs4Q0ExTHVFNnhYamMxZTlacG9ZTlFQQTMvTHJn?=
 =?utf-8?B?N1R1L1RNSlo1TzJiR0t3TkthWDdhN1NQSm9zTGQxYXA3ajc5Z0hpYldwZzVU?=
 =?utf-8?B?TU5yeU4vLzBncEhXUGdZb3I2a0wxZWZ5U3FDZ200aW5KTFhwSmsvV2RzaEYy?=
 =?utf-8?B?dmhLUmoxek5SZnhHZXNkbGI3dnhDRnlhSFpSYzlpbUF6d2JCc2duV2thTys2?=
 =?utf-8?B?U3BXeE12QXVSS09uZlZ0dno5dG1Kb3RURklNVjhocFNscUthRlU4WjRnVDhn?=
 =?utf-8?B?VFpWNlE2RTJQcGFOTkVaTTZUcXNDQXJYSWJZeGV1OVZSR0FiOXovc3hNdkgr?=
 =?utf-8?B?MFRWTkV1RHpyVThIWGVFTVhoRHEwMnVmd2o0dklXYnhYeTc1Rm1jbm1VTCtr?=
 =?utf-8?B?MkxuSE5XdkxXWHFMb0Z4YWs3SnhnSXY0UExzbEhxZUhXd1NyQkU5bGc3bjFq?=
 =?utf-8?B?UGtXN2NRRUFpOFFBNFdKNi85SjI3YzMwMzhtVUlvRDZEczBRanVobXVpcVIz?=
 =?utf-8?B?SStnbTFGYnZabGttT0dRYXJzc3dKM3lUTTlLcEdpNitpTC9nNlMwTkk4OHE5?=
 =?utf-8?B?NXlFZWtXcTNiTDVsSHcwSlNJdmRMU2V4Y1dDbWdhWUV5ZWxTVTdHdHJzWE1m?=
 =?utf-8?B?cFdZWEV6Y3VLcE5ycWkyS2Vma2lMTkJISUE2UmEvRVNDSzREb3ZreS92eHE3?=
 =?utf-8?B?M3NtZkJBMmh5YUd0bXJvODczY1RXYk1xS3laS0JUMysyOFByNFlhcnRSOWdJ?=
 =?utf-8?B?bkU2b3NPMjhCUlBPa01JQWc1OExYc2tSTk1pU2ovYzNKVzFwaG5YbmRkYTZM?=
 =?utf-8?B?ZUZJakVhRWtEUDg4cHVGQzRtSW9VOUFrMldVUDVJU2ZXdnFtbTVLNTdMN1FE?=
 =?utf-8?B?UGpIbldacDhYNmZMbWhPNlE0WFhrUEg3OHBmS3RiWXdFbVZmMzNHUVdjQ0tE?=
 =?utf-8?B?OXRzTUYrTHpTTFJvVnIyK0xmVWRKZGxTdnlLK3NxWjdwN2g3OUszWE1saktY?=
 =?utf-8?B?ZXFTbnNCdHhUZTREeTJ1RjFOU0lSQW05TVN6bEUycWZUN21TbmpmSk5XSE52?=
 =?utf-8?B?dFBncEVoQWhXcDlyMUl3ejQ4dTczTjI4WXBTMENBSTNFMkpSeG91YUhWZXUx?=
 =?utf-8?B?YWZvT0lSdGZ5UjNlS0ZXRy9CS0luOUxJTThYQ085WXozcWlEWUxweTZtRHJD?=
 =?utf-8?B?OS81MnRXTDh6UXIxcmc1VDhJVHl2ZkU3ZlBUek9ZUGZvaDBKL0JFblBDK0Zx?=
 =?utf-8?B?THQ1S3NQTC9JcmNmdHpGeWFWQ0F4UjJYTTdFMllKTGhSOThHQ2xJZUNWelVT?=
 =?utf-8?B?NmZOc3FTOFk4VHRoSjRZY0hjUW13NCtpVUYxM09VMk56dFJvMDhDWGxzSFY4?=
 =?utf-8?B?SFY5R3QrNUtPUFpmSmE4aHFLcFkvUDR6a01kRi9zSGZSUzZEUjE3VXYvemxv?=
 =?utf-8?B?ZTRZbU1tODhuNmkrMTlBUG5GQUkwKzkvaGNSOXBrSkZ6R0tETmZKNzdhSEtz?=
 =?utf-8?B?NWVZNkVCNThRQkZGVHpyOTVDTzB5RDJid1FzZ085c0k4SUkvSDhzckhSWTVl?=
 =?utf-8?B?MXU2NFpqL1Bza2pnMkRndnFhWFRnNXQ5K051MXpLMkUzb3NCUzlUcmVaWUIw?=
 =?utf-8?B?Yi9DaVU4a0NIUHJuWEFkSnNlRDRvNXArR2xDazBJV1YxaGE3MWl1akZkTVlS?=
 =?utf-8?B?L1k5RzBwbGJFUFFKbis5Vkk0NXlERTcxN2R1d3V2c202NnVVOFg3ZzhqWUFR?=
 =?utf-8?B?SG9OTURPNkloNlNkVkJzVGwrNzloRjZPem5mYzBvRWg4SWlLSnQvOC9QT1Zk?=
 =?utf-8?B?Rkd2WklxM3g5djAwSVl4aGptcm5QS3dWK1pLTkN3ODJzcFFnNytpVlA5aXFG?=
 =?utf-8?B?UzROUzdYZUFKRjNCcE1DTFdYS052V0xwTi9NUjhnSjhFUjM5V0dQQWl0ZWJ0?=
 =?utf-8?B?aUtmZ3JqWUtLNTVFQWVtUkdXSUtFU3Z0cDBqQVJjTHJiRkVYZ2pOUWdCN0ho?=
 =?utf-8?B?M0FrQ0lVZWVlejBMM2dReGFjSUF4WFFQZkpmeXRGaU9seTNVWW1PU1FPL0hH?=
 =?utf-8?B?STVpNmlQTUZRbjZnL1h4T01IRFdicjcvZWQ0ZkxpbnBPUnNsQ1lJMUxDbkFk?=
 =?utf-8?B?NHZaYzJaY3R2UkFrWWlGOFByZUViTkRrNkY3aitETzRmZGw4L2xMQlNqVXhN?=
 =?utf-8?B?c3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 09db7053-9f1f-41bc-73e5-08db7e18a1d1
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2023 12:00:46.4267
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CHJbEm4Mbk2YlZsYE+KBs4crQklWSJaGN+72ZHFoEeDERVOcerNVhMvTBMTk+GwDKBN3dzpdeAYtFl2+AJriSyp6eRJW5YR0Pr+mA2KpNUk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5655
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wei Fang <wei.fang@nxp.com>
Date: Thu,  6 Jul 2023 16:10:10 +0800

> From: Wei Fang <wei.fang@nxp.com>
> 
> Once the XDP frames have been successfully transmitted through the
> ndo_xdp_xmit() interface, it's the driver responsibility to free
> the frames so that the page_pool can recycle the pages and reuse
> them. However, this action is not implemented in the fec driver.
> This leads to a user-visible problem that the console will print
> the following warning log.

[...]

> +				if (txq->tx_buf[i].xdp) {
> +					xdp_return_frame(txq->tx_buf[i].xdp);
> +					txq->tx_buf[i].xdp = NULL;
> +				}
> +
> +				/* restore default tx buffer type: FEC_TXBUF_T_SKB */
> +				txq->tx_buf[i].type = FEC_TXBUF_T_SKB;

Here and in the related places below: maybe set ::type dynamically when
sending to either SKB or XDP instead of setting it only for XDP and then
restoring each time?

>  			}
> +
>  			bdp->cbd_bufaddr = cpu_to_fec32(0);
>  			bdp = fec_enet_get_nextdesc(bdp, &txq->bd);
>  		}
[...]

Thanks,
Olek