Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b1cc6c70a42bf41d023eea9f11ff0aaea10a56c3.camel@kernel.org>
Subject: Re: [PATCH v2 39/92] erofs: convert to ctime accessor functions
From:   Jeff Layton <jlayton@kernel.org>
To:     Jan Kara <jack@suse.cz>
Cc:     Christian Brauner <brauner@kernel.org>,
        Gao Xiang <xiang@kernel.org>, Chao Yu <chao@kernel.org>,
        Yue Hu <huyue2@coolpad.com>,
        Jeffle Xu <jefflexu@linux.alibaba.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-erofs@lists.ozlabs.org
Date:   Thu, 06 Jul 2023 07:53:01 -0400
In-Reply-To: <20230706110007.dc4tpyt5e6wxi5pt@quack3>
References: <20230705185755.579053-1-jlayton@kernel.org>
         <20230705190309.579783-1-jlayton@kernel.org>
         <20230705190309.579783-37-jlayton@kernel.org>
         <20230706110007.dc4tpyt5e6wxi5pt@quack3>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-07-06 at 13:00 +0200, Jan Kara wrote:
> On Wed 05-07-23 15:01:04, Jeff Layton wrote:
> > In later patches, we're going to change how the inode's ctime field is
> > used. Switch to using accessor functions instead of raw accesses of
> > inode->i_ctime.
> >=20
> > Acked-by: Gao Xiang <xiang@kernel.org>
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
>=20
> Just one nit below:
>=20
> > @@ -176,10 +175,10 @@ static void *erofs_read_inode(struct erofs_buf *b=
uf,
> >  		vi->chunkbits =3D sb->s_blocksize_bits +
> >  			(vi->chunkformat & EROFS_CHUNK_FORMAT_BLKBITS_MASK);
> >  	}
> > -	inode->i_mtime.tv_sec =3D inode->i_ctime.tv_sec;
> > -	inode->i_atime.tv_sec =3D inode->i_ctime.tv_sec;
> > -	inode->i_mtime.tv_nsec =3D inode->i_ctime.tv_nsec;
> > -	inode->i_atime.tv_nsec =3D inode->i_ctime.tv_nsec;
> > +	inode->i_mtime.tv_sec =3D inode_get_ctime(inode).tv_sec;
> > +	inode->i_atime.tv_sec =3D inode_get_ctime(inode).tv_sec;
> > +	inode->i_mtime.tv_nsec =3D inode_get_ctime(inode).tv_nsec;
> > +	inode->i_atime.tv_nsec =3D inode_get_ctime(inode).tv_nsec;
>=20
> Isn't this just longer way to write:
>=20
> 	inode->i_atime =3D inode->i_mtime =3D inode_get_ctime(inode);
>=20
> ?
>=20
> 								Honza

Yes. Chalk that one up to coccinelle. Fixed in my tree.
--=20
Jeff Layton <jlayton@kernel.org>