Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b3113f37-0e4d-a987-ce3d-56fabdb802c0@intel.com>
Date:   Thu, 6 Jul 2023 14:29:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
Subject: Re: [PATCH 1/4] net: emaclite: Use
 devm_platform_get_and_ioremap_resource()
To:     Yangtao Li <frank.li@vivo.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Michal Simek <michal.simek@amd.com>, <netdev@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20230706120850.11026-1-frank.li@vivo.com>
Content-Language: en-US
In-Reply-To: <20230706120850.11026-1-frank.li@vivo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjZiK2ZrSmY2dDk3ZzZjS1QyY3ZheitsaUdvZEY2NWEzSnhUZXR2Y0lsaW1m?=
 =?utf-8?B?S01sWDVySTBXaXpGcGIxRmY5bFpJTGUwd2R1ODYwTnBwTGJXak1CQmtYblBM?=
 =?utf-8?B?QVF2d2NTeDJqUkpHT0lnaHpIbEpyaHpDM1c2VGR4cTRiakNGQ2JGWEtXbE9D?=
 =?utf-8?B?bXBtNmtVRVo5OUdBbXNrTnB0VDZmQ0NPMlBjNTlVcFVLaEJMeExBUVQ0V0x6?=
 =?utf-8?B?cGpWZVplODVyc3V1STVod21LZStCeEQyV1JsdWZJQjBma1lZaThDVG1XbVB4?=
 =?utf-8?B?aXZhRTZJSUlabkxIQXVLTUJGYlFWKzh1eFowZUk2NEVzSTdyZUVLVHVEMFBM?=
 =?utf-8?B?NllZNEJDL0xwbWZPS0laQ0tFTS9yOFYyc1VUeHhDbEJVSTEzZmlMZjhNdTYx?=
 =?utf-8?B?RFpMNGg5SXkyQ1ZRTUk2WTlqTTdYcU1BaXdISmN6TGlwbU05L1hWVHVack02?=
 =?utf-8?B?bkV4OFVCZm5lRlVBbkgzWHJYMFpWT0Z5NXppNThKQTEyaEJpQ0tlVHN4SGRE?=
 =?utf-8?B?bXNtam1qR1o4aFUrSkhtQzVjaEZscDFIR2VERkhvQXRNdzk4STdEaVdwajFJ?=
 =?utf-8?B?NThwNkRYQ2N5S0Z0a21OSG9GVFNIbVBZdGdFVlJGNWhuL0I1OGRzYUdIbWo4?=
 =?utf-8?B?QWJpWW16L1loRWZtMlZsc0Q3QmlOL2pTL2JEZ0VhZnBlbzh0eEh5NExJdDJp?=
 =?utf-8?B?cE1GbFQ3ZHM2TFhQcjFNc3ozVWJvbFhQK3J1T0JQUWxraUhkRVhGSG4ra0xp?=
 =?utf-8?B?dWdNRGNyelg5S3crU29IK092cUY0blFWc3kybGJrUmpob0FKMFVnNm1iUm81?=
 =?utf-8?B?bXRnZUxDSUptUHM3R1lZZGJMd3ZMSFpZVnpiV3lva2dJbC9HY09wQWVsaEtR?=
 =?utf-8?B?YWlFVCtEQzNlUElCbmc5bW9GbnNXNEtHcytVZGdTallJcWcrTzRpZmYzVHUv?=
 =?utf-8?B?MG9WRkR1OGROS1Y3STF0eTRYY0Fqa2s4YndZcHdCU3grUzhjTFBiQzEzYTBy?=
 =?utf-8?B?dWNJQU1ZVE96L3BtUGluRnZqdlQzS2FpQXpIT29uK2hwbFRXekpSZVVlaDQz?=
 =?utf-8?B?OExzZzhXMVU1ZkY3NXQ2Q1prdjY2VThGK0ZCY2xNcWxlUGpEZjJrN3JLRUpW?=
 =?utf-8?B?Mkp4VHhxNUhGb3Z2V1pvRzRBeU5JbHhhcCt0QUIwV2lkOEU2OWVUWHdhQmpP?=
 =?utf-8?B?U0FPM3RjTFdzL2lBb1lGZHR3ZjUvaURuWEhJT1ZQSmVONXhvc0NNZUlUcWRL?=
 =?utf-8?B?b0kxQXpiUFdCbHNRSmMwbThEL3VrcnI3Nmg1eG5BczRkYy9BNGVLcnhldVho?=
 =?utf-8?B?dmhKUDF1QTdhWW1wc3Q2Z2JYQzE3NW5yazFvOXhxY0QvWVBidERldVl0SlJL?=
 =?utf-8?B?ZzNWYlViZXdtaFN2aGd5L05uUnBYcTN4bk54Z1o3T0gwWTNMczJBZXNaZkdo?=
 =?utf-8?B?S0l3WmZvYmZ5aW5rL3VkZ3lNRUFVOUdIcDdZTFJXbVBhTTBOU3pXbU41TTU2?=
 =?utf-8?B?Zi84c3J2VDdTRlBtL2Z3UHRGYkd2TmtwZGwxWERIa3drMGt0WXlSZ1ZZRlpP?=
 =?utf-8?B?eGdOckxwTTFxanB5ckxPMUFnU0NrQ0VYclBrYTVHVEx4WEpBRWNKT0dRRWl4?=
 =?utf-8?B?dEY4Tm1XT0pubmJsYWptZzA5M1BrUnVBNlFYTEx6SFliaGFtblBoY21RUFNu?=
 =?utf-8?B?UVlvRERmK0ZRa0VOMXUyK0VPbUsxN3VjT0VIdFd0MVJaYU9ESU16dDhEQ2ZW?=
 =?utf-8?B?VFBxaHZXblNCZ2Z5MkhSRTR1ZGVuRlRpL1Uzaklwc0piWE5lcUJmNWkxOVVE?=
 =?utf-8?B?L05mNXdhQXQraUZlWm9sWVpWcGwxVE1pUnhnRm5iRXFab0NyOG04WkxXZlNZ?=
 =?utf-8?B?RS9leUJTTUErV3p3T3YxQ09XZ3lIYkU5WGxRRlh4VXoxZjNVK3lRcGFBQ3R5?=
 =?utf-8?B?LzBJL0k0UEhXWFZ5R0s0Y0FVUnZGTE95WitjVWVXeFdnRlIzK0xvT1IxVTJz?=
 =?utf-8?B?YTNpWDAzMW9DQ1hCVy91QXFiVkNrVy9BTVZaQjdoNE9vUHhOM0czeDZvOWpw?=
 =?utf-8?B?TUw5UDlleE5EdkJKVWYvQy9vYXNYNXpDeHRRaXJVbThSb0ltME5QTTM3aDFl?=
 =?utf-8?B?a2pMUFlBcnk4WkpxMEpSYjF6ZXlsRDJyd1FsaXFRTEdwcy9xcU56dFNqejFY?=
 =?utf-8?B?YXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9697cb53-f59e-498b-50d5-08db7e1cd439
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2023 12:30:49.2816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F94sGH95ZT7r4SThvl124oHYzY7wifvmjYX8HDse+NLO4PCdzBJUkvI5WMHagURZVPY3bBTHSldJUqjR0RXMSgGVIpGjMGWzO4MDCvGskdg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8555
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Yangtao Li <frank.li@vivo.com>
Date: Thu,  6 Jul 2023 20:08:47 +0800

> [PATCH 1/4] net: emaclite: Use devm_platform_get_and_ioremap_resource()

Please clearly specify the target tree (net or net-next) in the subject
prefix. Since your series is cleanups, it should be "PATCH net-next".

> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>  drivers/net/ethernet/xilinx/xilinx_emaclite.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> index ad2c30d9a482..3cba947e4cbd 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> @@ -1114,8 +1114,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
>  
>  	ndev->irq = rc;
>  
> -	res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
> -	lp->base_addr = devm_ioremap_resource(&ofdev->dev, res);
> +	lp->base_addr = devm_platform_get_and_ioremap_resource(ofdev, 0, &res);
>  	if (IS_ERR(lp->base_addr)) {
>  		rc = PTR_ERR(lp->base_addr);
>  		goto error;

Thanks,
Olek