Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Jul 2023 13:33:40 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Lee Jones <lee@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Benjamin Gray <bgray@linux.ibm.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] regmap: Replace "default y if" by select
Message-ID: <a170939b-ee15-4241-ac07-bfa341a56bbe@sirena.org.uk>
References: <cover.1688643442.git.geert@linux-m68k.org>
 <525c37a568b10623ffb2d108850afd7e37f9350e.1688643442.git.geert@linux-m68k.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="8w2QbIDms0NhgMtB"
Content-Disposition: inline
In-Reply-To: <525c37a568b10623ffb2d108850afd7e37f9350e.1688643442.git.geert@linux-m68k.org>
Precedence: bulk


--8w2QbIDms0NhgMtB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 06, 2023 at 01:42:02PM +0200, Geert Uytterhoeven wrote:

> Merely setting the default to enabled is no guarantee that a Kconfig
> option is actually enabled.  While this works for an invisible option,
> the user can still disable it manually if the option is visible.
> Hence since the REGMAP option was made visible if KUNIT_ALL_TESTS is
> enabled, the user can now manually disable REGMAP, causing build
> failures if any of the REGMAP_* configuration options are enabled.
>=20
> Fix this by replacing "default y if ..." by individual "select REGMAP"
> statements for all users.

I already have a separate patch which will go after the merge window
that will move the KUnit visible option to a separate Kconfig since the
current bodge to work around your desire to not have KUnit enable
anything automatically had really substantial usability issues anyway.

I'm getting fed up with all the problems that these KUNIT_ALL_TESTS
issues TBH, the inital patch here seriously damaged the usability.

--8w2QbIDms0NhgMtB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSmtKAACgkQJNaLcl1U
h9BgDwf/bxvria0yTNlFgcVB47sqjg89/9bKKZ4Z60b9HloA1Ex3l68CaUxnphFt
1BUIy+pcsYDj1ph5LfEPQCHTemXXgdVbfbUrWOzuD65KY1Bbmg7MVxhdODDf27UI
RFGIRtKTgQQqDjJxbmbJ9j7nEp+zd+q5M7caDVioLGPk+kkll6SL+79blhqrAqUb
KSjlJOQnFIqe32/IIvviffVEIJU2RvVPNvup83qdeGUVRdvaSzsVOubOgGJUOY3p
60fQaYz1ejTBpOwNicfFsvGGRGzgK47V/i2Yh8IB8dJ1LaqU+L+l4t0Spmw6qq3N
Wlin1nMDR3ppHaJtZVCDELCSq2YPmQ==
=iv0q
-----END PGP SIGNATURE-----

--8w2QbIDms0NhgMtB--