Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp30423050rwd; Thu, 6 Jul 2023 05:52:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlHR0mjL1cvJhy3d4h1Pd3pIIGfhF8qdiT+8HbLmxI30L/0wUnhzNgC015gr24TV9SqASWMT X-Received: by 2002:a05:6870:a454:b0:1b0:289d:40fc with SMTP id n20-20020a056870a45400b001b0289d40fcmr2240821oal.28.1688647973206; Thu, 06 Jul 2023 05:52:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688647973; cv=none; d=google.com; s=arc-20160816; b=hhY/Ou4VB6fJlVhPD/tV8SCrEHGgi2cTsaV70Wg1OpXQY8lLp/laHLup/eA0KOHydL lzHDlilHN/vK/vYIUzL0/QV1FjqWP2SRwh+Tg7EGwphe8k4DEdepA44PlE332iJWrYQI MJe0H0tsL9UQa4ytsZnmzaudQAP1yyYy7mg+LS2WtGddbNjHM6m7ShjqzI7Dkjbe4PSI W4eyUmOXwWkx+aBstCZyYvElp1r4bwhOnA3KBMuIBE9IhNiB2vsqOeAABwLB8eZdqC5z B/m2fL2VOqktEwh/VVuQonDjThUVILDUS79svJUT8x1KI7tyNtMwJZw9QmNNJMtY9nco N4Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=UnBlUw6qtrfLhPWtBACs12VnsqaxxxmPTeeEsJGwpC4=; fh=gm6iZp70GHTfOjAGnQV2hPOeTvXxlsM4ixM5PXtK9cU=; b=aA9M0d+6753Hd9NUfneGmlD8OO0RxsZhOWUX2ffA/u/e0DbTt+tCbUSppLZjjDxji2 CKSB0oqsUYJ7lbqJHUmOW40T5ldKLkHtzRT2zzAI3GvCORBmYVIsA5ZOFb08G11avJ3a r1yfZs/TvoWEvdgScM8BL3klafGzxUgOpWjIYj0YhkfeiUuH7f7m5QQlYROvHz4UECDI AnjSDVb37sQBXqtkiRgduQ3jCmpmMrZ/O5cbRd47F8jUTEXbCQF4kV79xwqOOqz7ooSF wLXphU7VCxNRlFYy8iV2PUA779ZC7BHxOuwCsHrxc5r1fLiFn7VS4k7kLBQ1a841TaIF ta4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k17-20020a63ff11000000b00548e140a1a6si1254455pgi.66.2023.07.06.05.52.40; Thu, 06 Jul 2023 05:52:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232366AbjGFMsK (ORCPT + 99 others); Thu, 6 Jul 2023 08:48:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232194AbjGFMsD (ORCPT ); Thu, 6 Jul 2023 08:48:03 -0400 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EFE9B1FCC for ; Thu, 6 Jul 2023 05:47:35 -0700 (PDT) Received: from loongson.cn (unknown [10.20.42.43]) by gateway (Coremail) with SMTP id _____8CxruvOt6ZkevMAAA--.1057S3; Thu, 06 Jul 2023 20:47:10 +0800 (CST) Received: from [10.20.42.43] (unknown [10.20.42.43]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxriPNt6Zk_dseAA--.51437S3; Thu, 06 Jul 2023 20:47:09 +0800 (CST) Message-ID: <593c7547-02ad-da80-24d5-dd4a670c8cdd@loongson.cn> Date: Thu, 6 Jul 2023 20:47:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail Content-Language: en-US To: Alexandre Mergnat , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , AngeloGioacchino Del Regno Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongson-kernel@lists.loongnix.cn References: <20230626185801.684451-1-suijingfeng@loongson.cn> <4f493bc2-45b3-13b8-f1b1-1729a803c74c@baylibre.com> From: suijingfeng In-Reply-To: <4f493bc2-45b3-13b8-f1b1-1729a803c74c@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf8CxriPNt6Zk_dseAA--.51437S3 X-CM-SenderInfo: xvxlyxpqjiv03j6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29K BjDU0xBIdaVrnRJUUUmYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26c xKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vE j48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxV AFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x02 67AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6x ACxx1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1q6rW5McIj6I8E 87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0V AS07AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCF54CYxVAaw2AFwI0_JF0_Jw1l4c8EcI0E c7CjxVAaw2AFwI0_Jw0_GFyl4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1l4IxYO2xFxVAFwI0_GF v_Wrylx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY 17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Gr0_Xr1lIxAIcV C0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY 6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa 73UjIFyTuYvjxUcCD7UUUUU X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, thanks a lot! On 2023/7/6 20:13, Alexandre Mergnat wrote: > > > On 26/06/2023 20:58, Sui Jingfeng wrote: >> Also return -ENOMEM if such a failure happens, the implement should take >> responsibility for the error handling. > > Reviewed-by: Alexandre Mergnat >