Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp30445559rwd; Thu, 6 Jul 2023 06:08:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlGj3NxYzdVTAczp3skMoe4Y5dNxwdZHOXyzxgeNMkNGz45dnvPUMnoLlLMBCQUfS4A2ViU7 X-Received: by 2002:a17:90a:5510:b0:262:ceaa:1720 with SMTP id b16-20020a17090a551000b00262ceaa1720mr1254296pji.5.1688648935263; Thu, 06 Jul 2023 06:08:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688648935; cv=none; d=google.com; s=arc-20160816; b=U+z8I6QQE1VlKE0KNfwYtbJZsLjSD9jjWZlA3iKzl+QKggpuErjOKJbca9dpIEElAj H5csJwPaTedQO+OKcnYMxypa09lJ0pNoyhIwbIfnw+WSS04+1cJm5t4pTrFjUqYnoEq4 94E7faYYGs19ThBvChTjjIhw5rF0wcGai/Nki9/6LC4jdPv9XRmjSei/5EoZu+fWa0Hw pPdiVgXIWmSXRTn8hk2NmxAsL8qWNmjCk5+5bHilTKu4yOaog2AvG7eWyw4beEpEkC3c OJ5qwYAw/xZFeOaeRUzCoaZaMDkilqDIkGKY8xX6KxPa6CeN3pxEuocAGd5Yc3JcHb7Q 6A0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=uh2BrzR5+3JSMu6XjQ5eqJ5gD3EobUKCn3+nAJuqqS8=; fh=JCth2B8X1QWSZw42VgYA7wCwA7mO/h/y4o1kpt48VfQ=; b=FUsWl2qo/ZphfmcYEfTaWRRi6wlzgRrBpn7KEpHfp6eUkFQxPu2GCnMWU195Y/n35e kLvntvRbZXVq5spuBWVDHrAdfXJzj+GvhTZj7+cy/FrPJyxNknv682qh0JI+4r2/yfAV 72Is4rhnKKZKGw3AiQisvMCuzsy33kGdVEkRmoNDOE+iZD3mtNp2IDgXn1UptSSSlSLX HXiJuH/5WmhyPW5LfVX28KU9xdqV6ef2SDHfp00jgDeMPDdagdUP9qw5fC+cCEUFPHhy QGruj/TDWm6rZxjdxCUjn6qIcL+c7icZTatq1d7rUcViFekDsos66JEQHghA4msOQ70G z+Yg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bv9-20020a632e09000000b0055acc92299esi1340213pgb.240.2023.07.06.06.08.40; Thu, 06 Jul 2023 06:08:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230443AbjGFMx2 (ORCPT + 99 others); Thu, 6 Jul 2023 08:53:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232700AbjGFMxQ (ORCPT ); Thu, 6 Jul 2023 08:53:16 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A6A51BF9; Thu, 6 Jul 2023 05:52:56 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 481A167373; Thu, 6 Jul 2023 14:52:53 +0200 (CEST) Date: Thu, 6 Jul 2023 14:52:53 +0200 From: Christoph Hellwig To: Yu Kuai Cc: mhartmay@linux.ibm.com, bblock@linux.ibm.com, bvanassche@acm.org, hch@lst.de, axboe@kernel.dk, yukuai3@huawei.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi/sg: fix checking return value of blk_get_queue() Message-ID: <20230706125253.GA12842@lst.de> References: <20230705024001.177585-1-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705024001.177585-1-yukuai1@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ooops, yes: Reviewed-by: Christoph Hellwig