Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp30452644rwd; Thu, 6 Jul 2023 06:13:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlH0+gnzzWlN7dmCjFwJ+SFVhrKenmJO2gvwP25AeNfSh8VWX5Ucc4oJ4ZhUkK0OoAhjQKPK X-Received: by 2002:a17:90b:3901:b0:263:eb0e:5681 with SMTP id ob1-20020a17090b390100b00263eb0e5681mr3168463pjb.3.1688649234056; Thu, 06 Jul 2023 06:13:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688649234; cv=none; d=google.com; s=arc-20160816; b=ZzvhuShPw0VXLEtEcVy4RPhsuHSZKQsJp5bITA7aQgJygndr2mMkYXY903t9TdfbDA 2l7mUWTlN/4wYr4KqKbJUHuDZvp6hbJA2pRR8jg4y/HG8TR6fG9NbJ1l/6iSGOAUi61m sWkl1dVV2xgheLsspmpSNk95DAp6+MAI8gxDlzsc6UkE6uX7ieczBfEDWSp3yvl32MvG hYREReau52otKh1usq/2836L1L28iKofZpnOty9X344Wgh++qnQ1tT9bQmWbd+gMadPn l3YfCRvHzhxTPlgMd5jRXtXvzRK+vmrYahjCgUr9tlg2qTUGaA4PrQUAPv9zM/knWLMe KPQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=BSYIChndscQWvty4NaXr6kB/Vt3qOu0WUY+NxT5LncY=; fh=2Z921n6qeG+j2vM9Gin3JnYi5s7GtsZDc5CecRgNxMg=; b=OJXQm+PL69S2YQd52vwQbXBbtHBCqYpvTUQjOCG7Yl6uxCkplmVV60swgsP9MXSDcm hhtXm5t51hcklX6j/aaapqt8zBNEMtXoDVa2BGQjYxT94AlrIJQJzGQk5iSuo2uktIhr Ntwrtq+uLXbv78jvamKfvdBP6ztRGf6AnP3FByqUZn3bbbAwRngLbEIDPLEGNkLWUDR0 1/CFhysskGuRdYEB8GFsN6ADfg26Gabk0+XidzeN0N7/i4dBo7WuMRtZLw2RY8z5B44f trK3JFTRRzJQBpUplqho15w9VXY4DK9W7UoMobYWw3y0qfAULIIw3pBXPKx0qI90NQuS R9kA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m10-20020a17090a7f8a00b002563db5c4b0si3662328pjl.184.2023.07.06.06.13.41; Thu, 06 Jul 2023 06:13:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232351AbjGFNJU (ORCPT + 99 others); Thu, 6 Jul 2023 09:09:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbjGFNJT (ORCPT ); Thu, 6 Jul 2023 09:09:19 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA4E1BE9; Thu, 6 Jul 2023 06:09:01 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 89D8067373; Thu, 6 Jul 2023 15:08:58 +0200 (CEST) Date: Thu, 6 Jul 2023 15:08:58 +0200 From: Christoph Hellwig To: chengming.zhou@linux.dev Cc: axboe@kernel.dk, ming.lei@redhat.com, hch@lst.de, tj@kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Chengming Zhou Subject: Re: [PATCH v2 4/4] blk-mq: delete unused completion_data in struct request Message-ID: <20230706130858.GD13089@lst.de> References: <20230629110359.1111832-1-chengming.zhou@linux.dev> <20230629110359.1111832-5-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230629110359.1111832-5-chengming.zhou@linux.dev> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig Although I'd order it first or even send it separately as it doesn't need any of the other changes.