Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0fc3bb0f804fe08600ffd1381c38837341972476.camel@kernel.org>
Subject: Re: [PATCH v2 51/92] hpfs: convert to ctime accessor functions
From:   Jeff Layton <jlayton@kernel.org>
To:     Jan Kara <jack@suse.cz>
Cc:     Christian Brauner <brauner@kernel.org>,
        Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
        Al Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 06 Jul 2023 09:11:01 -0400
In-Reply-To: <20230706124734.ew57trrtzkegqg6y@quack3>
References: <20230705185755.579053-1-jlayton@kernel.org>
         <20230705190309.579783-1-jlayton@kernel.org>
         <20230705190309.579783-49-jlayton@kernel.org>
         <20230706124734.ew57trrtzkegqg6y@quack3>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-07-06 at 14:47 +0200, Jan Kara wrote:
> On Wed 05-07-23 15:01:16, Jeff Layton wrote:
> > In later patches, we're going to change how the inode's ctime field is
> > used. Switch to using accessor functions instead of raw accesses of
> > inode->i_ctime.
> >=20
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
>=20
> ...
>=20
> > diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c
> > index 69fb40b2c99a..36babb78b510 100644
> > --- a/fs/hpfs/namei.c
> > +++ b/fs/hpfs/namei.c
> > @@ -13,10 +13,10 @@ static void hpfs_update_directory_times(struct inod=
e *dir)
> >  {
> >  	time64_t t =3D local_to_gmt(dir->i_sb, local_get_seconds(dir->i_sb));
> >  	if (t =3D=3D dir->i_mtime.tv_sec &&
> > -	    t =3D=3D dir->i_ctime.tv_sec)
> > +	    t =3D=3D inode_get_ctime(dir).tv_sec)
> >  		return;
> > -	dir->i_mtime.tv_sec =3D dir->i_ctime.tv_sec =3D t;
> > -	dir->i_mtime.tv_nsec =3D dir->i_ctime.tv_nsec =3D 0;
> > +	dir->i_mtime.tv_sec =3D inode_set_ctime(dir, t, 0).tv_sec;
> > +	dir->i_mtime.tv_nsec =3D 0;
>=20
> Easier to read:
>=20
> 	dir->i_mtime =3D inode_set_ctime(dir, t, 0);
>=20
> > @@ -59,8 +59,9 @@ static int hpfs_mkdir(struct mnt_idmap *idmap, struct=
 inode *dir,
> >  	result->i_ino =3D fno;
> >  	hpfs_i(result)->i_parent_dir =3D dir->i_ino;
> >  	hpfs_i(result)->i_dno =3D dno;
> > -	result->i_ctime.tv_sec =3D result->i_mtime.tv_sec =3D result->i_atime=
.tv_sec =3D local_to_gmt(dir->i_sb, le32_to_cpu(dee.creation_date));
> > -	result->i_ctime.tv_nsec =3D 0;=20
> > +	inode_set_ctime(result,
> > +			result->i_mtime.tv_sec =3D result->i_atime.tv_sec =3D local_to_gmt(=
dir->i_sb, le32_to_cpu(dee.creation_date)),
> > +			0);
> >  	result->i_mtime.tv_nsec =3D 0;=20
> >  	result->i_atime.tv_nsec =3D 0;=20
>=20
> Here also:
> 	result->i_mtime =3D result->i_atime =3D inode_set_ctime(result,
> 		local_to_gmt(dir->i_sb, le32_to_cpu(dee.creation_date)), 0)
>=20
> > @@ -167,8 +168,9 @@ static int hpfs_create(struct mnt_idmap *idmap, str=
uct inode *dir,
> >  	result->i_fop =3D &hpfs_file_ops;
> >  	set_nlink(result, 1);
> >  	hpfs_i(result)->i_parent_dir =3D dir->i_ino;
> > -	result->i_ctime.tv_sec =3D result->i_mtime.tv_sec =3D result->i_atime=
.tv_sec =3D local_to_gmt(dir->i_sb, le32_to_cpu(dee.creation_date));
> > -	result->i_ctime.tv_nsec =3D 0;
> > +	inode_set_ctime(result,
> > +			result->i_mtime.tv_sec =3D result->i_atime.tv_sec =3D local_to_gmt(=
dir->i_sb, le32_to_cpu(dee.creation_date)),
> > +			0);
> >  	result->i_mtime.tv_nsec =3D 0;
> >  	result->i_atime.tv_nsec =3D 0;
>=20
> And here exactly the same.
>=20
> > @@ -250,8 +252,9 @@ static int hpfs_mknod(struct mnt_idmap *idmap, stru=
ct inode *dir,
> >  	hpfs_init_inode(result);
> >  	result->i_ino =3D fno;
> >  	hpfs_i(result)->i_parent_dir =3D dir->i_ino;
> > -	result->i_ctime.tv_sec =3D result->i_mtime.tv_sec =3D result->i_atime=
.tv_sec =3D local_to_gmt(dir->i_sb, le32_to_cpu(dee.creation_date));
> > -	result->i_ctime.tv_nsec =3D 0;
> > +	inode_set_ctime(result,
> > +			result->i_mtime.tv_sec =3D result->i_atime.tv_sec =3D local_to_gmt(=
dir->i_sb, le32_to_cpu(dee.creation_date)),
> > +			0);
> >  	result->i_mtime.tv_nsec =3D 0;
> >  	result->i_atime.tv_nsec =3D 0;
> >  	hpfs_i(result)->i_ea_size =3D 0;
> > @@ -326,8 +329,9 @@ static int hpfs_symlink(struct mnt_idmap *idmap, st=
ruct inode *dir,
> >  	result->i_ino =3D fno;
> >  	hpfs_init_inode(result);
> >  	hpfs_i(result)->i_parent_dir =3D dir->i_ino;
> > -	result->i_ctime.tv_sec =3D result->i_mtime.tv_sec =3D result->i_atime=
.tv_sec =3D local_to_gmt(dir->i_sb, le32_to_cpu(dee.creation_date));
> > -	result->i_ctime.tv_nsec =3D 0;
> > +	inode_set_ctime(result,
> > +			result->i_mtime.tv_sec =3D result->i_atime.tv_sec =3D local_to_gmt(=
dir->i_sb, le32_to_cpu(dee.creation_date)),
> > +			0);
> >  	result->i_mtime.tv_nsec =3D 0;
> >  	result->i_atime.tv_nsec =3D 0;
> >  	hpfs_i(result)->i_ea_size =3D 0;
>=20
> And in above two as well.
>=20
> 								Honza

Thanks. I fixed those up in my tree.
--=20
Jeff Layton <jlayton@kernel.org>