Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f3005cad61ff0f2de38150d50584c85017df0c57.camel@kernel.org>
Subject: Re: [PATCH v2 53/92] isofs: convert to ctime accessor functions
From:   Jeff Layton <jlayton@kernel.org>
To:     Jan Kara <jack@suse.cz>
Cc:     Christian Brauner <brauner@kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 06 Jul 2023 09:11:25 -0400
In-Reply-To: <20230706123921.z4ckgxviewefzvqq@quack3>
References: <20230705185755.579053-1-jlayton@kernel.org>
         <20230705190309.579783-1-jlayton@kernel.org>
         <20230705190309.579783-51-jlayton@kernel.org>
         <20230706123921.z4ckgxviewefzvqq@quack3>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-07-06 at 14:39 +0200, Jan Kara wrote:
> On Wed 05-07-23 15:01:18, Jeff Layton wrote:
> > In later patches, we're going to change how the inode's ctime field is
> > used. Switch to using accessor functions instead of raw accesses of
> > inode->i_ctime.
> >=20
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> >  fs/isofs/inode.c |  8 ++++----
> >  fs/isofs/rock.c  | 16 +++++++---------
> >  2 files changed, 11 insertions(+), 13 deletions(-)
> >=20
> > diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> > index df9d70588b60..98a78200cff1 100644
> > --- a/fs/isofs/inode.c
> > +++ b/fs/isofs/inode.c
> > @@ -1424,11 +1424,11 @@ static int isofs_read_inode(struct inode *inode=
, int relocated)
> >  #endif
> > =20
> >  	inode->i_mtime.tv_sec =3D
> > -	inode->i_atime.tv_sec =3D
> > -	inode->i_ctime.tv_sec =3D iso_date(de->date, high_sierra);
> > +	inode->i_atime.tv_sec =3D inode_set_ctime(inode,
> > +						iso_date(de->date, high_sierra),
> > +						0).tv_sec;
> >  	inode->i_mtime.tv_nsec =3D
> > -	inode->i_atime.tv_nsec =3D
> > -	inode->i_ctime.tv_nsec =3D 0;
> > +	inode->i_atime.tv_nsec =3D 0;
>=20
> This would be IMHO more readable as:
>=20
> 	inode->i_mtime =3D inode->i_atime =3D
> 		inode_set_ctime(inode, iso_date(de->date, high_sierra), 0);
>=20
>=20
> Otherwise the patch looks good.
>=20

Thanks. Fixed in my tree.
--=20
Jeff Layton <jlayton@kernel.org>