Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Jon Maloy <jmaloy@redhat.com>, Ying Xue <ying.xue@windriver.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v1] net:tipc:Remove repeated initialization
Date:   Thu,  6 Jul 2023 21:42:09 +0800
Message-Id: <20230706134226.9119-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MhnkSB8MmiSCW7I5O774ShNcNWFlt9dK/0oT5iH7hRkOPw4ABDP6mabIQF2Y?=
 =?us-ascii?Q?06ivo/fI1tiDnan1k+Hu/aV6lHx/mDc0wJ8HX6Aajrg2G5mQRSj9IsN/ZvmM?=
 =?us-ascii?Q?SGVTiQolDtNOs4m1F7m8HdUNvPxR1zlUdQJ5t7pC4rAXvUm678HZMc7cjrxt?=
 =?us-ascii?Q?JtRdyomq06MoDE/HFncE4Hs24VyHWj8XDXfdgbGjN0Ln7WxQMpNe1nJFLLym?=
 =?us-ascii?Q?CFRKpnVbMUFwNe6umIjaIN8sSbNtbExMIiFD/lhU4so3U8C57VLHkTCP2Oc4?=
 =?us-ascii?Q?BweVHFpz64zAnMLZQQMEXPqhW2fl7NXbKJobXm1FBJsOiZJm0LAy3URO7MxF?=
 =?us-ascii?Q?B69pYrXJ0C+Xpptd1ng006cKeMbbvmwjIzm5w0LeQtk9YWZYOFRvYadj15Ey?=
 =?us-ascii?Q?I8Dv0snXQjBYrxVrvwGCihthRiD5eXFdILa5xCdijGvIrY6skcGI5hJKEbzq?=
 =?us-ascii?Q?icLQBUhukTR9g+Ql9S3VaN0tPrzGh2LaxEXWgITJzIFdfIu6khIuT5RMojSi?=
 =?us-ascii?Q?PaIWRPFlpyF4WliBrbzoktzfab3hqKRuYRuXhQPAnv4XBqVfIG5vIfmjwXr2?=
 =?us-ascii?Q?Z2RdY21DU1h+sSd/TMa8Q50vI89scQhYfrBC0HO7GLPjMuOKo2Lh3KzLWw+F?=
 =?us-ascii?Q?cxWuARu0+r5A03FiQ5fR3V4MhPUGqLGwZ4tZ4klQJKEtoxxDvn28PvH7lH2U?=
 =?us-ascii?Q?Kz+mfnG8TOqVQ+/jmK5HIHF8UfIGO//oK6Zfyt9U95ORGELo9CE2n8CD0pPK?=
 =?us-ascii?Q?eJCZ2Hz+G+ve0vSy361Zi4NIcddgDTk4mDs8NS99bkZpAuBOOFkKclMcEgoZ?=
 =?us-ascii?Q?Z1Yg0F3vMI6pZBIPef8vUWX8DbTNXTJl37TEhtErbS+r/jMxbHPR9poz9gd2?=
 =?us-ascii?Q?tz7n9xJwwg9J0DH9JAUizfuWYhzk6AAIcw0NdqrVZyVsCaUUp/UYR0QA9qwh?=
 =?us-ascii?Q?SvdAm1ZFrlkaS7nWbQ4vir0mB8Kveni+g1syux3b+Kn4+8csejTBr7clotcC?=
 =?us-ascii?Q?JPaw8QkXPF6IkN6PC4b0znU0r/rmt5AEJdgT76nuPE44iQS/0clKG7TGF4g/?=
 =?us-ascii?Q?NBqpvBY/P5Q+4yq0P1SdMu2oTa37+aa3G3nh/HVrqAIV48XZNTKXFXK5sEEi?=
 =?us-ascii?Q?ihyYTmBFHxIbIYinjDJADHYNzBAycuz3Rp/vVJ3jOrAnmRH1lt6zLXHZ1nFa?=
 =?us-ascii?Q?7HkuglZ0X0wWXeSavU4THKiL7mmNxQTlbDiQeAGxpt8jylub54QAES01ble2?=
 =?us-ascii?Q?ezi2+pSRVlq0VuZ0bxyni1eUYeTbQSffxiS7IC6oHo9P+XkGoVeIfVFJJ+/1?=
 =?us-ascii?Q?N5hkqmhaskPHS++WFmcnwxpEdd0hAvgGImomglp7mqJhJFSHB59/uGKNr2hT?=
 =?us-ascii?Q?mr1xHTeJRmoLCdXLvmK2kZFj7JA0NqXPjcd6MQZuPtbPc69Nle7G5iE5eGJu?=
 =?us-ascii?Q?akWOKf7PGATk3l1GZVjjtwXWV658uhptQFMEJpoTVUMcxY0C5BxkqSh0LmSj?=
 =?us-ascii?Q?M48/2PDM1VrUNvRTFAtzVZRjz7/iCw2LaF4N9w4lz2ffqsDKOTllFFuNX7od?=
 =?us-ascii?Q?t//poiZtr+ST6T0zjRqLLnOWjyQOYHn9j5xZc8BD?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd6b4d26-5061-4157-3776-08db7e26ddd8
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2023 13:42:40.1214
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RSve4jzRBiaXL3HKfZsERN6WFGahVUcVQUwcSsTJY7c0J2+llU2K3g5JRsQqkSU4LbvuLJCJcfiJqYC2KLfg2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB4981
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The original code initializes 'tmp' twice,
which causes duplicate initialization issue.
To fix this, we remove the second initialization
of 'tmp' and use 'parent' directly forsubsequent
operations.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 net/tipc/group.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/tipc/group.c b/net/tipc/group.c
index 3e137d8c9d2f..b2f964f62c36 100644
--- a/net/tipc/group.c
+++ b/net/tipc/group.c
@@ -284,8 +284,6 @@ static int tipc_group_add_to_tree(struct tipc_group *grp,
 	n = &grp->members.rb_node;
 	while (*n) {
 		tmp = container_of(*n, struct tipc_member, tree_node);
-		parent = *n;
-		tmp = container_of(parent, struct tipc_member, tree_node);
 		nkey = (u64)tmp->node << 32 | tmp->port;
 		if (key < nkey)
 			n = &(*n)->rb_left;
-- 
2.25.1