Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <9bc72d0c-fe33-5759-799c-f54e325ba38d@roeck-us.net>
Date:   Thu, 6 Jul 2023 07:01:37 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [GIT PULL] sh updates for v6.5
Content-Language: en-US
To:     John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Sergey Shtylyov <s.shtylyov@omp.ru>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Artur Rojek <contact@artur-rojek.eu>,
        Rich Felker <dalias@libc.org>,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        linux-sh@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <9a6b730fc6c8e70ff034e2e3665478ec31858c29.camel@physik.fu-berlin.de>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <9a6b730fc6c8e70ff034e2e3665478ec31858c29.camel@physik.fu-berlin.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/5/23 14:43, John Paul Adrian Glaubitz wrote:
> Hi Linus!
> 
> I am being a little late this merge window since it took me a little longer
> to thoroughly review the changes which address important issues in the DMA
> and IRQ code in arch/sh.
> 
> The pull request includes a patch by me to fix a compiler warning in the J2
> probing code and a fix by Sergey Shtylyov to avoid using IRQ0 on SH3 and SH4
> targets. Masahiro Yamada made some clean-up in the build system to address
> reports by the 0day bot.
> 
> The most notable changes come from Artur Rojek who addressed a number of issues
> in the DMA code, in particular a fix for the DMA channel offset calculation that
> was introduced in in 7f47c7189b3e ("sh: dma: More legacy cpu dma chainsawing.")
> in 2012! Together with another change to correct the number of DMA channels for
> each SuperH SoC according to specification, Artur's series unbreaks the kernel
> on the SH7709 SoC allowing Linux to boot on the HP Jornada 680 handheld again.
> 
> Last but not least, Guenter Roeck sent in a patch to fix a build regression that
> was recently introduced in 99b619b37ae1 ("mips: provide unxlate_dev_mem_ptr() in
> asm/io.h").
> 
> The following changes since commit ac9a78681b921877518763ba0e89202254349d1b:
> 
>    Linux 6.4-rc1 (2023-05-07 13:34:35 -0700)
> 
> are available in the Git repository at:
> 
>    git://git.kernel.org/pub/scm/linux/kernel/git/glaubitz/sh-linux.git tags/sh-for-v6.5-tag1
> 
> for you to fetch changes up to 7497840d462c8f54c4888c22ab3726a8cde4b9a2:
> 
>    sh: Provide unxlate_dev_mem_ptr() in asm/io.h (2023-07-05 19:04:51 +0200)
> 
> Thanks for pulling!
> 
> Adrian
> 
> ----------------------------------------------------------------
> sh updates for v6.5
> 
> - sh: Provide unxlate_dev_mem_ptr() in asm/io.h
> - sh: dma: Correct the number of DMA channels for SH7709
> - sh: dma: Drop incorrect SH_DMAC_BASE1 definition for SH4
> - sh: dma: Fix DMA channel offset calculation
> - sh: Remove compiler flag duplication
> - sh: Refactor header include path addition
> - sh: Move build rule for cchips/hd6446x/ to arch/sh/Kbuild
> - sh: Fix -Wmissing-include-dirs warnings for various platforms
> - sh: Avoid using IRQ0 on SH3 and SH4
> - sh: j2: Use ioremap() to translate device tree address into kernel memory
> 
> ----------------------------------------------------------------
> Artur Rojek (3):
>        sh: dma: Fix DMA channel offset calculation
>        sh: dma: Drop incorrect SH_DMAC_BASE1 definition for SH4
>        sh: dma: Correct the number of DMA channels for SH7709
> 
> Guenter Roeck (1):
>        sh: Provide unxlate_dev_mem_ptr() in asm/io.h
> 

Perfect example why it is a bad idea to let build failures linger around.
The build failure fixed by this patch ...

> John Paul Adrian Glaubitz (1):
>        sh: j2: Use ioremap() to translate device tree address into kernel memory
> 
> Masahiro Yamada (4):
>        sh: Fix -Wmissing-include-dirs warnings for various platforms
>        sh: Move build rule for cchips/hd6446x/ to arch/sh/Kbuild
>        sh: Refactor header include path addition
>        sh: Remove compiler flag duplication
> 
> Sergey Shtylyov (1):
>        sh: Avoid using IRQ0 on SH3 and SH4
> 
... was hiding boot failures with all my qemu emulations caused by
this patch.

Guenter