Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp30557234rwd; Thu, 6 Jul 2023 07:34:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlEkCYiI7u4wE9e8X0Ggp7F+O80TQ1G7nLLamlmxBOIP+tvPcjHlHV+vua7iKhNDj5QKk4dM X-Received: by 2002:a92:dd0c:0:b0:345:c8d4:1147 with SMTP id n12-20020a92dd0c000000b00345c8d41147mr2346374ilm.16.1688654062484; Thu, 06 Jul 2023 07:34:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688654062; cv=none; d=google.com; s=arc-20160816; b=Ic4z5wwgddEhfmt/49qOghBzQw3chNDHga2N71X+aMIe7eLYZNNz0QzmlMH0EwpxLB 9OXAJbML3L/XkR5rB7nAZ998I26169AJB/hp/b9GsV6ThzxmfXIWRO213tGcBxGEnrgj Zwz/bXznNjXXGcmfbCX2mJg5vFEYIjik8ANCFHwtu2naD4drcFgE1nUkQftfv9X79+Bu TahixnqRECqpUnCP1TktL/8PDYye1TYUxVtpSXf8d/DYGlYdNtafkOBJamdq4iTuTT9G K/zSuGwLJwZxN1mv6/god9/Mxllx2ZLVsUjE4PFHQYtCjOhoJiZ9xSs4KEZ18LSRgsgf 8BVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=WhSDI9mp0MYKeqY0tJX7SergTVTmGv0F/ckbyNmGNLQ=; fh=xbJ1KVihOpvZ0gSxcuBvWHVXKLwiP4ToghpzqQIVLpA=; b=uoJC7SzDRAHQRrJsa6+Fle3OXHjO1oRxKKf3H5770osXtBMDzkNbFbIfAy19OrtF8z US755nPXzl3XSQYyr0Gtk0RenltShv6UJ0KDJvonBcZuTXvNPco+ffoY+cnC1e4r1bar Rg5sveJ0xYqmqedoJDefSkj+5+gXDtWzoxWD0g/H53n3GmIUEpnrOHjsFOzZfEPYfayz WJ4dStQ8+AVTgckBArNt8ZSvboUEiNZCItzUjJLsGCqwhQTqiNLjY/5axLKfxVKvvMx6 DdH/dtdsjMKBAkEajQmaZRSln4O//rzdTr8I7jUXcmq6BFaZRSNjrxVPTLfBX+72eZTT Rzsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=FMqh2Cmz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r24-20020a634418000000b0054ff42dff19si1557646pga.121.2023.07.06.07.34.02; Thu, 06 Jul 2023 07:34:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=FMqh2Cmz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229613AbjGFOEM (ORCPT + 99 others); Thu, 6 Jul 2023 10:04:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231566AbjGFOEK (ORCPT ); Thu, 6 Jul 2023 10:04:10 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57EB91FEE for ; Thu, 6 Jul 2023 07:03:55 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-676cc97ca74so150169b3a.1 for ; Thu, 06 Jul 2023 07:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1688652235; x=1691244235; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WhSDI9mp0MYKeqY0tJX7SergTVTmGv0F/ckbyNmGNLQ=; b=FMqh2CmzOm6XDjJjezWBlN875lQ5T+a7DnklQNymtU9D+p4Vamdg/lVJcXx5LK9wQB KMF3m7xyChwczs3gSrW0hfYLg6AHUOPg2tw1QHIcglCDiKzSYTOIQrtnMYep6XtsjIep DxJJ6tEz23KWKTCsBzXv4e2DMZK0tudoGmt64Vn23mE4w14gdIX8FajdCS/c+EBdj4BM OLhNcMy3ZYtdTw3gnyRZjxn7tMXpguxXzPohD9RzlAV02/2dZlziCIX9IP1zVTQgKS/1 HI6e6TX7bpBdHRlpwO53EfTwR3UPufykmkpeAJRybBh5mzEiKnBBl2q/GqPD8Ytlw/Gs lsQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688652235; x=1691244235; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WhSDI9mp0MYKeqY0tJX7SergTVTmGv0F/ckbyNmGNLQ=; b=G7Oz3yQvqTfCcfAH6zpCT+E69mGkpewBzjt05LJBkafY45yQGTCXOECJch/Jt5t3+E AElTuY4g/dgIXGWqj6YDjaHNhMMT0+hVlEHap51ANurIZa99np1PGcIglhRu9167d9Ih Ylw1TZ19Tm9ZCLGyGnAw9YYHC6hlhX2JkfHQEXJw2+Ym+qf3hCw5NOPQr2j4RtAjGn+0 ZF1wXzvLTuryPIEG47dmCrT0Hrr14X1UIiQfpxJvRaPowb3XLyuTpgCy/tvKx7P6hgoY gVwNWtUV+cekLBRO0BVtVrIb/e9R5oZYjFFl5jXjsUNI+La/zW+ugR3gKV30UZy64a3o e/OA== X-Gm-Message-State: ABy/qLbbP9s4fF6WxGxodoOsMmu6NJtdLsK44n29+3KqaRkxKypAW8Rm gjcjXYBVvSkRFeP/CM9hx9mlFg== X-Received: by 2002:a05:6a20:7495:b0:12d:2abe:549a with SMTP id p21-20020a056a20749500b0012d2abe549amr2182854pzd.6.1688652234613; Thu, 06 Jul 2023 07:03:54 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id z21-20020aa791d5000000b0063b898b3502sm1322987pfa.153.2023.07.06.07.03.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jul 2023 07:03:53 -0700 (PDT) Message-ID: Date: Thu, 6 Jul 2023 08:03:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] Fix max/min warnings in virtio_net, amd/display, and io_uring Content-Language: en-US To: Alex Deucher , Yang Rong Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Pavel Begunkov , Alvin Lee , Jun Lei , Qingqing Zhuo , Max Tseng , Josip Pavic , Cruise Hung , "open list:AMD DISPLAY CORE" , "open list:DRM DRIVERS" , open list , "open list:VIRTIO CORE AND NET DRIVERS" , "open list:NETWORKING DRIVERS" , "open list:IO_URING" , opensource.kernel@vivo.com, luhongfei@vivo.com References: <20230706021102.2066-1-yangrong@vivo.com> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/6/23 7:58?AM, Alex Deucher wrote: > On Thu, Jul 6, 2023 at 3:37?AM Yang Rong wrote: >> >> The files drivers/net/virtio_net.c, drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c, and io_uring/io_uring.c were modified to fix warnings. >> Specifically, the opportunities for max() and min() were utilized to address the warnings. > > Please split this into 3 patches, one for each component. Don't bother with the io_uring one, code is far more readable as-is. -- Jens Axboe