Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e82198b64ab0c0d4a92e16aa16788cf13ece2786.camel@kernel.org>
Subject: Re: [PATCH v2 56/92] kernfs: convert to ctime accessor functions
From:   Jeff Layton <jlayton@kernel.org>
To:     Jan Kara <jack@suse.cz>
Cc:     Christian Brauner <brauner@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tejun Heo <tj@kernel.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 06 Jul 2023 09:50:47 -0400
In-Reply-To: <20230706133236.vwvm4utsgnhty3mk@quack3>
References: <20230705185755.579053-1-jlayton@kernel.org>
         <20230705190309.579783-1-jlayton@kernel.org>
         <20230705190309.579783-54-jlayton@kernel.org>
         <20230706133236.vwvm4utsgnhty3mk@quack3>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-07-06 at 15:32 +0200, Jan Kara wrote:
> On Wed 05-07-23 15:01:21, Jeff Layton wrote:
> > In later patches, we're going to change how the inode's ctime field is
> > used. Switch to using accessor functions instead of raw accesses of
> > inode->i_ctime.
> >=20
> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
>=20
> It looks like there are like three commits squashed into this patch -
> kernfs, libfs, minix.
>=20
> kernfs and libfs parts look good to me - feel free to add:
>=20
> Reviewed-by: Jan Kara <jack@suse.cz>
>=20
> to them. For the minix part I have one nit:
>=20
> > diff --git a/fs/minix/inode.c b/fs/minix/inode.c
> > index e9fbb5303a22..3715a3940bd4 100644
> > --- a/fs/minix/inode.c
> > +++ b/fs/minix/inode.c
> > @@ -501,10 +501,11 @@ static struct inode *V1_minix_iget(struct inode *=
inode)
> >  	i_gid_write(inode, raw_inode->i_gid);
> >  	set_nlink(inode, raw_inode->i_nlinks);
> >  	inode->i_size =3D raw_inode->i_size;
> > -	inode->i_mtime.tv_sec =3D inode->i_atime.tv_sec =3D inode->i_ctime.tv=
_sec =3D raw_inode->i_time;
> > +	inode->i_mtime.tv_sec =3D inode->i_atime.tv_sec =3D inode_set_ctime(i=
node,
> > +									raw_inode->i_time,
> > +									0).tv_sec;
> >  	inode->i_mtime.tv_nsec =3D 0;
> >  	inode->i_atime.tv_nsec =3D 0;
> > -	inode->i_ctime.tv_nsec =3D 0;
>=20
> The usual simplification:
> 	inode->i_mtime =3D inode->i_atime =3D inode_set_ctime(inode,
> 							  raw_inode->i_time, 0);
>=20
> 								Honza


Thanks. I'm not sure what happened with this patch, as some of the
subsystems got squashed together. I'll break that up properly too.
--=20
Jeff Layton <jlayton@kernel.org>