Date: Tue, 23 Oct 2007 09:23:33 -0700
From: Arjan van de Ven <arjan@infradead.org>
To: lsorense@csclub.uwaterloo.ca (Lennart Sorensen)
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Anas Nashif <nashif@linux.intel.com>, linux-kernel@vger.kernel.org,
       Marek Dabek <marek.dabek@intel.com>
Subject: Re: [PATCH] Intel Manageability Engine Interface driver
Message-ID: <20071023092333.39982483@laptopd505.fenrus.org>
In-Reply-To: <20071023150429.GK4003@csclub.uwaterloo.ca>
References: <471CDC5E.4010300@linux.intel.com>
	<20071022114001.40470c15.akpm@linux-foundation.org>
	<20071023150429.GK4003@csclub.uwaterloo.ca>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 839
Lines: 23

On Tue, 23 Oct 2007 11:04:29 -0400
lsorense@csclub.uwaterloo.ca (Lennart Sorensen) wrote:

> On Mon, Oct 22, 2007 at 11:40:01AM -0700, Andrew Morton wrote:
> > - Here:
> > 
> > +		if (0 == memcmp(&heci_wd_guid,
> > 
> >   we boringly prefer "if (foo == 0)" rather than "if (0 == foo)".
> > (lots of places).
> 
> But 0 == blah is safer.  If you accidentally do 0 = blah the compiler
> will tell you. 

gcc will tell you in the other direction just as well.

and people read from left to right (at least in english) so coding in
that direction is generally preferred in the Linux kernel as well.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/