Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cf70cba0-3ba2-3907-542d-c80216068f7b@kernel.dk>
Date:   Thu, 6 Jul 2023 08:05:33 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] io_uring: A new function has been defined to make get/put
 exist in pairs
Content-Language: en-US
To:     Lu Hongfei <luhongfei@vivo.com>,
        Pavel Begunkov <asml.silence@gmail.com>,
        io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
References: <20230706093208.6072-1-luhongfei@vivo.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20230706093208.6072-1-luhongfei@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/6/23 3:32?AM, Lu Hongfei wrote:
> A new function called io_put_task_refs has been defined for pairing
> with io_get_task_refs.
> 
> In io_submit_sqes(), when req is not fully sent(i.e. left != 0), it is
> necessary to call the io_put_task_refs() to recover the current process's
> cached_refs and pair it with the io_get_task_refs(), which is easy to
> understand and looks more regular.

No point having a helper for just a single caller.

-- 
Jens Axboe