Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ce15f15b-2f1d-960c-c20e-131d92e1d750@amd.com>
Date:   Thu, 6 Jul 2023 19:52:09 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2] perf vendor events amd: Fix large metrics
To:     Ian Rogers <irogers@google.com>
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@kernel.org, namhyung@kernel.org, adrian.hunter@intel.com,
        ayush.jain3@amd.com, ananth.narayan@amd.com, ravi.bangoria@amd.com,
        santosh.shukla@amd.com
References: <20230706063440.54189-1-sandipan.das@amd.com>
 <CAP-5=fVdVSL4H1qWLZMiU3H2-bOJ0RkFOfq4Jxz1qw0-8EoYFw@mail.gmail.com>
Content-Language: en-US
From:   Sandipan Das <sandipan.das@amd.com>
In-Reply-To: <CAP-5=fVdVSL4H1qWLZMiU3H2-bOJ0RkFOfq4Jxz1qw0-8EoYFw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnh0SkIvMkdrai9DT05CRHFTdVdITTBaNlFFVmY5bmtkMnB6UUxzMjYzTnNq?=
 =?utf-8?B?N3ZJcVpnRDdSOUlpdUE3SkJERis4M3kzaHlvdjZsVDBYdW1xOHhIajBqK29l?=
 =?utf-8?B?OUJreUlpVUZnMkZibC9yeFVJdzZzOW5taDRrYzU2QW1Ka0ppN1grTzhDd09G?=
 =?utf-8?B?M2hjN2YrL0ZiYUxLMHdNdWxIT0ZGTk5UckY4bnZsK3dwaXdhQ2xsZDhjVDZY?=
 =?utf-8?B?QktnZTdpZDNMbUJyTWhGNHlEalZVaWZnWkZYZ1Fyd1lLRnRCaTkzU21Nd2Uw?=
 =?utf-8?B?SzBBeDlhTy9tQUhrbHRyUFRYN3pObVQ3dGJUd2Zxb2NtNkg0aVlXc1ptZWw2?=
 =?utf-8?B?UjlnSWg2aWlNRXBQZ0t3MzhJU3hlYkJrT0xaWU1LQWhDdHdFNXYzTFJPZ293?=
 =?utf-8?B?cGk3cmJQQzJlcFBHMlJXOU9oMENjVEtKd2lIR1Q5NFc3MGFKUFQ1V3c2WHpY?=
 =?utf-8?B?cGlsdEpub0pqVHJ3aFk5NysvWW9oZ2FBUVhycDJpSFBOR2o1a2xpNDA4aDY2?=
 =?utf-8?B?RFd3SmFMQ2FaMDdCdURkU3BUbjMxclN0eWMwUVRHM0FZZ0xnNU5FZXI4U0Vr?=
 =?utf-8?B?Ynk3QlozdmtLNGQvWVo3ZStTY1N1VGNtaUlyMVpjc1dpYUVSM2VMTHZmSVNZ?=
 =?utf-8?B?SmYwR01ZdkNNeXgxRDcvZHVDWnlLcTczSmM4bmphRmprZ1VEOTBSVHhSbUcy?=
 =?utf-8?B?QjlKRHNYTm9oakVXa1h0QjVVMkRmczhqWW5nZGxDblU2VVNwKzNJamY2ZjdB?=
 =?utf-8?B?WWhhRHhESGJLNkFuZmdWbFE5d3BZWTRURWtnS0RTejF0L0Z4bVF6anZkdzRi?=
 =?utf-8?B?dHpBS1hSNzBQRG41RGM2Z0JSb2hlbTVaMitwTTZ5aGhMT01SRmR0andjV3Az?=
 =?utf-8?B?M1dWeUc4RXBaT3RYK0UvZjBBNndKcG5UYytPNWNCbWdOc3loVmtEMEV0bncx?=
 =?utf-8?B?UERoeUlSS1NSVlArcUZaS3BlR0didmgwbkppdGZKUGk2c2hwZ2J3Y3l3eHBt?=
 =?utf-8?B?a2hQWWhrSlNIeitPTEVxRkN5aWwwN3ZURy9LeS9BOER6VkZHMmcyNzF1WXRV?=
 =?utf-8?B?OHdwQndIcnpQc3BMY2RibzYwMDFSMFF6U2F5UUJjbEUramhGcnQxMTlVbW12?=
 =?utf-8?B?K2pIdW9FczhtZENwOSt3TFJkRkV6ck0rMitvLzY3djd2WWJoMUtaQ0xCcG8w?=
 =?utf-8?B?QmhGU3ZjZGoxcXpaR2FjbXY3a24vS1AyamEzMFF6eWRZRS9OK255ejBINURT?=
 =?utf-8?B?MVVTY2pRZ0VleEs2bWlWVTdUVlJhRGdwYlFycTQ0a2hMRUloeVd1cVFOK2pv?=
 =?utf-8?B?NDc4U2Y3SzMycE9VdDl5K2haQnh4d1M2TzBIK0FKZExtMnIxSmFDMnZDcW4y?=
 =?utf-8?B?KzA1Y0FlWEtBbE9MdkxLY0ZOR0d5UjZydDdUSmF3c3VYWlJ5ZWVNb2pGL05y?=
 =?utf-8?B?Q3JMWEpwU3JreXlWQ0FXY0U2OEI5ZTJHSFpUSzVXb3JFM0JUSVQ2dzBXU2p4?=
 =?utf-8?B?MGV6UHhsSXJTZG5ZczJRMEJmc21JTUpxOVRoOG55TzBPdWh1ZnFjN2NOVk5w?=
 =?utf-8?B?V1VUck5ITzdIWlBOOWl0Y0hDTWtjWDRBdkcvcHR0S1hkUVNNZDNDN1RleTRy?=
 =?utf-8?B?Y0JubWh6elgrUk13OGZKZTFDcUdyd1dGU3dXYURuNHdFRUJOV05HNTlvL1Bm?=
 =?utf-8?B?MUxkaERXM0NLUy8wYmNiL1B3Yld6V3F4UFlIMSt6VHdnR3dPQXJSWUQ2Q0tm?=
 =?utf-8?B?Y3p6ZENaaHZMWXdKUE5LdXIzcmlhL2o3bUFLckRaVkl0NU51NEJFRWJsdWp3?=
 =?utf-8?B?UytYVm4zdUdQSXVxVFlzY1J6WktrRVpoOEZNMVl4RjB5OGI2N1FlRWhSZEVL?=
 =?utf-8?B?K2cxN2hNamhqeDI1RmlyOVRLRnJmczNoUWxZaHQ2QlBLVWJ5M2V3TCtMbSt1?=
 =?utf-8?B?UE1jc2VNbm05djNrWVlxcXdINnJOOWY1T1AvRFVVMHpWajhqU01MVkFLTTNz?=
 =?utf-8?B?eVJiTFMwa1ZNUHgwcExWYVkzRG1scUM4emJFNEIxeXJlclRJUkhhU09acG1k?=
 =?utf-8?B?NGZTU2JYQWxjTENVZ0hONDhqNmJZQmJYbTc2dmlMZDdSKzNHcDVWZTdmbnlp?=
 =?utf-8?Q?la1the9o9Bhp1GvvIOUekF/JV?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d7a867e-9f27-4e63-4450-08db7e2c6b6c
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5712.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2023 14:22:25.3114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H6j3StGFXFi/Ag9oT5ASEmxWvgur8/xk2J7I+SebZYzPEBsDrKOAhGxbMqEjj3mD4F/rzwbeppNA9Wt7IPX4UQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6871
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ian,

On 7/6/2023 7:19 PM, Ian Rogers wrote:
> On Wed, Jul 5, 2023 at 11:34 PM Sandipan Das <sandipan.das@amd.com> wrote:
>>
>> There are cases where a metric requires more events than the number of
>> available counters. E.g. AMD Zen, Zen 2 and Zen 3 processors have four
>> data fabric counters but the "nps1_die_to_dram" metric has eight events.
>> By default, the constituent events are placed in a group and since the
>> events cannot be scheduled at the same time, the metric is not computed.
>> The "all metrics" test also fails because of this.
>>
>> Use the NO_GROUP_EVENTS constraint for such metrics which anyway expect
>> the user to run perf with "--metric-no-group".
>>
>> E.g.
>>
>>   $ sudo perf test -v 101
>>
>> Before:
>>
>>   101: perf all metrics test                                           :
>>   --- start ---
>>   test child forked, pid 37131
>>   Testing branch_misprediction_ratio
>>   Testing all_remote_links_outbound
>>   Testing nps1_die_to_dram
>>   Metric 'nps1_die_to_dram' not printed in:
>>   Error:
>>   Invalid event (dram_channel_data_controller_4) in per-thread mode, enable system wide with '-a'.
>>   Testing macro_ops_dispatched
>>   Testing all_l2_cache_accesses
>>   Testing all_l2_cache_hits
>>   Testing all_l2_cache_misses
>>   Testing ic_fetch_miss_ratio
>>   Testing l2_cache_accesses_from_l2_hwpf
>>   Testing l2_cache_misses_from_l2_hwpf
>>   Testing op_cache_fetch_miss_ratio
>>   Testing l3_read_miss_latency
>>   Testing l1_itlb_misses
>>   test child finished with -1
>>   ---- end ----
>>   perf all metrics test: FAILED!
>>
>> After:
>>
>>   101: perf all metrics test                                           :
>>   --- start ---
>>   test child forked, pid 43766
>>   Testing branch_misprediction_ratio
>>   Testing all_remote_links_outbound
>>   Testing nps1_die_to_dram
>>   Testing macro_ops_dispatched
>>   Testing all_l2_cache_accesses
>>   Testing all_l2_cache_hits
>>   Testing all_l2_cache_misses
>>   Testing ic_fetch_miss_ratio
>>   Testing l2_cache_accesses_from_l2_hwpf
>>   Testing l2_cache_misses_from_l2_hwpf
>>   Testing op_cache_fetch_miss_ratio
>>   Testing l3_read_miss_latency
>>   Testing l1_itlb_misses
>>   test child finished with 0
>>   ---- end ----
>>   perf all metrics test: Ok
>>
>> Reported-by: Ayush Jain <ayush.jain3@amd.com>
>> Suggested-by: Ian Rogers <irogers@google.com>
>> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
> 
> Acked-by: Ian Rogers <irogers@google.com>
> 
> Will there be a PMU driver fix so that the perf_event_open fails for
> the group? That way the weak group would work.
> 

Yes, that's in our plan. Ravi (in CC) and I have discussed about adding
group validation in the event_init() path.

- Sandipan