Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp30616357rwd; Thu, 6 Jul 2023 08:19:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlEo7cnDNMM54Y98RfC+2emlohXCwd0B96dLpJCLLhAY0oq1eUKhsVIl+3b5CaKxxMoVUmiB X-Received: by 2002:a05:6a00:230b:b0:662:f0d0:a77d with SMTP id h11-20020a056a00230b00b00662f0d0a77dmr2108143pfh.30.1688656768009; Thu, 06 Jul 2023 08:19:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688656767; cv=none; d=google.com; s=arc-20160816; b=TsxXsTGVjmwxJ8kfxn7sfowEjKeTur4WgBB+gmYMyzSudXfcllrvZfKW6GeC/LuliF LQRVXZrC6MsmESAJ0wTb0DVIzHDx5UwqW96zFw1nQbfBnkK8D2jumsza0eyafxLEYlxe L2HnKirNyyNCnSyzOwRDpyrXpKXKyC1rrX80oVd5YqejoFwL6UcFvrhbX5S9zbiGaxQ7 yaGow0j2coyA1S7dL181K7KN5YVoGNES7PxoflI+JL29C1zqFsLJF4Dk2Gx5/ftw8pCX WEOnHtzEFstd41MbHjyqcGU63kzrOoGVCJHmZAyAwbVm7XqIwsg9gc5ShSoch954C+al oxLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CHQ8hr8v36RUyE6Io+JdxgB9ql1UaYrgMKiJJ9a/AXs=; fh=C7DZ50NwO2q5UmmSXTZ3O8w48KsYP2D+LgwFo48rIgw=; b=FdHi36z+ihCfH7tJvq92gZmelkLvigInze2eUhM0w/VkStTmOA2ssNeTOz1mdI+Lcs BvmNpUTAduVoDoRS/sZ2PPT/Kc14sKkezjtvS1juuebaD6sAbIxLG/+I61ZEatCw8qck lkSRqlXusQNp6JW4lzvWY9254rxgKwoH9//hNiYmWip6UdvAcqwhPDkCXnHTuTq5zv+1 1lFvNDHX/E/NXMF6mvLuaI8HBs/8BMuFzTC3JZtWzoQ1f9vMTzeflfsxd+TePZUsAaOj /itpclKY1/nsrKUMpFO7+bmJD4Uc3q8x6tjCufP3HQSYJu7/s63nnmgCfGus7tmmcRAM SKhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=rlWLPNqN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u195-20020a6379cc000000b005533aa71fabsi1655505pgc.572.2023.07.06.08.19.12; Thu, 06 Jul 2023 08:19:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=rlWLPNqN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233005AbjGFOpN (ORCPT + 99 others); Thu, 6 Jul 2023 10:45:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231255AbjGFOpM (ORCPT ); Thu, 6 Jul 2023 10:45:12 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9AF61732 for ; Thu, 6 Jul 2023 07:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CHQ8hr8v36RUyE6Io+JdxgB9ql1UaYrgMKiJJ9a/AXs=; b=rlWLPNqN6pXF19kxSMviYejBej sSr2dDOibt5FRbmZ5PUguwcwFgrfASMwtJzJDrj3mGJmKbe7hH1++3+Ve7aXU5U51/u5IRHhLBbJX pAqtA7oJJAEdUJCW9G0RI6NZlMBYJQHWJdNqVD03xOr3ssKVPUbjNLs4chYGtk9Af3oIPpLHJUNnT c6jQD7BrUYQC3kwWvjeTaAtERxV0EGBGKS2uXJEvjMBDIcSo76I7i0vuwx1sEsIihjY+SipllfRlS jJTWzAL5BvDPh2B2zzJ+EYe6BNeMeE/LANVBApsArGS6cKjs3nMmJ+TBD2dTMeMn5GqCWjvpbm8xA fDSH31zg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qHQEA-00B993-OR; Thu, 06 Jul 2023 14:45:02 +0000 Date: Thu, 6 Jul 2023 15:45:02 +0100 From: Matthew Wilcox To: Wang Ming Cc: "Liam R. Howlett" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v1] lib:Remove repeated initialization Message-ID: References: <20230706140314.9999-1-machel@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230706140314.9999-1-machel@vivo.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 06, 2023 at 10:03:01PM +0800, Wang Ming wrote: > The original code initializes 'entry' > twice in line 3229 and 3232, which > causes duplicate initialization issue. > To fix this, we remove the initialization > of 'entry' in line 3229. mas_next() has a side-effect; it's not a pure initialisation. Fix your tool.