Subject: Re: [PATCH] Add eeprom_bad_csum_allow module option to e1000.
From: Adam Jackson <ajax@redhat.com>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <471E1ECD.80002@intel.com>
References: <11931515302013-git-send-email-ajax@redhat.com>
	 <471E1ECD.80002@intel.com>
Content-Type: text/plain
Date: Tue, 23 Oct 2007 12:21:27 -0400
Message-Id: <1193156487.26974.39.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 967
Lines: 24

On Tue, 2007-10-23 at 09:18 -0700, Kok, Auke wrote:
> Adam Jackson wrote:
> > When the EEPROM gets corrupted, you can fix it with ethtool, but only if
> > the module loads and creates a network device.  But, without this option,
> > if the EEPROM is corrupted, the driver will not create a network device.
> > 
> > Signed-off-by: Adam Jackson <ajax@redhat.com>
> 
> NAK
> 
> wrong list, not sent to me, and while for e100 I was OK with this patch, for e1000
> it really does not make sense to 'just allow' a bad checksum - if your eeprom is
> randomly messed up then you cannot just fix it like this anyway.

That's strange, I managed to recover an otherwise horked e1000 with it.
What should I have done instead?

- ajax

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/