Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f8152ec7-e38f-d215-3e1f-3165912b4031@linaro.org>
Date:   Thu, 6 Jul 2023 17:23:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba
 support
Content-Language: en-US
To:     Rohit Agarwal <quic_rohiagar@quicinc.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        agross@kernel.org, andersson@kernel.org, linus.walleij@linaro.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
References: <1688650209-25119-1-git-send-email-quic_rohiagar@quicinc.com>
 <1688650209-25119-2-git-send-email-quic_rohiagar@quicinc.com>
 <4042fa22-8948-49c9-6e5c-dc8926ed5f99@linaro.org>
 <6d067262-d8af-f6f3-4ef7-870eafa15f46@quicinc.com>
 <8b04d830-4710-7f26-09e8-326b69d72396@linaro.org>
 <a50921ca-c858-dacc-6849-4898fdf7683c@quicinc.com>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <a50921ca-c858-dacc-6849-4898fdf7683c@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6.07.2023 17:11, Rohit Agarwal wrote:
> 
> On 7/6/2023 8:34 PM, Konrad Dybcio wrote:
>> On 6.07.2023 16:45, Rohit Agarwal wrote:
>>> On 7/6/2023 8:05 PM, Krzysztof Kozlowski wrote:
>>>> On 06/07/2023 15:30, Rohit Agarwal wrote:
>>>>> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
>>>>> binding.
>>>>>
>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>>> ---
>>>>>    Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
>>>> I doubt that all your patches here and other patchsets are v1. Otherwise
>>>> how did you get my Acks and Rbs? Please use proper versioning and
>>>> provide changelog.
>>>>
>>>> What changed here?
>>> Actually this is part of the original bigger series [1] that as per Bjorn's suggestion need to be broken
>>> down according to the subsystem/maintainer.
>>> Since it got broken down into multiple smaller series, I didnt include the versioning.
>> All of that information should be included in the cover letter, to
>> limit confusion both for maintainers and patch workflow tools.
>>
>> Since these patches all come from a separate series, it would be
>> good for you to version this one as v(BIG_SERIES_REVISION)+1 because
>> they've already been on LKML at least once. That would especially hold
>> true if this revision included any changes.
> Understood. Will send all the smaller series again with v2 as version with changelog.
v3, this was essentially a v2.

Konrad
> 
> Thanks,
> Rohit.
>> Konrad
>>> [1] https://lore.kernel.org/all/9de424ca-271a-8ed2-5550-658a828c4ea5@quicinc.com/
>>>
>>>> Best regards,
>>>> Krzysztof
>>>>