Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp30657946rwd; Thu, 6 Jul 2023 08:54:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlGdYEPHhpo2WLzhlP35Ot0Q5fCl1gKH6l3ey7C2MO+x90fb5Y5G3fbLpOTdtugRGk2l2LXM X-Received: by 2002:a05:6358:4412:b0:134:e3d2:1e50 with SMTP id z18-20020a056358441200b00134e3d21e50mr2991810rwc.18.1688658863564; Thu, 06 Jul 2023 08:54:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688658863; cv=none; d=google.com; s=arc-20160816; b=ld3racMOY/fsrnQvRcRMnKofFd7NtrjU6AnV2InJf8HK2j/zeLH3aI9SJVqYryJCZO TJCNGAIxSPZ59kukt7/gNLPlCjkO9vjNDzIB14IYQQJnXqGFdITtGWBDtUkMSuRCPgF1 +V2QKnzy2oH4nDQCLmubNRSrGbyKK3amPQputqBOxqbds/LyU34OVmjjnjIVNYTPXRtO PLLstUppQba4jO3Wrx5lE9mv+tBpTCKPW9JX2AKaruc3uhnLKoPA5IVZtW9qh10TGtML aaay4L82J26Zq246mI9+IxsU5C26rEAoID/57CiyQNxfnpe4iNEPxTgTOxjPDmajbq33 IbOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=9ZKpI3vdM2be+mBmSs85yjDaK1/llqYUEuzmJhi8vyc=; fh=XshsExeHx6Pp4jVbf6TZfxFHGjvjzwC5Cw6a58KmQT8=; b=x/5gkP+b2XNHvIV2HI7QKK+Z8B0GVRMkF+IBMZFxrqtkttPe7SddbDbVWltLdZEDwN qTikCv9f4Cle+1mO2SMCWah5cPtcwgcnPCrdPuG6+Vjvnsh+SvMPv/UP7pwYtwpiNswd jecA5VL1ZImesXBn4EJdApsU2EiFYkTvJiP5oRwXR+Ao4VmXFMaj3HxsVbh5SLSVNaHT zOLkAS3sDqc7nY03QFYPsdXkk22xtlfW1C6SSu7qsSFxZZf7ybgETdikkPwpsia44+HV 2flVOAw7jA2VEYRRi3RqxM6PMLMM7fgkFGA8wrJYv0bKCYC+rHob7t7NCuU8P9C3lEMg MD0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cFdOdI+k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h34-20020a635322000000b00543ef0f981asi1668031pgb.631.2023.07.06.08.54.10; Thu, 06 Jul 2023 08:54:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cFdOdI+k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232202AbjGFPsT (ORCPT + 99 others); Thu, 6 Jul 2023 11:48:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232688AbjGFPry (ORCPT ); Thu, 6 Jul 2023 11:47:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A06E61BFD for ; Thu, 6 Jul 2023 08:47:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EEADA60C1C for ; Thu, 6 Jul 2023 15:47:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 084B9C433C7; Thu, 6 Jul 2023 15:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688658450; bh=v4jGue9yUrQ15tRNs2k8or9Xz/JXP8QjRvYexu2gh3g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cFdOdI+kDlrfz/u27anBotvHcs3HvvpJyWKTZrGLgDFCUYqTdzogEV4KANa0HzJxI TZAzvr6KaGMHjFQEePPFmjEkdRJWwqLyK75eE11Qalmed0owGp6y+QhwydY0q8rVDy fb2mFsjWnJO6KvPATLz52ZMS64RtIMzg+shlHJL+nPzklP+E1+P67AkBqANJDOxmwG bwhwCszL+cMyIY2gR9bjJDyikYzzoe/gJAYHMlphy1kzM20R5UQ8NZthwagJen3k0r 6sZ0s4nL9fCu4pat0y63mtoC5dkHD9FS6ZdUNNJE9OevRJDkP4Ta531rDUjNfU6cBb YYLIPgqE+VUdA== Date: Thu, 6 Jul 2023 08:47:29 -0700 From: Jakub Kicinski To: Wang Ming Cc: Jon Maloy , Ying Xue , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v1] net:tipc:Remove repeated initialization Message-ID: <20230706084729.12ed5725@kernel.org> In-Reply-To: <20230706134226.9119-1-machel@vivo.com> References: <20230706134226.9119-1-machel@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Jul 2023 21:42:09 +0800 Wang Ming wrote: > The original code initializes 'tmp' twice, > which causes duplicate initialization issue. > To fix this, we remove the second initialization > of 'tmp' and use 'parent' directly forsubsequent > operations. > > Signed-off-by: Wang Ming Please stop sending the "remove repeated initialization" patches to networking, thanks.