Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp30679731rwd; Thu, 6 Jul 2023 09:09:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlG9GG5ISgx2rZ1b1P+d/ESGtOJyzGMl/ieNqEr01EU5NRGSOVOGLJONkVeS1hJgLAhCnDio X-Received: by 2002:a17:90a:bb13:b0:260:ea4b:9b6f with SMTP id u19-20020a17090abb1300b00260ea4b9b6fmr1716853pjr.46.1688659781734; Thu, 06 Jul 2023 09:09:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688659781; cv=none; d=google.com; s=arc-20160816; b=zEorekhGrizeTKiY0vpY5k3+551RdoYy/rLk4dRR6aSd5ISL35BQ3RKo/Bkw+n6E7n W8qKbEKGAXXCmO4SRa1FpFrU89aWT3295OG4hBj3ttKwx0PDH6Qv6jat82s5UrS7gewO rW/NwFA5swSx79AwgIpAQlBzye5e6vVP+zAhJT45iNaFuPHJ/ow6ZxuHMPNDgLQ11a0t ha8QoMB6d7tGyuDZxC9ZxUCoUKUpUZgPRm7OtDKW1l2yIqeJLUcQwLIaynDoQb7G8sWA Wm8LYeX+LNHhHzbTjVsvy6BzUbzfwG2Std++R93c2oeCsZYVe/zvTxYJ5OO0L9iDZKzq bJ2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=96mPzvVqGjHXyf71HeWZupM95wIpkpJcGhVvW4Wd980=; fh=SOe7+ci8HO663A8c13iOyEB8TgSQwR/DsgGWkzYL8ow=; b=l3Ux6pXupj9kas9/Kh6Oi19o7SKhx8wrf3mK6QQX5qQVNFsV9mzNoZoyUUBVkhJjaB JU2hm4M2huhYs0aRDpxn74opjZkDbihU7YpneuMk5ef5oP2HJ76QP9V3BmBuAKfxiXiK vyL3Uj3LBp+gM8O07YF09OMNavPDLfLtrwdLYp1/G7SIOsVE6cZWRsGWVis45iv9NmmI HP5vrm40K/rUmHt2OP7MLDjTEPhhF5zdPErgQcvGlsHzs/ohLvqKAoF8lOYgzxEi/QTa x4Dq3friWur1RJG4jlKyWQcSTPC8TyoA49cgv05y2TiWL24rEG/eLPXeBbdvwBfJTx/r NfCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PsUdJCiP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u1-20020a17090ae00100b002611518b4aesi1775079pjy.101.2023.07.06.09.09.26; Thu, 06 Jul 2023 09:09:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PsUdJCiP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232724AbjGFPsa (ORCPT + 99 others); Thu, 6 Jul 2023 11:48:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233563AbjGFPsQ (ORCPT ); Thu, 6 Jul 2023 11:48:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AAA01BF6 for ; Thu, 6 Jul 2023 08:48:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E1E5D60B9C for ; Thu, 6 Jul 2023 15:48:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BDC3C433C7; Thu, 6 Jul 2023 15:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688658481; bh=4ASIsjcCMXJ6y3BmrH23jMs2Uiv/tnU9i09G/DMp9i8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PsUdJCiPG2ZCBQJG2eka4OFYlYQdogV7Ar1J3g9NEI4VfTjSoAJIf2dOK1IqK95mh I6iP+r5jNWf0hUmQPPtTotHi0NUu3m6MhV17q9t9Kc/8r/RBzehV4vqneSrlBRN4hx V/0CTuE9xT4Zi89Tn0ntAd+l8vI13+yuRfUqJ1iMik7xwSVVzDkbWx22XOlbiCK+ab h74R6h3/AfHD3ybFrrBLc/nK6GimGlcfzUtEMQdUKqnKoPIKioiD0ZyJbVFBgMSO7E isukZTMpyXvCbBlvwNjdcqWyyc8nFqXbLQ3y6nItWHjnjyTu2kir8us3LIvhc514Dd 5bJ5BFF0jG0Yg== Date: Thu, 6 Jul 2023 08:48:00 -0700 From: Jakub Kicinski To: Wang Ming Cc: Sunil Goutham , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com, simon.horman@corigine.com Subject: Re: [PATCH net v2] net:thunder:Fix resource leaks in device_for_each_child_node() loops Message-ID: <20230706084800.579bd030@kernel.org> In-Reply-To: <20230706123021.8174-1-machel@vivo.com> References: <20230706123021.8174-1-machel@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Jul 2023 20:30:11 +0800 Wang Ming wrote: > The device_for_each_child_node() loop in > bgx_init_of_phy() function should have > fwnode_handle_put() before break > which could avoid resource leaks. > This patch could fix this bug. Don't ignore previous feedback -- pw-bot: cr