Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9c07e4f6-2cf5-b53b-6b48-bd4df8798ee9@nvidia.com>
Date:   Thu, 6 Jul 2023 19:11:58 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH blktests v1 2/3] nvme/rc: Avoid triggering host nvme-cli
 autoconnect
Content-Language: en-US
To:     Daniel Wagner <dwagner@suse.de>, linux-nvme@lists.infradead.org
Cc:     linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        Hannes Reinecke <hare@suse.de>,
        James Smart <jsmart2021@gmail.com>,
        Martin Belanger <Martin.Belanger@dell.com>
References: <20230620132703.20648-1-dwagner@suse.de>
 <20230620132703.20648-3-dwagner@suse.de>
From:   Max Gurtovoy <mgurtovoy@nvidia.com>
In-Reply-To: <20230620132703.20648-3-dwagner@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDhWQXFqclYvV2ZKMThnWVNGNDc2dGNIc215N2RSNWN6ZEIwZnp6OEl1YlNp?=
 =?utf-8?B?Z1VzSTRiZmp1TzlKOEVncFZoNTRrbHdXVlFmT3RFVXRYSzM2TUQ2ckY0WkZs?=
 =?utf-8?B?dUhHRnUwbFMvM3NxbFVqQitNWi9GZnNrRm9OaGR6S2JWc0VCY1VaUXRnZWpN?=
 =?utf-8?B?MkpZUldaM1BkYWdQS1R0aHRSOXFUeUh4djNQdzNpNjdtWG01YlhNSHhtV0Ey?=
 =?utf-8?B?cVAzdEdwYTRXWDVHcHMzVU5neWVGM1ZUalR1Rnh0M3hrQ2x0M1NNS1ZOOHJU?=
 =?utf-8?B?RnNwSGwva2xQRlNneUJFcWFza1MxSSs3QzNaTW9pOFZSUk1PaWdzZ3Z0Nndo?=
 =?utf-8?B?T1gzUXNwR0JzTzc2ZmdrS3hBUWs5UkRkbHloNVFFV2xVeDBpZk96eG1qY08r?=
 =?utf-8?B?WWxqaXUwZ0lYRWJrY2VkVGxzNTZDVGZzeHdkbFpma1R0cXROWmRmbXFpc3dT?=
 =?utf-8?B?K1F1eGFnQkl3MGJGanJ2K3l5cHlPWWRMaEx2WC9OeXRKUEg0TmY5c0c0N2FK?=
 =?utf-8?B?NTZkTlFJNVV0dEJQK2pMQWVyaXpQaE1SU24xdjVuQXAySm13UDBuNTUxVk9O?=
 =?utf-8?B?WW90L0lwQWJ1MDVuLzdkRGRycU5kbkZjSGs2TzNER3pRdURxVEpLT25Lbktt?=
 =?utf-8?B?azRWcG4yOVozang2MlNwZjN3UEd3SW5wdlJUWGhjOUxOQm4xUm9PSU9yOHBq?=
 =?utf-8?B?YXFHN1pjcTB3VEtDNzVWZU1iY0dQbTFwNVMxR2ZIbTZhQkpzdS9YUUtUVE5o?=
 =?utf-8?B?NkI0NVJrNDV4UDExMUNuNlZ0ejY5WTdUVWV6LzFlc055NmovSzNUUVgxVnpT?=
 =?utf-8?B?VGRxOXZpRDlUY1J3aXFKY2FXYUtCTEdXYUFBNnQ0dnRPL3lBNWFLTTFCc010?=
 =?utf-8?B?K0QrclR5ajNLQ2U2UWFBZE9TN2ZkY3g2aHBxSVZ3YkRRb2t5Z3RjL3FOSFFm?=
 =?utf-8?B?WTVOVFBRVlFaLzhHcEhBbVl2R2FjVkZGL2pnbkJEaHpoS2Z1NkJHSjIxYjVP?=
 =?utf-8?B?bTdTYXFtNmVScnpvb3k0Zk54cGJ4bytBLzM4MjNzN2tDeGdXbk5MMENNU2Ir?=
 =?utf-8?B?ZHlURVNPdUFKdHRuT3lnanQ2VlhzM2pzMnZDL0VpM1R6aXpWR1hrWlVOYWUz?=
 =?utf-8?B?cVovMmVST2NCVll0aWU1QmNETTI5QkQzSm5naGkzVlRFK1I1Q0ltTzh0OXh2?=
 =?utf-8?B?Rm54eVA1V3oxZFhmR1pCRXZiQzdNQjZzU3lQV2hWdGtpckVQdGV3TTFERU95?=
 =?utf-8?B?T01lLzRlYTFQRzFldWI1U2pzZGdUalhCQnZoZ3kydXZ5amdKMEhxZHRSbm8r?=
 =?utf-8?B?RERvTVRiM282VERnUVZubnllcVVvNFNORHNFbUtSOTI4ODJGZ1hpVHVuV0Rl?=
 =?utf-8?B?Y3ovWEl4RkI0SURzZ0JzTFVhaHpnbEl6WDlTOHlVM0tUS1lWRFVrZyszTDA4?=
 =?utf-8?B?dHFTWmtDVkRGN2FjMFhBTjRRZU5KWnBaeUdVNUhjaEZmVE9xRFl0SzgrajlZ?=
 =?utf-8?B?a1JsL0E3SjMzZTVhejZUa0V0MXY0dGJCSnY4cEVLVk1VYk1pTW84NmZUVm9w?=
 =?utf-8?B?ODk0dUp1T29VS0xFN1NITjhNQmFJWDlkRHJ6bmtnWlhKcTVQMGE1MEJyVG55?=
 =?utf-8?B?VlExdE5NMS9JY2E4ZGZoUFlhL3VKSHpEcFpJQ3JsdERLMnE3eDU3OWhEN1ps?=
 =?utf-8?B?VUF0bmNoUWZvSE5TNjdEYjZMNk85TzhiZUVjVjVqQlZRYlRjWFMvNjJsQ1E3?=
 =?utf-8?B?QXdZOXoxTFBtSU1KaFpPSW1TR0IrZmk1cDdsaW9jVjBHS09ER1J6MFR2ZVNO?=
 =?utf-8?B?NGVkSi9uUWtPTWxMeHdtYzdqZ1FrMTV2ZUZFdFdFYWc3Ry8xWE0rRzhuTkVX?=
 =?utf-8?B?Wm9LczIxdjNCZURqMElwbUx3cHRNcjRieWJzS3Uzcml1NS9vTlZwUVB1bnc5?=
 =?utf-8?B?UldWVVp1Y2N0Rlh6R3R5L3dNd05PNmZ4V2U4UGt1TmxJblJaWXh0bmVuS212?=
 =?utf-8?B?L29nZXgwVVF5aWlza0sycHM4dDU4ZjVyRENsRmtDVmlOK25QeTdrTG5oV3VX?=
 =?utf-8?B?Tjc2V1duZ1hvTXRWRlVjb2c4MERTNGJOVk14ck1RRC83ODliR2FCeXp4ZlJL?=
 =?utf-8?B?dHVHajk3c1ZXSTVsSXl1aHdYYTRkSGtvbGxSNHJmbm9HTDJKcWpvOGNRZ2Nm?=
 =?utf-8?Q?SN5+U7MudwEo1pYEjShBWphWKCaTVxKP8PaPc2x0oeEy?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dad02193-913f-464a-70b7-08db7e3bbe5a
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5040.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2023 16:12:06.7300
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nrk9cibM13VmyAzxumqSsVXVLmDtHEwUAFraiTh3nZV8d87T8f10ZGozgFMqoykHyW1y9PNk7zER0Hv1i0CrNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7017
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 20/06/2023 16:27, Daniel Wagner wrote:
> When the host has enabled the udev/systemd autoconnect services for the
> fc transport it interacts with blktests and make tests break.
> 
> nvme-cli learned to ignore connects attemps when using the
> --context command line option paired with a volatile configuration. Thus
> we can mark all the resources created by blktests and avoid any
> interaction with the systemd autoconnect scripts.

why would we like to ignore connect attempts during blktests ?
We define unique nqn/ids/etc. So we never should disturb other running 
services, unless it uses the same parameters, which shouldn't happen.

Agree on setting the hard coded values for hostnqn and hostid instead of 
reading the /etc/nvme/* files. This should do the work IMO, isn't it ?

> 
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>   tests/nvme/rc | 73 ++++++++++++++++++++++++++++++++++++++++++++-------
>   1 file changed, 63 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index 191f3e2e0c43..00117d314a38 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -14,8 +14,8 @@ def_remote_wwnn="0x10001100aa000001"
>   def_remote_wwpn="0x20001100aa000001"
>   def_local_wwnn="0x10001100aa000002"
>   def_local_wwpn="0x20001100aa000002"
> -def_hostnqn="$(cat /etc/nvme/hostnqn 2> /dev/null)"
> -def_hostid="$(cat /etc/nvme/hostid 2> /dev/null)"
> +def_hostnqn="nqn.2014-08.org.nvmexpress:uuid:242d4a24-2484-4a80-8234-d0169409c5e8"
> +def_hostid="242d4a24-2484-4a80-8234-d0169409c5e8"
>   nvme_trtype=${nvme_trtype:-"loop"}
>   nvme_img_size=${nvme_img_size:-"1G"}
>   nvme_num_iter=${nvme_num_iter:-"1000"}
> @@ -161,6 +161,50 @@ _nvme_calc_rand_io_size() {
>   	echo "${io_size_kb}k"
>   }
>   
> +_nvme_cli_supports_context() {
> +	if ! nvme connect --help 2>&1 | grep -q context > /dev/null; then
> +		    return 1
> +	fi
> +	return 0
> +}
> +
> +_setup_nvme_cli() {
> +	if ! _nvme_cli_supports_context; then
> +		return
> +	fi
> +
> +	mkdir -p /run/nvme
> +	cat >> /run/nvme/blktests.json <<-EOF
> +	[
> +	  {
> +	    "hostnqn": "${def_hostnqn}",
> +	    "hostid": "${def_hostid}",
> +	    "subsystems": [
> +	      {
> +	        "application": "blktests",
> +	        "nqn": "blktests-subsystem-1",
> +	        "ports": [
> +	          {
> +	            "transport": "fc",
> +	            "traddr": "nn-${def_remote_wwnn}:pn-${def_remote_wwpn}",
> +	            "host_traddr": "nn-${def_local_wwnn}:pn-${def_local_wwpn}"
> +	          }
> +	        ]
> +	      }
> +	    ]
> +	  }
> +	]
> +	EOF
> +}
> +
> +_cleanup_nvme_cli() {
> +	if ! _nvme_cli_supports_context; then
> +		return
> +	fi
> +
> +	rm -f /run/nvme/blktests.json
> +}
> +
>   _nvme_fcloop_add_rport() {
>   	local local_wwnn="$1"
>   	local local_wwpn="$2"
> @@ -235,6 +279,8 @@ _cleanup_fcloop() {
>   	_nvme_fcloop_del_lport "${local_wwnn}" "${local_wwpn}"
>   	_nvme_fcloop_del_rport "${local_wwnn}" "${local_wwpn}" \
>   			       "${remote_wwnn}" "${remote_wwpn}"
> +
> +	_cleanup_nvme_cli
>   }
>   
>   _cleanup_nvmet() {
> @@ -337,6 +383,8 @@ _setup_nvmet() {
>   		def_host_traddr=$(printf "nn-%s:pn-%s" \
>   					 "${def_local_wwnn}" \
>   					 "${def_local_wwpn}")
> +
> +		_setup_nvme_cli
>   	fi
>   }
>   
> @@ -436,18 +484,18 @@ _nvme_connect_subsys() {
>   	trtype="$1"
>   	subsysnqn="$2"
>   
> -	ARGS=(-t "${trtype}" -n "${subsysnqn}")
> +	ARGS=(-t "${trtype}"
> +	      -n "${subsysnqn}"
> +	      --hostnqn="${hostnqn}"
> +	      --hostid="${hostid}")
> +	if _nvme_cli_supports_context; then
> +		ARGS+=(--context="blktests")
> +	fi
>   	if [[ "${trtype}" == "fc" ]] ; then
>   		ARGS+=(-a "${traddr}" -w "${host_traddr}")
>   	elif [[ "${trtype}" != "loop" ]]; then
>   		ARGS+=(-a "${traddr}" -s "${trsvcid}")
>   	fi
> -	if [[ "${hostnqn}" != "$def_hostnqn" ]]; then
> -		ARGS+=(--hostnqn="${hostnqn}")
> -	fi
> -	if [[ "${hostid}" != "$def_hostid" ]]; then
> -		ARGS+=(--hostid="${hostid}")
> -	fi
>   	if [[ -n "${hostkey}" ]]; then
>   		ARGS+=(--dhchap-secret="${hostkey}")
>   	fi
> @@ -482,7 +530,12 @@ _nvme_discover() {
>   	local host_traddr="${3:-$def_host_traddr}"
>   	local trsvcid="${3:-$def_trsvcid}"
>   
> -	ARGS=(-t "${trtype}")
> +	ARGS=(-t "${trtype}"
> +	      --hostnqn="${def_hostnqn}"
> +	      --hostid="${def_hostid}")
> +	if _nvme_cli_supports_context; then
> +		ARGS+=(--context="blktests")
> +	fi
>   	if [[ "${trtype}" = "fc" ]]; then
>   		ARGS+=(-a "${traddr}" -w "${host_traddr}")
>   	elif [[ "${trtype}" != "loop" ]]; then