Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Jul 2023 11:27:06 -0700 (PDT)
From:   "Lameter, Christopher" <cl@os.amperecomputing.com>
To:     Christoph Hellwig <hch@infradead.org>
cc:     Julian Pidancet <julian.pidancet@oracle.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
        Kees Cook <keescook@chromium.org>,
        Rafael Aquini <aquini@redhat.com>
Subject: Re: [PATCH] mm/slub: disable slab merging in the default
 configuration
In-Reply-To: <ZKbKcMehHbo+7cPU@infradead.org>
Message-ID: <fa76dfe5-c9b8-d24b-89a7-2f906e2b1caa@os.amperecomputing.com>
References: <20230627132131.214475-1-julian.pidancet@oracle.com> <ZKbKcMehHbo+7cPU@infradead.org>
Content-Type: text/plain; charset=US-ASCII; format=flowed
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uI77/zVFjA7dIFNav3Bw94cfd+QP9hsoMWpCVifXtQfFM/xt/bDURMaV33n1?=
 =?us-ascii?Q?mkPuoq70vpk51napcBZQvT2aGT9yu9F3HSigC0ESnCCjUdbrp0aNTT1B2QUy?=
 =?us-ascii?Q?sjqRg0RwAVyZYoWpi5WRD5Vzhmb5bFd6zidwu0FpYTcP2ECELk3SDFxT7pe2?=
 =?us-ascii?Q?NfFgdKU+j5Nd7y5a8QJ3t2FN2mVbsCYPw/O0FsS5kb2XPq7QeWpu/UnRVYMH?=
 =?us-ascii?Q?OTMNc1cLK9rZWivp0EtTqr3gBtrvbIyyfL8PSu3DhlARBHDqQRFt+edd2V1l?=
 =?us-ascii?Q?QBDVIImGvJVIPHuQS7fFmEmAtF1bjjEuJS8dWEWYsDlRTHPerPOjZc74bjvq?=
 =?us-ascii?Q?SaH+Ptl+oKmhAbe/w18FLHoyXc1oivmInruFfSEoDQPuDUQUyBe4Z3VsBACn?=
 =?us-ascii?Q?J8ACaGRAzJODBLhMIMoYTYYju3orYcCmQEuaLqFnSj2QV8qn8rdLVivBlAas?=
 =?us-ascii?Q?Raj12uArDCAevnx0unuLNC/KMNkD+ug4L2fbh98uJCtu9/pv/tuzLac9IJ0h?=
 =?us-ascii?Q?HHllksjMICCJGVFkTTIT2+i8Ubr4ULrSdXMiU5fjALFr3orRWH1it2uiaCxl?=
 =?us-ascii?Q?D573lP8FULXY8l1wGFmaOLwzsJhCDhZfRAyXVDf9GSMMGcp+mXFbWD6sxUev?=
 =?us-ascii?Q?6Pkigr+gaT8vwCTe4XH612I8ffZs8B1RnlXJrjuQULjLafxZ7RXaGqRS7B1A?=
 =?us-ascii?Q?kLkxOjbtKaEDpJi/uzr6dvyxQakCmi9wmFVD0zwAXY0yBifj1H4WunUGgIyn?=
 =?us-ascii?Q?6bYupRzorsKIY7oyFAgOIH2WFKv378wGeW8WedCbqQMJD8KIpyBW91aup0JI?=
 =?us-ascii?Q?7zAjm+xvvNslNlutclCZRQHNYJLPA7tMEFoNAwV8y80qXNnGaG2kHbt5Sfz6?=
 =?us-ascii?Q?l+TPMKENf7aqsJVUnO/L4InWyr4ZJdgO0jOOkjmBOTPOykibFbL4FKcRteIN?=
 =?us-ascii?Q?scjZH1g5X6AErmpGK767YVPTgWiN65E+OmQmL3f2cZJIw3C8jTDQ+W+huW5E?=
 =?us-ascii?Q?kec7zeB68rqbbYtQwjvBLQVvJ7JYOtzoOwZTzUGoUCjuTkxJJ/Wgs2UlhZ4f?=
 =?us-ascii?Q?Y1aaStY7zFvdXoP0OtBSf3WyVmid2ClzUb3q8Cnev1b3YRexTegIvS3nQptb?=
 =?us-ascii?Q?M24hHXdTtBeI+prmIykl0wJTOyPFOoffK4KSKnbj4iKbsp2IWf8HbrC/EVJI?=
 =?us-ascii?Q?D8RKYQ4Eggwghl+LUH59z4HI9ZY+kd6XtwqytvyOa98l117LYsCSvgmhJ+xF?=
 =?us-ascii?Q?8bxdNkq+ZrfHm57OSn61VKnoYupN4Qs/9LXSKrIrpzqf5S26bFm9bO/aWG/I?=
 =?us-ascii?Q?TxKcwe4m0grG8bMkmNQgaM3UWqPjgjExM6SApAIdeGSbmLDi7J4bpZf3I9iy?=
 =?us-ascii?Q?L8YWyT1q1zMeBryHOYv/G3prFV8hYnmMAojo1Re3VlfTzwIwuzd9sB0kJhLN?=
 =?us-ascii?Q?UxruvR/SFTe+NZppWm67V8KV1octYskIs8ldqm4V3qq/exRjatqkMG/qZY2U?=
 =?us-ascii?Q?q8x+edKlkz5u9quPx+PG9WKuTgHanqYT0OkDksJGgIVUuKloepK1e7H+GY2S?=
 =?us-ascii?Q?tqrJRAwltB1vjDr4qR+lB3gjVxaYrpggZ8oFr0IsphzYXtgPJxdNPk07CflV?=
 =?us-ascii?Q?Tg=3D=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a95de36-b5f4-4d8a-3f68-08db7e4e9dee
X-MS-Exchange-CrossTenant-AuthSource: DM6PR01MB5259.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2023 18:27:12.6664
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hZTITHUY+R5le2Ok4dqzQI9Mf3KGi5CWa4/sR0kCtFi9NdglETWkMSWKm656YsJzuZ4PU7ufesp9Hv8Zs+9gStepm0rowqsQgg142oH+8jk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR01MB6589
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 6 Jul 2023, Christoph Hellwig wrote:

> The slab merging has always been bothering me as it makes debugging
> things really hard.  I agree with the other comments on improving
> the commit log, but with that:

Debugging is enabled by specifying "slub_debug" on the kernel command line 
which disables merging and also enables checks so that data corruption 
does trigger meaningful messages for debugging.

Without that you may see errors coming from the slab subsystem that are 
due to data corruption by various subsystems. Without that it will be 
difficult to properly attribute errors anyways.