Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp30931307rwd; Thu, 6 Jul 2023 12:54:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlGiDCO9N5pvSn0nvHiaprr0dlaaQWek0usSjIukdMyDktw5zgCKmLZv0z2GeC7jV5ie7Htp X-Received: by 2002:a17:902:d48c:b0:1b8:b288:6274 with SMTP id c12-20020a170902d48c00b001b8b2886274mr2614043plg.18.1688673248657; Thu, 06 Jul 2023 12:54:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688673248; cv=none; d=google.com; s=arc-20160816; b=JLRQCVPhl2ZSya2SQDz7vd/1Yhrm/TTmUqYsyv5I2Rrftqfby2QJKzn5wVMGkdOMuH ZslQVxatqbgbCVAj2ITVwtQqMgqyhTUaYzEgqVFbnWv4P7ECp5RMm0t+kDSNakUm93/o ojbTMh/XsTKOqbByuvvkm7lXDPAZa6LS4imMdIdEg7pSxm91awTtW7Gzvc47HulpYQQo NRnMIXYOtC+yCGK9pFY7BOKlm5B9y0Ip+CxXmB5BJ0bJSRLNXoj5NZCRWz+OxoRG4cqO dbZm6vXYcvj1bSrSS1Y+THRepLbLQy0rtY2koqxK069T2VqLXsZjYcuGqx+9+DDnCddP GOsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/lzJT5FgwDvChrayhIE8uP+Q5Qrf9eUTpgkA05PLe9g=; fh=M8osTdaNMcCNHrU6rS+c+iqq7VlM+cvp6rvdpx5Z9Ac=; b=hWcXlj71tQDN5VU+O5po1eQwk5X8yn1Jaim6MaiAQzBgmpR+vN/ovXHkQVDM9G3UJn E9vyjFVy29PVH4yl6haCd8jMGDv2wQ6mIaQMmLLnpMQqKj9/Qs7UdIFssI0h0l1KtkYR XnWOsiL/8HWmDogXhCesjNfC6D/xY9cHMS9Cfn0l2dGTcirEdqWNAxRqO0N4yvUuDWvF 96TDKaKF5Ul075Q8FstHgdLaeuwIC1fR92mcOgC/XP+9/jNitEr8yhNaFNW7r2cN1C0+ xVcE50GBsQ1ULRifSXA3691DCqc7Xs7T1CeyyjGd48Y2qP5EdeAdmR8cmDzmCchAX8oY qo5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nP1N0x4I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l10-20020a170902f68a00b001b89cda5e11si2089378plg.425.2023.07.06.12.53.54; Thu, 06 Jul 2023 12:54:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nP1N0x4I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231269AbjGFTgW (ORCPT + 99 others); Thu, 6 Jul 2023 15:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbjGFTgU (ORCPT ); Thu, 6 Jul 2023 15:36:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 664A019B7; Thu, 6 Jul 2023 12:36:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 007066119F; Thu, 6 Jul 2023 19:36:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5B9BC433C8; Thu, 6 Jul 2023 19:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688672178; bh=/lzJT5FgwDvChrayhIE8uP+Q5Qrf9eUTpgkA05PLe9g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nP1N0x4Ii4JSYrh89o8puWKJNSXfMWKkHigRxz3VPBH9RnDrm5H04ME59OIBmEvWH cHf26fkZrsM1kbLB6yNrZE7asm/bnzQ2/Smboxotlpslb9zDBZVdCicn7x9Ih2fb5g V/y4DPeUyQMLYkW8/5xrY/pS5zgIK0cwdcLcs4Nts7dbsnUtnPFGh5QX1RFwImi84h Pr9zu+j/RNKkYAKcsQQ2/f6R9ZyMNICv76xSwZFl+OvQ6rtc/o434hQQyf0GBbg682 Q6BLgSXTAIiw0GPSfgIAeJXq84tv+KLDIYy+KW5OEbZiisSKiGz9RSFGm6uG9tMwxm 6GezZlMD9uVLQ== Date: Thu, 6 Jul 2023 21:36:14 +0200 From: Wolfram Sang To: YE Chengfeng Cc: "andi.shyti@kernel.org" , "rjui@broadcom.com" , "sbranden@broadcom.com" , "linux-i2c@vger.kernel.org" , Linux ARM , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" Subject: Re: [PATCH] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue Message-ID: Mail-Followup-To: Wolfram Sang , YE Chengfeng , "andi.shyti@kernel.org" , "rjui@broadcom.com" , "sbranden@broadcom.com" , "linux-i2c@vger.kernel.org" , Linux ARM , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Aw1VKsa6Y9g8S+lk" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Aw1VKsa6Y9g8S+lk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 24, 2023 at 07:36:02PM +0000, YE Chengfeng wrote: > iproc_i2c_rd_reg and iproc_i2c_wr_reg are called from both > interrupt context (e.g. bcm_iproc_i2c_isr) and process context > (e.g. bcm_iproc_i2c_suspend). Therefore, interrupts should be > disabled to avoid potential deadlock. To prevent this deadlock, > use spin_lock_irqsave. >=20 > Signed-off-by: Chengfeng Ye I can't apply it, what version is this against? Also, if someone could supply a proper Fixes-tag, this would be much appreciated. --Aw1VKsa6Y9g8S+lk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmSnF64ACgkQFA3kzBSg KbYXog//bWuH5tT+g+rfzCtBvU9hPR74K3YyGxSwnQm5JxFA4wyclH0H35sZ6Jnf 87X8j5AcJzmVVf8Px/MKkppsXuxGq1oa8lkwaksbTltZSLzCewlSSOPjWqSKW3sf CcUHROKMvjGaCnRvEZvfRWx/7Qu2b7b+y0Ly8M5TDEYAqtcYeaXzmeyF5OU9C023 YiLoZTKyQSDvgOz6/+FEJ4d+5mj9+zU6tT3Kc06DuSTrc9mcqF2O5qD7to8CgZbL CrvLnN2HS4ajHnVBObrYgL98hQsIwjfi5d2QwB6Sa1Y32VFQwZQ1oNrGz5QqXn/B gmjJg1nOBBfccU1Ik+XqR4tqjiW5HcUGnMkJs6fZabG5oOc/s9x2/5Ob0UdJXxoK TtEZKFH467ZagVEOgiGgzyFZOSbxFBKuuDvmJ+Nv1wn+PEv0Rov7yC9VjLVN3d8R Kxme8nhvKYjaYu3geIYgAcrlD8zdjvZXTjqVvMhadz7cITOfOBF8VAGGT/aBu1t1 GlXTgwlB7tG9QEX13kY0gASE5Oll8TDUc3nRkUu1fLPA24sY5AaVEUvqWDN5S5IC THMfKexeL5PUZeWSBUXQ1jXRjvpgzLz7JWqMpHVGKBN5sKYUyVo4zjbnGanTwBYa z6jQ541Di84pis+5W9v3IjPSH3P2903DquPgeSbV0dzas52so2A= =x1Cp -----END PGP SIGNATURE----- --Aw1VKsa6Y9g8S+lk--