Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp30984487rwd; Thu, 6 Jul 2023 13:49:14 -0700 (PDT) X-Google-Smtp-Source: APBJJlE3PjT+mK9c5UFWLkxQxYcUZ0ypKgAu0kcay4skYS9QaHgdwA8mgDCSnVtvw6D7/skUKqwA X-Received: by 2002:a05:6a00:3015:b0:67a:20d0:b9bb with SMTP id ay21-20020a056a00301500b0067a20d0b9bbmr9815813pfb.1.1688676553927; Thu, 06 Jul 2023 13:49:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688676553; cv=none; d=google.com; s=arc-20160816; b=OpvRoRuL7wpjHRhD5Y2igVxFAovJTPuaWf1YnWlCwd/A3CqSTSFzrSzEXg7uquzVdZ RsLZmtN4MNaX5I0Xgnx8gXyod9Y9eWitgVFCwXgBSIcN2/+IpWQGQlk01h5WWjwQVDAt qa0K/YxfEDs1NwRBsIwBTkDa7gLAiZoJNMgpNDw19TEnhpjNy7L9fs5QNzWSWJvXyVIn 0AUPsHtgQ9WgpSdvS2Z9F8xRbOIDeDWEnYYRqdpGuRRqDb627tJKMdiDLLeJyVK2rN00 qqJCRBaIo8yJD1lDEOKlbSKRjBUXqrehe+AQhUdiBey17S1rbn63M4G+N4WIr1utxf66 5LJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=goTJCh2BuleVgu8hJNaBlgxPFcS6fDBL6v0oOW8Rpas=; fh=YbtZ8hlw0P2xz4nDDFP/16C2kVR6KKgxQTHu29bVfH0=; b=lbmhmqORWPvEiNSTpa1jZLdXNRPHEQwEUPFYokdoBpQ/pJPpjlQCQ6kUHxtE2TTPLa UpnFHmm1DdFj37MGK77EK/h+EYtX0t73OuK85ToFFjCOpyjvgNmwSKda2YeZFWv1aVS/ GBUCe2u7yz/P+tQzkLjntUEPBbWgaLuNmrXUuhH/oSWeFmWpcAzxMN4ZWDcCabMD5dzh rmuDOahT5pQ8LJU9dIdZTnHHGIrESiqOWImUwG2FRGWGFMOOsyMt4EiLxPoW60z0SY8V ZfXV+XWU1usVktgCD9uPOCn0L7+ZQt/Kado3j6nVHq5eew2ur3YwZx+AatSUF6KCoTgD JTsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=kaWHGjB1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s32-20020a056a0017a000b0066957b1c0a0si2260016pfg.288.2023.07.06.13.49.01; Thu, 06 Jul 2023 13:49:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=kaWHGjB1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232621AbjGFUOY (ORCPT + 99 others); Thu, 6 Jul 2023 16:14:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232317AbjGFUOW (ORCPT ); Thu, 6 Jul 2023 16:14:22 -0400 Received: from smtp.smtpout.orange.fr (smtp-19.smtpout.orange.fr [80.12.242.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B59F1BF8 for ; Thu, 6 Jul 2023 13:14:20 -0700 (PDT) Received: from [192.168.1.18] ([86.243.2.178]) by smtp.orange.fr with ESMTPA id HVMmqW6WO8cFBHVMmqGNyt; Thu, 06 Jul 2023 22:14:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1688674459; bh=goTJCh2BuleVgu8hJNaBlgxPFcS6fDBL6v0oOW8Rpas=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=kaWHGjB1nftlx5hiWASp9S35FQy/7g7gZh1qa5VHSEcUyfZx2tCDAqZfPI86IU2Su SUIJ+BHF5JgDlBkDl6kA47sAHWs0/LknqKP0SHgVhipzovfSCq12fdFMx/w2aZN4MA /jaPBNDlAjDWPgnv+0/sZ5qK3kzAjY5YbaA4UTlEXz7wADyG6uUfxB15zk04OZxs1B n2NeGsNsBR9yZJh6rJ9q41jSyFUPIXEG0P3p+DeoYoSNxFn+Od6wmENQUZDICQm+3T 6fcZsF4ygz6vkZ6YmzIECfK245eIL3Osm07BCi+L1nm6qWT7jcs0eBaumruz77BQNt LlsuxQAD8YAAw== X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Thu, 06 Jul 2023 22:14:19 +0200 X-ME-IP: 86.243.2.178 Message-ID: Date: Thu, 6 Jul 2023 22:14:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] scsi: bnx2fc: Remove a duplicate assignment in two functions Content-Language: fr To: Minjie Du , Markus.Elfring@web.de, Saurav Kashyap , Javed Hasan , "supporter:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER" , "James E.J. Bottomley" , "Martin K. Petersen" , "open list:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER" , open list , Laurence Oberman Cc: opensource.kernel@vivo.com References: <20230705115236.16571-1-duminjie@vivo.com> From: Christophe JAILLET In-Reply-To: <20230705115236.16571-1-duminjie@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 05/07/2023 à 13:52, Minjie Du a écrit : > Delete a duplicate statement from these function implementations. > > Signed-off-by: Minjie Du > --- > drivers/scsi/bnx2fc/bnx2fc_hwi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c > index 776544385..0474fe88a 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c > @@ -1521,8 +1521,6 @@ void bnx2fc_init_seq_cleanup_task(struct bnx2fc_cmd *seq_clnp_req, > FCOE_TCE_TX_WR_RX_RD_CONST_CLASS_TYPE_SHIFT; > task->rxwr_txrd.const_ctx.init_flags = context_id << > FCOE_TCE_RX_WR_TX_RD_CONST_CID_SHIFT; > - task->rxwr_txrd.const_ctx.init_flags = context_id << > - FCOE_TCE_RX_WR_TX_RD_CONST_CID_SHIFT; > > task->txwr_rxrd.union_ctx.cleanup.ctx.cleaned_task_id = orig_xid; > > @@ -1763,7 +1761,6 @@ void bnx2fc_init_task(struct bnx2fc_cmd *io_req, > FCOE_TASK_DEV_TYPE_TAPE << > FCOE_TCE_TX_WR_RX_RD_CONST_DEV_TYPE_SHIFT; > io_req->rec_retry = 0; > - io_req->rec_retry = 0; Hi, just a blind guess: io_req->srr_retry = 0; ~~~ ? > } else > task->txwr_rxrd.const_ctx.init_flags |= > FCOE_TASK_DEV_TYPE_DISK <<