Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e2be9c20-4e0c-7880-ba0d-11b8f2c5404c@infradead.org>
Date:   Thu, 6 Jul 2023 16:29:26 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: linux-next: Tree for Jul 4
 (drivers/net/ethernet/microchip/lan743x_main.c)
Content-Language: en-US
To:     Simon Horman <simon.horman@corigine.com>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Bryan Whitehead <bryan.whitehead@microchip.com>,
        Network Development <netdev@vger.kernel.org>,
        UNGLinuxDriver@microchip.com,
        Pavithra Sathyanarayanan <Pavithra.Sathyanarayanan@microchip.com>
References: <20230704134336.4c5d1772@canb.auug.org.au>
 <725bf1c5-b252-7d19-7582-a6809716c7d6@infradead.org>
 <ZKc2DLIroSNi4tgs@corigine.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <ZKc2DLIroSNi4tgs@corigine.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Simon,

On 7/6/23 14:45, Simon Horman wrote:
> + Pavithra Sathyanarayanan
> 
> On Tue, Jul 04, 2023 at 03:25:31AM -0700, Randy Dunlap wrote:
>>
>>
>> On 7/3/23 20:43, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Please do *not* add any v6.6 related stuff to your linux-next included
>>> branches until after v6.5-rc1 has been released.
>>>
>>> Changes since 20230703:
>>>
>>
>> on s390:
>>
>> s390-linux-ld: drivers/net/ethernet/microchip/lan743x_main.o: in function `lan743x_phy_open':
>> drivers/net/ethernet/microchip/lan743x_main.c:1514: undefined reference to `fixed_phy_register'
>>
>>
>> Full randconfig file is attached.
> 
> Thanks for the config.
> 
> I bisected this problem and it appears to be introduced by:
> 
> 624864fbff92 ("net: lan743x: add fixed phy support for LAN7431 device")
> 
> I wonder if the following change in dependencies is an appropriate fix for
> this problem.

Yes, that change fixes the build error. Thanks.

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

> 
> diff --git a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig
> index 24c994baad13..329e374b9539 100644
> --- a/drivers/net/ethernet/microchip/Kconfig
> +++ b/drivers/net/ethernet/microchip/Kconfig
> @@ -46,7 +46,7 @@ config LAN743X
>         tristate "LAN743x support"
>         depends on PCI
>         depends on PTP_1588_CLOCK_OPTIONAL
> -       select PHYLIB
> +       select FIXED_PHY
>         select CRC16
>         select CRC32
>         help
> 

-- 
~Randy