Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Jul 2023 16:22:07 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Jiaqi Yan <jiaqiyan@google.com>
Cc:     naoya.horiguchi@nec.com, songmuchun@bytedance.com,
        shy828301@gmail.com, linmiaohe@huawei.com,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, duenwen@google.com,
        axelrasmussen@google.com, jthoughton@google.com
Subject: Re: [PATCH v2 4/4] selftests/mm: add tests for HWPOISON hugetlbfs
 read
Message-ID: <20230706232207.GC3768@monkey>
References: <20230623164015.3431990-1-jiaqiyan@google.com>
 <20230623164015.3431990-5-jiaqiyan@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230623164015.3431990-5-jiaqiyan@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OQqYpK8+nwb7X5Q6t5lTalIAODJ33P2FzeiZy3QYUwT+7+x42mAduCyMDyHd?=
 =?us-ascii?Q?6zH3zjOtXeEhq+sQ1oZM0RqNRLAC8DTCBgsC1LC9EMtxPzxa050fgOc4sgwr?=
 =?us-ascii?Q?juWhNThBhohVJrAescKWcKgFV70GLANaEg3uz13XZHIepPbeNezGK6eAFBEp?=
 =?us-ascii?Q?mPIp9zr/K2rKJWwh1hBne65o4mDcv2AXC2AhBtH1TauU2//SzbiDLYeeipMO?=
 =?us-ascii?Q?XSESgTa6cZ51Pw/4bu5YEBcaZqtDnwBDIEmjn1WqsRbKb4G8mDBI8MCx8Mgv?=
 =?us-ascii?Q?2hD//uFBSEEh7n6x0uFPgtHOIoZ2oCX2t5troM/xzgnltjGy6rXIx+oSXXYY?=
 =?us-ascii?Q?wH30YzwXf1lehHTuYOBuTPB0GZTKjVFq635YpEKp7ARUpYHoyeXn8OMaJTog?=
 =?us-ascii?Q?71mt0jLMOi40AfWtY3F7JPOF/qVWSfSDFzqOkp3xggR/+U8wXfg/N9Gt/kju?=
 =?us-ascii?Q?DBMwaFJEhCMD+zeR3NBZZS0L97ay3smn9/ysXQb9q/CPsKNUC/L29bD41/pO?=
 =?us-ascii?Q?A7Zopoe7BLpvsRq6Plh18fT/HgoEeVZAqQ7sjklVHxKVj9HqmIm6L3fH6800?=
 =?us-ascii?Q?ZtplsC0oQWYfp6YuKzGOkyt6mv/qOSXFJOV26UwegD+84u16rUAw/FSic3fh?=
 =?us-ascii?Q?77N5USvN0rEos/Hw6xtF+sEqqIgRdSrrwNw/CG4UVz9ZXK7/V55UgVmLO+tV?=
 =?us-ascii?Q?rtO747sVpJdZVbgbCPIUNI/A9Xwez7tM4lGyIVqPlBWiOcKfkyUOEIcMPdqi?=
 =?us-ascii?Q?mO1IOBfOokMPkd39wvPOqzEPHkwv5KJBz+jeAJ5wGysPD95ka2qaSEBENpwF?=
 =?us-ascii?Q?FiZ0HjQXbHIELrA/yHtYQL9/yuxsF4jOdTS71SlSUrRckQ0xkFmzJ3pnYpMK?=
 =?us-ascii?Q?SkeiuJYa5hp/4wCJ8Ekd4+mErArNOk7ZOesmK4nWpxWrOp9KMxTHXKCoM4pN?=
 =?us-ascii?Q?rAY6cS5WGUmbM6dhoGFj90RWisrQgOpsRqZnlNQfOtu32wCxra1Mt4rB3PXu?=
 =?us-ascii?Q?HiEuglrFxlV41z2HwpIGyLB5z/zEimkUTSyG1cUAureU0DGNu4WqwA7mIAoI?=
 =?us-ascii?Q?CZP+DvWMDBqmxSC+ppsvBVDj2ZVIeNnba8D/fS/tbo/DQtGT5MDaKsexITnS?=
 =?us-ascii?Q?AbKradDW3zdAC9Dq9pEMl7OjyEkZjacl49ggm263BOePW4cGq/aUoAZLD49z?=
 =?us-ascii?Q?dyKCCmoQbkQ4b31b1Zm01Pvs520st2f6VTSAkgciTWlZs7BPNWaGZzPaHC41?=
 =?us-ascii?Q?THgEdYsxNn4iJT832M+6EFONBki72kxjwxh3juxIVQZGnzNHw5rVNwUvHVsB?=
 =?us-ascii?Q?H+r9am/ADEqwE97Y3WRTtQAIJnAZ49N1Zx/rJma8WbEvkCBv6WY7mPSi16h3?=
 =?us-ascii?Q?uGwXBQ2Eoq8dkiMXSQQkgbuOyYd3xtIC5nTXgTIi/ZO/xmJQCzAlDXfV7iaR?=
 =?us-ascii?Q?YaFBmi7h494MYnDmE5/zihOLF3fi31hZ67t/BsfcO/TeUZM4BH2WyUUthtG2?=
 =?us-ascii?Q?3CiEWgFH4tJZdBTQV3oCpJt5znqygOuSivJlFEixq0h0WYN8HgVXpD9Z3DXR?=
 =?us-ascii?Q?JaTjGdNgNyYcPWae9r1oUhK1peN8rFG1p30/C8tKK7FanESbB10ds18eyHDl?=
 =?us-ascii?Q?BA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?0lsJo17jltb04jvL1op9ZavrZ2fq69gXJiONq5GYOk9uhtmREPlcPh3B14Zv?=
 =?us-ascii?Q?MWzyGsAdGnQ6eqJiY4c551URsTbFwCbf5ytdiZxOn0EztSSgtoLOUnmcIVof?=
 =?us-ascii?Q?U2NQ35t3ZYiEW6kulrfwtVbGyoClg1Z1GVs1zTU219skaUXIAV7nCGIbqqel?=
 =?us-ascii?Q?Ae6HDjShMb8YiXKfBHZtnGUgb34ZoIyOEnetwThGnlX2VmUViZqwVqmEZ/vR?=
 =?us-ascii?Q?ccPplhIrOTSE2+ss4mDLjzrI+24tizJD4WWg8SG3e8Qe7bbIYIDg0uOY7ipr?=
 =?us-ascii?Q?PQf3RN4+tIApW7d+U/bjpfpUNH+Stvht+DHlkMaR2Kv3S3nvcnjmZb2a9TFk?=
 =?us-ascii?Q?AnTvks1g0zH73odQ+EV/oUw2jmV8o71xYKjVT7Cpm4Go5guw3SJxRdhuoJOM?=
 =?us-ascii?Q?Y73iQdQFDkFqfzPVJGXoRM4vWimXjcIWnb/orKLvSM7J9ZjoO1Kvv+aF3BY2?=
 =?us-ascii?Q?ZnonjIyk07jYMJdWGsWPhDjZA7vy6FJvCui2aQoabP8b77IGLvMe65q4GHB8?=
 =?us-ascii?Q?1Pbc619OYUoKLmELGzdFb1bHMEUrkS6ZCAaOhZ9lniokkGVhnemz8Mj+Tgwk?=
 =?us-ascii?Q?IdnMqfM3ZqnGG4ZZJBedDoyAqHeY5iaBlEq9/CmEThtYtMTH8inYVvRGREgZ?=
 =?us-ascii?Q?SVRAfIORyjTSBXsEWEQsf0hF1yc8IleOMHCmOBBOXDKDE69W4ieH+a7mil/t?=
 =?us-ascii?Q?x91IfdkcbAlzl3bTgP99vZghLJmzeR6qcEZHdmFwdNsMKCnIJzru6EjiBKvF?=
 =?us-ascii?Q?EsDDYqwTYqzM+Xqfd87K/9ytRvnXC6tJwni8EzfmabDHfwaKtwSEPqP61sBk?=
 =?us-ascii?Q?kZd+GXEH1sc3pU2AvwGFZWrDJc2X6C5Ljvmn/KP/xC84TrWgDUodBv0LWDnl?=
 =?us-ascii?Q?v9bPyOOT/x/5rHyRurzzJM6d2qyh1XUy+WQ01McwYIs12GNroX/nm7hdu6o9?=
 =?us-ascii?Q?53BQqsS14hEwqOd87o8uG0VaK61kFbDCOMmadb2j4uI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 028c6114-302f-4539-1931-08db7e77d281
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2023 23:22:10.1956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OyoqGPBQdb/sBPkv8Lo8iChxNOMJxc5U+OBhf5k/qeR2jQd3eYQbFz/me37Ww7PB9AuOVhoYXENsix6QbEW9wg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6199
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-06_15,2023-07-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 phishscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2307060204
X-Proofpoint-GUID: VB39SPZGEbmRcNxtv-fGtA6dsGhd4EQh
X-Proofpoint-ORIG-GUID: VB39SPZGEbmRcNxtv-fGtA6dsGhd4EQh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/23/23 16:40, Jiaqi Yan wrote:
> Add tests for the improvement made to read operation on HWPOISON
> hugetlb page with different read granularities. For each chunk size,
> three read scenarios are tested:
> 1. Simple regression test on read without HWPOISON.
> 2. Sequential read page by page should succeed until encounters the 1st
>    raw HWPOISON subpage.
> 3. After skip raw HWPOISON subpage by lseek, read()s always succeed.
> 
> Signed-off-by: Jiaqi Yan <jiaqiyan@google.com>
> ---
>  tools/testing/selftests/mm/.gitignore         |   1 +
>  tools/testing/selftests/mm/Makefile           |   1 +
>  .../selftests/mm/hugetlb-read-hwpoison.c      | 322 ++++++++++++++++++
>  3 files changed, 324 insertions(+)
>  create mode 100644 tools/testing/selftests/mm/hugetlb-read-hwpoison.c

Thank you for adding a selftest!

Acked-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz