Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH -next 2/3] md/dm-raid: cleanup multiple equivalent goto
 tags from raid_ctr()
To:     Paul Menzel <pmenzel@molgen.mpg.de>,
        Yu Kuai <yukuai1@huaweicloud.com>
Cc:     agk@redhat.com, snitzer@kernel.org, dm-devel@redhat.com,
        song@kernel.org, heinzm@redhat.com, neilb@suse.de,
        jbrassow@redhat.com, linux-kernel@vger.kernel.org,
        linux-raid@vger.kernel.org, yi.zhang@huawei.com,
        yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
References: <20230706071622.563073-1-yukuai1@huaweicloud.com>
 <20230706071622.563073-3-yukuai1@huaweicloud.com>
 <37c7a3f7-f769-a313-3279-e8e415369ba4@molgen.mpg.de>
From:   Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <c42524a9-6854-673b-d54e-392995483cca@huaweicloud.com>
Date:   Fri, 7 Jul 2023 09:26:36 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <37c7a3f7-f769-a313-3279-e8e415369ba4@molgen.mpg.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

在 2023/07/06 21:01, Paul Menzel 写道:
> Dear Yu,
> 
> 
> Thank you for your patch. Some minor nits, if you are interested.
> 
> Am 06.07.23 um 09:16 schrieb Yu Kuai:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> There are four equivalent goto tags in raid_ctr(), clean them up to use
>> just one, there are no functional change and prepare to fix that
> 
> Maybe:
> 
> There *is* no functional change, and is a preparation to fix an 
> unprotected `md_stop()`.
> 
>> md_stop() is not protected.
> 
> In the commit message summary/title, I’d spell the verb with a space:
> 
>      Clean up four equivalent goto tags in raid_ctr()
> 

Thanks for the suggestions, I'll update them in the next version.

Thanks,
Kuai
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>> ---
>>   drivers/md/dm-raid.c | 27 +++++++++------------------
>>   1 file changed, 9 insertions(+), 18 deletions(-)
> 
> […]
> 
> 
> Kind regards,
> 
> Paul
> 
> .
>